* [ISSUE] xbps-src: multiple dups in runtime depends
@ 2020-04-16 9:05 xtraeme
2020-04-16 16:52 ` Chocimier
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: xtraeme @ 2020-04-16 9:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
New issue by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/21044
Description:
```
[juan@leysa xbps-fbulk]$ cat fbulk-202004161057/bad/live555.txt
=> live555-2019.05.12_1: building [gnu-makefile] for x86_64-musl...
[runtime] live555-2019.05.12_1: not found (self, ignored)
[runtime] live555-2019.05.12_1: not found (self, ignored)
=> live555-2019.05.12_1: running do-fetch hook: 00-distfiles ...
=> live555-2019.05.12_1: fetching distfile 'live.2019.05.12.tar.gz'...
http://www.live555.com/liveMedia/public/live.2019.05.12.tar.gz: Not Found
[juan@leysa xbps-fbulk]$
```
The new code just adds all `depends` from subpkgs without taking into account duplicates.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xbps-src: multiple dups in runtime depends
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
@ 2020-04-16 16:52 ` Chocimier
2020-04-16 16:57 ` xtraeme
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-04-16 16:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/21044#issuecomment-614770842
Comment:
```
=> xkb-switch-1.6.0_1: building [cmake] for x86_64...
[host] cmake-3.17.0_1: found (https://alpha.de.repo.voidlinux.org/current)
[host] cmake-3.17.0_1: found (https://alpha.de.repo.voidlinux.org/current)
[target] libX11-devel-1.6.9_1: found (https://alpha.de.repo.voidlinux.org/current)
[target] libxkbfile-devel-1.1.0_1: found (https://alpha.de.repo.voidlinux.org/current)
```
It is same as for repeated hostmakedepends. Why are duplicates problem?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xbps-src: multiple dups in runtime depends
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
2020-04-16 16:52 ` Chocimier
@ 2020-04-16 16:57 ` xtraeme
2020-04-16 16:59 ` Chocimier
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: xtraeme @ 2020-04-16 16:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/21044#issuecomment-614773265
Comment:
It's not. Host and target make deps arent dups.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xbps-src: multiple dups in runtime depends
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
2020-04-16 16:52 ` Chocimier
2020-04-16 16:57 ` xtraeme
@ 2020-04-16 16:59 ` Chocimier
2020-04-22 18:43 ` Chocimier
2020-04-23 17:15 ` xtraeme
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-04-16 16:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/21044#issuecomment-614774591
Comment:
```
[host] cmake-3.17.0_1: found (https://alpha.de.repo.voidlinux.org/current)
[host] cmake-3.17.0_1: found (https://alpha.de.repo.voidlinux.org/current)
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xbps-src: multiple dups in runtime depends
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
` (2 preceding siblings ...)
2020-04-16 16:59 ` Chocimier
@ 2020-04-22 18:43 ` Chocimier
2020-04-23 17:15 ` xtraeme
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2020-04-22 18:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/issues/21044#issuecomment-617960050
Comment:
Why are exactly duplicates problematic? They are just ignored twice.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: xbps-src: multiple dups in runtime depends
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
` (3 preceding siblings ...)
2020-04-22 18:43 ` Chocimier
@ 2020-04-23 17:15 ` xtraeme
4 siblings, 0 replies; 6+ messages in thread
From: xtraeme @ 2020-04-23 17:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 456 bytes --]
New comment by xtraeme on void-packages repository
https://github.com/void-linux/void-packages/issues/21044#issuecomment-618527324
Comment:
Yes, they are ignored twice and this is the problem. With lots of subpkgs this will slow it down substantially because it needs to process and ignore the same dependency N times.
Also this change makes "./xbps-src show-build-deps" contains lots of dups as well, and this makes xbps-fbulk(1) fail in some cases.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-23 17:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 9:05 [ISSUE] xbps-src: multiple dups in runtime depends xtraeme
2020-04-16 16:52 ` Chocimier
2020-04-16 16:57 ` xtraeme
2020-04-16 16:59 ` Chocimier
2020-04-22 18:43 ` Chocimier
2020-04-23 17:15 ` xtraeme
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).