[ISSUE] Organization requirements

[ISSUE] Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

New issue by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299

Description:

I think the current state of void related to who decides what to push or not is a tragedy. This needs to be improved for the sake of us and all users.

I really think that before someone pushes a change there need to be some requirements:

- For package updates without soname bumps, at least get the change reviewed by 3 people.
- For new packages at least get change reviewed by 3 people.
- For package updates with soname bumps, at least get the changes reviewed by 5 people.
- For xbps-src changes, at least get the changes reviewed by 5 people.
- For reverts, at least get the ok from 5 people.

Otherwise this is just anarchy...

@void-linux/pkg-committers 

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618960210

Comment:
myself included! as long as EVERYBODY respect the same rules!

Re: Organization requirements

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618962639

Comment:
I think if we could come up with a list or a rule for packages that are "high maintenance", getting multiple OKs is a good idea, for most packages I think getting 3 OKs is just going to get 

3 or 5 OKs are required if the package...
* ... is part of base-system.
* ... is a core component of desktop environments.
* ... has over N reverse dependencies.

Re: Organization requirements

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618962639

Comment:
I think if we could come up with a list or a rule for packages that are "high maintenance", getting multiple OKs is a good idea, for most packages I think getting 3 OKs is just going to get tiresome.

3 or 5 OKs are required if the package...
* ... is part of base-system.
* ... is a core component of desktop environments.
* ... has over N reverse dependencies.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618963466

Comment:
I like you suggestion @Duncaen 

Maybe we can relax simple changes to 2 OKs

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618963466

Comment:
I like your suggestion @Duncaen 

Maybe we can relax simple changes to 2 OKs

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618964121

Comment:
That means no unverified pushes without reviews, this includes @thypon @Vaelatern (among others).

Re: Organization requirements

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618964476

Comment:
If I can't bump my own packages, I'm out. I have enough bureaucracy in my life.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618964714

Comment:
@leahneukirchen I agree. I think we should add:

- maintainers are free to push anything related to the pkgs they maintain

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618965238

Comment:
@leahneukirchen this is just a proposal! when everybody agrees to the terms we can make it effective.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618966847

Comment:
I have relaxed the requirements.

Re: Organization requirements

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618966855

Comment:
I think I would prefer a per-package/subsystem CODEOWNERS approach to get explicit approval.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618967744

Comment:
So at least get OK from current pkg maintainer or codeowner (if applicable) ?

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618968408

Comment:
I also think that there are lots of packages with maintainer that do not maintain them! this means if maintainer does not answer in 1 week, submitter can be the current maintainer.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618968561

Comment:
This is what FreeBSD/ports does and I think it's good.

Re: Organization requirements

[sgn]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618971353

Comment:
- I'm OK with the relaxing for non-critical package
- I think those packages in bootstrap list or the one that have equivalent in bootstrap should be reviewed by more people. E.g: I don't want to push nss, git out when noone else tested it. If that package was written by that maintainer, it's a different story.
- For the security update, I don't think we should wait. Fast track is OK to me.
- If the package is causing broken in buildbot, I expect someone fast-track either a fix, revert (with at least some testing) or make it broken.

Re: Organization requirements

[sgn]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618972475

Comment:
Does github have something to notify if a comment or post was modified?
I didn't see the change in OP, at first. I mostly look into my mailbox.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618972644

Comment:
@sgn I think it doesn't.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618972905

Comment:
@void-linux/pkg-committers please speak up. We can get a consensus when all committers agree to the terms.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618976835

Comment:
I agree with @sgn comments

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618977259

Comment:
When the consensus is agreed by all committers I'll create a new file explaining the rules.

Re: Organization requirements

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618997200

Comment:
I though Void Linux was the primary example for (working) anarchy, no? :-P

Anyway, I don't think we need 2 reviews for new packages. As long as a new package doesn't conflict with existing packages (no name clash) and does not conflict or want to provide alternatives, a contributor should be free to add it. This has been helpful when preparing other new packages which require not yet existing dependencies (libraries, compilers, ...).

If a new package contains `conflicts=` or `alternatives=` it should be reviewed.

Other than that I also agree with @sgn.

Re: Organization requirements

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-618997200

Comment:
I thought Void Linux was the primary example for (working) anarchy, no? :-P

Anyway, I don't think we need 2 reviews for new packages. As long as a new package doesn't conflict with existing packages (no name clash) and does not conflict or want to provide alternatives, a contributor should be free to add it. This has been helpful when preparing other new packages which require not yet existing dependencies (libraries, compilers, ...).

If a new package contains `conflicts=` or `alternatives=` it should be reviewed.

Other than that I also agree with @sgn.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619000453

Comment:
ok, I agree with @pullmoll 

Re: Organization requirements

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619031081

Comment:
I only agree to restrictions on the bootstrap set. Everything else is just additional rules for the sake of rules.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619044131

Comment:
ok, let's continue with more opinions.

Re: Organization requirements

[q66]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619048446

Comment:
I don't think we need a new set of rules. How about fixing your own problems before implying there are issues with the system first?

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619069546

Comment:
My issues are mine. This is not about my issues, it's about issues related to this organization that I started.

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619073349

Comment:
The same organization that people think I'm not able to comment! if I didn't start it you weren't commenting it... so let's relax.

Re: Organization requirements

[Anachron]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619073800

Comment:
I hope it's ok if I join the discussion.
As a Contributor for nearly two years now I want to give my 2 cents to this topic.

1.) I don't think it's beneficial for anybody to get personal here. 
2.) I don't see how being a code owner/organization starter gives the permission to push things the Community/other Maintainers are not OK with. This is just provoking issues along the road.
3.) Enforcing new rules may be a direction to go here, as long as all maintainers and contributors are in the same boat. Else we end up loosing useful resources which is quite contra-productive.
4.) As far as I can tell the issue is just becoming bigger because you, @xtraeme, disagree how things are handled?
5.) Last but not least, don't [become insulting](https://github.com/void-linux/xbps/issues/275#issuecomment-619071620). Please keep the discussion to a civilized tone. 

Re: [ISSUE] [CLOSED] Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Closed issue by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299

Description:
I think the current state of void related to who decides what to push or not is a tragedy. This needs to be improved for the sake of us and all users.

I really think that before someone pushes a change there need to be some requirements:

- For package updates being updated by the current maintainer, no review necessary.
- For package updates without soname bumps, at least get the change reviewed by 2 people.
- For new packages at least get change reviewed by 2 people.
- For package updates with soname bumps, at least get the changes reviewed by 5 people.
- For xbps-src changes, at least get the changes reviewed by 5 people.
- For reverts, at least get the ok from 5 people.

Otherwise this is just anarchy...

@void-linux/pkg-committers 

Re: Organization requirements

[xtraeme]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by xtraeme on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619078859

Comment:
let's continue with your stupid rules, I don't give a fuck

Re: Organization requirements

[Anachron]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619083654

Comment:
@xtraeme please cool down and come back once you have a clear picture of whats happening. Your treatment of other contributors is in no regard ok. 

Void is your idea, we get it. But that doesnt change that everybody should be treated fair and respectful.

Re: Organization requirements

[Mothrakk]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by Mothrakk on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619189684

Comment:
@xtraeme don't let these trannies tell you what to do, it's your project, if they don't like it they can fuck off or fork it

Re: Organization requirements

[rugalash]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by rugalash on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619201944

Comment:
All of you dweebs should calm down and just go about your business, stop obsessing over how and why others do what they do. 

Re: Organization requirements

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/issues/21299#issuecomment-619202422

Comment:
Aaand locked to contributors.