Github messages for voidlinux
 help / color / mirror / Atom feed
* Re: spotifyd: add build_options
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21446@inbox.vuxu.org>
@ 2020-04-29 15:54 ` abenson
  2020-04-29 21:37 ` jnbr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 4+ messages in thread
From: abenson @ 2020-04-29 15:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/21446#issuecomment-621302406

Comment:
Lgtm. Originally editing the Cargo.toml was needed because the compilation flags weren't working. It seems that's been fixed since then.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: spotifyd: add build_options
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21446@inbox.vuxu.org>
                   ` (2 preceding siblings ...)
  2020-04-30 23:28 ` ericonr
@ 2020-05-02 13:12 ` ericonr
  3 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-05-02 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/21446#issuecomment-622951712

Comment:
Sorry for this one! I made some changes after testing that I'd thought wouldn't affect the package. Turns out they did. Things should be mostly ok, now.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: spotifyd: add build_options
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21446@inbox.vuxu.org>
  2020-04-29 15:54 ` spotifyd: add build_options abenson
  2020-04-29 21:37 ` jnbr
@ 2020-04-30 23:28 ` ericonr
  2020-05-02 13:12 ` ericonr
  3 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-04-30 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/21446#issuecomment-622172985

Comment:
@jnbr thanks for the suggestion, looks much better!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: spotifyd: add build_options
       [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21446@inbox.vuxu.org>
  2020-04-29 15:54 ` spotifyd: add build_options abenson
@ 2020-04-29 21:37 ` jnbr
  2020-04-30 23:28 ` ericonr
  2020-05-02 13:12 ` ericonr
  3 siblings, 0 replies; 4+ messages in thread
From: jnbr @ 2020-04-29 21:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/21446#issuecomment-621478521

Comment:
You can keep it a bit shorter by using `vopt_if`.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-02 13:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-21446@inbox.vuxu.org>
2020-04-29 15:54 ` spotifyd: add build_options abenson
2020-04-29 21:37 ` jnbr
2020-04-30 23:28 ` ericonr
2020-05-02 13:12 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).