* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
@ 2020-05-04 13:27 ` sgn
2020-05-04 13:29 ` sgn
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2020-05-04 13:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2125 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623463277
Comment:
@ailiop-git, I'll push https://github.com/sgn/void-packages/commit/a2db04e5098f35e8e14f1b1e7ac1f2f695f766d7 if you don't have objection:
```diff
diff --git a/srcpkgs/profanity/template b/srcpkgs/profanity/template
index 2dccec1bd3..ec940d98d1 100644
--- a/srcpkgs/profanity/template
+++ b/srcpkgs/profanity/template
@@ -1,15 +1,17 @@
# Template file for 'profanity'
pkgname=profanity
version=0.8.1
-revision=1
+revision=2
build_style=gnu-configure
configure_args="$(vopt_enable notify notifications) $(vopt_enable otr)
$(vopt_enable pgp) $(vopt_enable python python-plugins) $(vopt_enable plugins)
-$(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons) $(vopt_enable cplugins c-plugins)"
-hostmakedepends="pkg-config $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)"
+$(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons)
+$(vopt_enable cplugins c-plugins) ac_cv_prog_PYTHON_CONFIG_EXISTS=yes
+PYTHON_VERSION=3"
+hostmakedepends="pkg-config $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)"
makedepends="libcurl-devel libglib-devel libstrophe-devel readline-devel
$(vopt_if notify libnotify-devel) $(vopt_if otr 'libotr-devel libgcrypt-devel')
- $(vopt_if pgp gpgme-devel) $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)
+ $(vopt_if pgp gpgme-devel) $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)
$(vopt_if xscreensaver libXScrnSaver-devel) $(vopt_if omemo 'libsignal-protocol-c libgcrypt-devel')"
checkdepends="cmocka-devel"
short_desc="Console based XMPP client"
@@ -23,8 +25,8 @@ export LIBS="-lm"
case "$XBPS_TARGET_MACHINE" in
arm*)
- export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py2_inc}"
- export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py2_ver}" ;;
+ export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
+ export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py3_ver}" ;;
esac
# Package build options
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
2020-05-04 13:27 ` sgn
@ 2020-05-04 13:29 ` sgn
2020-05-04 13:35 ` sgn
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2020-05-04 13:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2158 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623463277
Comment:
@ailiop-git, I'll push https://github.com/sgn/void-packages/commit/a2db04e5098f35e8e14f1b1e7ac1f2f695f766d7
if you don't have objection (please test, I haven't tested):
```diff
diff --git a/srcpkgs/profanity/template b/srcpkgs/profanity/template
index 2dccec1bd3..ec940d98d1 100644
--- a/srcpkgs/profanity/template
+++ b/srcpkgs/profanity/template
@@ -1,15 +1,17 @@
# Template file for 'profanity'
pkgname=profanity
version=0.8.1
-revision=1
+revision=2
build_style=gnu-configure
configure_args="$(vopt_enable notify notifications) $(vopt_enable otr)
$(vopt_enable pgp) $(vopt_enable python python-plugins) $(vopt_enable plugins)
-$(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons) $(vopt_enable cplugins c-plugins)"
-hostmakedepends="pkg-config $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)"
+$(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons)
+$(vopt_enable cplugins c-plugins) ac_cv_prog_PYTHON_CONFIG_EXISTS=yes
+PYTHON_VERSION=3"
+hostmakedepends="pkg-config $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)"
makedepends="libcurl-devel libglib-devel libstrophe-devel readline-devel
$(vopt_if notify libnotify-devel) $(vopt_if otr 'libotr-devel libgcrypt-devel')
- $(vopt_if pgp gpgme-devel) $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)
+ $(vopt_if pgp gpgme-devel) $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)
$(vopt_if xscreensaver libXScrnSaver-devel) $(vopt_if omemo 'libsignal-protocol-c libgcrypt-devel')"
checkdepends="cmocka-devel"
short_desc="Console based XMPP client"
@@ -23,8 +25,8 @@ export LIBS="-lm"
case "$XBPS_TARGET_MACHINE" in
arm*)
- export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py2_inc}"
- export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py2_ver}" ;;
+ export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
+ export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py3_ver}" ;;
esac
# Package build options
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
2020-05-04 13:27 ` sgn
2020-05-04 13:29 ` sgn
@ 2020-05-04 13:35 ` sgn
2020-05-04 13:54 ` ailiop-git
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2020-05-04 13:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623463277
Comment:
@ailiop-git, I'll push https://github.com/sgn/void-packages/commit/71592dd7f4
if you don't have objection (please test, I haven't tested):
```diff
diff --git a/srcpkgs/profanity/template b/srcpkgs/profanity/template
index 2dccec1bd3..0776f12708 100644
--- a/srcpkgs/profanity/template
+++ b/srcpkgs/profanity/template
@@ -1,16 +1,20 @@
# Template file for 'profanity'
pkgname=profanity
version=0.8.1
-revision=1
+revision=2
build_style=gnu-configure
configure_args="$(vopt_enable notify notifications) $(vopt_enable otr)
-$(vopt_enable pgp) $(vopt_enable python python-plugins) $(vopt_enable plugins)
-$(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons) $(vopt_enable cplugins c-plugins)"
-hostmakedepends="pkg-config $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)"
+ $(vopt_enable pgp) $(vopt_enable python python-plugins) $(vopt_enable plugins)
+ $(vopt_with xscreensaver) $(vopt_enable omemo) $(vopt_enable gtk icons)
+ $(vopt_enable cplugins c-plugins)
+ ac_cv_prog_PYTHON_CONFIG_EXISTS=yes
+ PYTHON_VERSION=3"
+hostmakedepends="pkg-config $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)"
makedepends="libcurl-devel libglib-devel libstrophe-devel readline-devel
$(vopt_if notify libnotify-devel) $(vopt_if otr 'libotr-devel libgcrypt-devel')
- $(vopt_if pgp gpgme-devel) $(vopt_if python python-devel) $(vopt_if gtk gtk+-devel)
- $(vopt_if xscreensaver libXScrnSaver-devel) $(vopt_if omemo 'libsignal-protocol-c libgcrypt-devel')"
+ $(vopt_if pgp gpgme-devel) $(vopt_if python python3-devel) $(vopt_if gtk gtk+-devel)
+ $(vopt_if xscreensaver libXScrnSaver-devel)
+ $(vopt_if omemo 'libsignal-protocol-c libgcrypt-devel')"
checkdepends="cmocka-devel"
short_desc="Console based XMPP client"
maintainer="Anthony Iliopoulos <ailiop@altatus.com>"
@@ -23,8 +27,8 @@ export LIBS="-lm"
case "$XBPS_TARGET_MACHINE" in
arm*)
- export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py2_inc}"
- export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py2_ver}" ;;
+ export PYTHON_CPPFLAGS="-I${XBPS_CROSS_BASE}/${py3_inc}"
+ export PYTHON_EXTRA_LIBS="-L${XBPS_CROSS_BASE}/usr/lib -lpython${py3_ver}" ;;
esac
# Package build options
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (2 preceding siblings ...)
2020-05-04 13:35 ` sgn
@ 2020-05-04 13:54 ` ailiop-git
2020-05-04 17:23 ` ErinVoid
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ailiop-git @ 2020-05-04 13:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
New comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623478628
Comment:
i'm really not using python (or python plugins for profanity), but i suppose given that python2 is being EOLed it wouldn't generally hurt to switch to 3, and your patch appears to at least build (at least on x86_64/glibc).
Keep in mind though that the change may of course break any plugins that are written/compatible with only python2 (we don't package profanity-plugins, but still).
So the question here is @ErinVoid why is it necessary to switch to python3? AFAIU profanity-plugins are written in python2. If there is no use for them, we may as well completely disable the python dependency on this package.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (3 preceding siblings ...)
2020-05-04 13:54 ` ailiop-git
@ 2020-05-04 17:23 ` ErinVoid
2020-05-04 17:44 ` ailiop-git
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ErinVoid @ 2020-05-04 17:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
New comment by ErinVoid on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623595815
Comment:
Thanks for the replies.
@ailiop-git Apart from Python2 is EoL and it would be the only application on my PC requiring it, just personal preference. However, from [https://profanity-im.github.io/plugins.html](url) it confirms the Profanity can be complied with Python 2 or 3 and the plugins should run with either. It would be very useful to have the OMEMO support.
> Profanity may be compiled against Python 2 or Python 3, so plugins should be able to work with both, the future library can be used in most cases.
One question, for my curiosity, why is gtk mentioned on a CLI application?
Merci.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (4 preceding siblings ...)
2020-05-04 17:23 ` ErinVoid
@ 2020-05-04 17:44 ` ailiop-git
2020-05-04 23:07 ` sgn
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ailiop-git @ 2020-05-04 17:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
New comment by ailiop-git on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623606505
Comment:
> Apart from Python2 is EoL and it would be the only application on my PC requiring it, just personal preference. However, from [https://profanity-im.github.io/plugins.html](url) it confirms the Profanity can be complied with Python 2 or 3 and the plugins should run with either.
If you are using plugins and can confirm that it is working with python 3, then I have no objections. As mentioned, we could also consider disabling python by default if people aren't using the functionality (and still merge the v3 support).
> It would be very useful to have the OMEMO support.
It's by default built, and doesn't depend on python. I'd actually ask again if anyone is using it (I'd think OTR is more popular), and otherwise disable it by default.
> One question, for my curiosity, why is gtk mentioned on a CLI application?
Seems to be a dependency to the tray functionality [1], but I'd be all for disabling this by default.
[1] https://profanity-im.github.io/guide/latest/reference.html#tray
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (5 preceding siblings ...)
2020-05-04 17:44 ` ailiop-git
@ 2020-05-04 23:07 ` sgn
2020-05-05 8:06 ` teldra
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2020-05-04 23:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623754255
Comment:
On 2020-05-04 10:44:27-0700, ailiop-git <notifications@github.com> wrote:
> > Apart from Python2 is EoL and it would be the only application on my PC requiring it, just personal preference. However, from [https://profanity-im.github.io/plugins.html](url) it confirms the Profanity can be complied with Python 2 or 3 and the plugins should run with either.
>
> If you are using plugins and can confirm that it is working with
> python 3, then I have no objections. As mentioned, we could also
> consider disabling python by default if people aren't using the
> functionality (and still merge the v3 support).
I think it'll be better to push it out and wait to see if anyone
complains.
--
Danh
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (6 preceding siblings ...)
2020-05-04 23:07 ` sgn
@ 2020-05-05 8:06 ` teldra
2020-05-05 8:33 ` ErinVoid
2020-05-05 16:39 ` [ISSUE] [CLOSED] " sgn
9 siblings, 0 replies; 11+ messages in thread
From: teldra @ 2020-05-05 8:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
New comment by teldra on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623916204
Comment:
> > It would be very useful to have the OMEMO support.
>
> It's by default built, and doesn't depend on python. I'd actually ask again if anyone is using it (I'd think OTR is more popular), and otherwise disable it by default.
OMEMO should left turned on. Many XMPP Clients offer OMEMO support. Some exclusively (Conversations, Gajim, Dino..) In profanity its supported via libsignal-c library.
Profanity v0.8.x was mostly about implementing OMEMO.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (7 preceding siblings ...)
2020-05-05 8:06 ` teldra
@ 2020-05-05 8:33 ` ErinVoid
2020-05-05 16:39 ` [ISSUE] [CLOSED] " sgn
9 siblings, 0 replies; 11+ messages in thread
From: ErinVoid @ 2020-05-05 8:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
New comment by ErinVoid on void-packages repository
https://github.com/void-linux/void-packages/issues/21587#issuecomment-623927707
Comment:
From what everyone is writing, just an uplift to Python3 would be ideal. Leaving everything else as-is, i.e. Python support in, including OMEMO (and OTR even though more and more apps no longer support it) and gtk.
@ailiop-git thanks for clarifying about gtk. Just curious as trying to improve my software/dev understanding.
Thank you all for being involved and making this happen.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [ISSUE] [CLOSED] Profanity Python dependency version uplift
2020-05-03 16:45 [ISSUE] Profanity Python dependency version uplift ErinVoid
` (8 preceding siblings ...)
2020-05-05 8:33 ` ErinVoid
@ 2020-05-05 16:39 ` sgn
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2020-05-05 16:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Closed issue by ErinVoid on void-packages repository
https://github.com/void-linux/void-packages/issues/21587
Description:
* package:
profanity 0.81
Can this be adjusted/rebuilt to have Python3 as a dependency rather than the current Python2 please. It is possible, see #https://github.com/profanity-im/profanity/issues/825. Thank you.
^ permalink raw reply [flat|nested] 11+ messages in thread