[PR PATCH] xtools: added spdx-licenses-list for linting license field

[PR PATCH] xtools: added spdx-licenses-list for linting license field

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

There is a new pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages xtools
https://github.com/void-linux/void-packages/pull/21706

xtools: added spdx-licenses-list for linting license field
See: https://github.com/leahneukirchen/xtools/issues/180#issuecomment-624752073

A patch file from https://github.com/void-linux/void-packages/pull/21706.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xtools-21706.patch --]
[-- Type: text/x-diff, Size: 785 bytes --]

From e0dbdde2cf567b697ce825cb57c63d8251530376 Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Wed, 6 May 2020 15:16:20 -0700
Subject: [PATCH] xtools: added spdx-licenses-list for linting license field

---
 srcpkgs/xtools/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/xtools/template b/srcpkgs/xtools/template
index cff2316029e..a69f7a71d37 100644
--- a/srcpkgs/xtools/template
+++ b/srcpkgs/xtools/template
@@ -4,7 +4,7 @@ version=0.58
 revision=1
 archs="noarch"
 build_style=gnu-makefile
-depends="bash curl findutils git make xbps"
+depends="bash curl findutils git make xbps spdx-licenses-list"
 short_desc="Opinionated helpers for working with XBPS"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="Public Domain"

Re: [PR PATCH] [Updated] xtools: added spdx-licenses-list for linting license field

[anjandev]

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

There is an updated pull request by anjandev against master on the void-packages repository

https://github.com/anjandev/void-packages xtools
https://github.com/void-linux/void-packages/pull/21706

xtools: added spdx-licenses-list for linting license field
See: https://github.com/leahneukirchen/xtools/issues/180#issuecomment-624752073

@Chocimier 

A patch file from https://github.com/void-linux/void-packages/pull/21706.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xtools-21706.patch --]
[-- Type: text/x-diff, Size: 850 bytes --]

From ba3d434eb28cb789ab1fc220b1e3ce0820384c18 Mon Sep 17 00:00:00 2001
From: Anjandev Momi <anjan@momi.ca>
Date: Wed, 6 May 2020 15:16:20 -0700
Subject: [PATCH] xtools: added spdx-licenses-list for linting license field

---
 srcpkgs/xtools/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/xtools/template b/srcpkgs/xtools/template
index cff2316029e..b3786f6f30f 100644
--- a/srcpkgs/xtools/template
+++ b/srcpkgs/xtools/template
@@ -1,10 +1,10 @@
 # Template file for 'xtools'
 pkgname=xtools
 version=0.58
-revision=1
+revision=2
 archs="noarch"
 build_style=gnu-makefile
-depends="bash curl findutils git make xbps"
+depends="bash curl findutils git make xbps spdx-licenses-list"
 short_desc="Opinionated helpers for working with XBPS"
 maintainer="Leah Neukirchen <leah@vuxu.org>"
 license="Public Domain"

Re: xtools: added spdx-licenses-list for linting license field

[sgn]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21706#issuecomment-625245372

Comment:
I'm not really sold on this idea.
`xbps-src` has a `licenses.lst` in `common/travis/license.lst`

I would modify `xlint` to fallback to that file instead.

Re: xtools: added spdx-licenses-list for linting license field

[Anachron]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by Anachron on void-packages repository

https://github.com/void-linux/void-packages/pull/21706#issuecomment-625255354

Comment:
Sgn if someone installs xtools and uses xlint without a license list it can return false positives this way. 

Re: xtools: added spdx-licenses-list for linting license field

[sgn]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21706#issuecomment-625331145

Comment:
> Sgn if someone installs xtools and uses xlint without a license list,
> it can return false positives this way.

I'm fine either ways, that packages doesn't cost me much, anyway.
I'll it to Leah to decide.

Re: xtools: added spdx-licenses-list for linting license field

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/21706#issuecomment-626008758

Comment:
> I would modify xlint to fallback to that file instead.

Could be done too, but now xlint is so simple it don't even know about `common/`, and this is beauty.

@leahneukirchen, comments?

Re: xtools: added spdx-licenses-list for linting license field

[sgn]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/21706#issuecomment-661855635

Comment:
OK by leah2 on IRC.

Re: [PR PATCH] [Closed]: xtools: added spdx-licenses-list for linting license field

[sgn]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

There's a closed pull request on the void-packages repository

xtools: added spdx-licenses-list for linting license field
https://github.com/void-linux/void-packages/pull/21706

Description:
See: https://github.com/leahneukirchen/xtools/issues/180#issuecomment-624752073

@Chocimier