* [PR PATCH] croc: fix go_import_path to fetch correct version
@ 2020-05-12 14:40 ahesford
2020-05-12 17:41 ` [PR PATCH] [Merged]: " Hoshpak
0 siblings, 1 reply; 2+ messages in thread
From: ahesford @ 2020-05-12 14:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
There is a new pull request by ahesford against master on the void-packages repository
https://github.com/ahesford/void-packages croc
https://github.com/void-linux/void-packages/pull/21885
croc: fix go_import_path to fetch correct version
The `go_import_path` for `croc` was hard-coded to download `v6` instead of the current `v8`, so version 6.4.10-073569f was packaged instead of `8.0.10-6dc44ec`. This PR fixes the `go_import_path` by using the major part of `version` to hopefully avoid this issue when the major number next jumps.
cc: @benalb
A patch file from https://github.com/void-linux/void-packages/pull/21885.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-croc-21885.patch --]
[-- Type: text/x-diff, Size: 825 bytes --]
From 32b9bb6a7df15c50ae11ac388c1e833a3791f325 Mon Sep 17 00:00:00 2001
From: "Andrew J. Hesford" <ajh@sideband.org>
Date: Tue, 12 May 2020 10:36:40 -0400
Subject: [PATCH] croc: fix go_import_path to fetch correct version
---
srcpkgs/croc/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/croc/template b/srcpkgs/croc/template
index 11f8a0a26dc..d9eb819eaf3 100644
--- a/srcpkgs/croc/template
+++ b/srcpkgs/croc/template
@@ -1,9 +1,9 @@
# Template file for 'croc'
pkgname=croc
version=8.0.10
-revision=1
+revision=2
build_style=go
-go_import_path=github.com/schollz/croc/v6
+go_import_path=github.com/schollz/croc/v${version%%.*}
hostmakedepends="git"
short_desc="Easily and securely send things from one computer to another"
maintainer="Benjamín Albiñana <benalb@gmail.com>"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PR PATCH] [Merged]: croc: fix go_import_path to fetch correct version
2020-05-12 14:40 [PR PATCH] croc: fix go_import_path to fetch correct version ahesford
@ 2020-05-12 17:41 ` Hoshpak
0 siblings, 0 replies; 2+ messages in thread
From: Hoshpak @ 2020-05-12 17:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
There's a merged pull request on the void-packages repository
croc: fix go_import_path to fetch correct version
https://github.com/void-linux/void-packages/pull/21885
Description:
The `go_import_path` for `croc` was hard-coded to download `v6` instead of the current `v8`, so version 6.4.10-073569f was packaged instead of `8.0.10-6dc44ec`. This PR fixes the `go_import_path` by using the major part of `version` to hopefully avoid this issue when the major number next jumps.
cc: @benalb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-12 17:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 14:40 [PR PATCH] croc: fix go_import_path to fetch correct version ahesford
2020-05-12 17:41 ` [PR PATCH] [Merged]: " Hoshpak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).