* [PR PATCH] libbluray: enable building bdjava
@ 2020-05-16 19:44 ericonr
2020-05-19 8:21 ` DeepwaterCreations
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ericonr @ 2020-05-16 19:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages bluray
https://github.com/void-linux/void-packages/pull/22018
libbluray: enable building bdjava
Fixes #21641
I'm assuming optimizations were disabled for some reason, we could consider re-enabling them. @DeepwaterCreations, if you could test this out? I'd like to know if it can work without Java installed, because it currently doesn't have Java as a hard dependency.
A patch file from https://github.com/void-linux/void-packages/pull/22018.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bluray-22018.patch --]
[-- Type: text/x-diff, Size: 1546 bytes --]
From 3f09d4feb0ddc4f0e80eba710b57d06ffdf84f74 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Sat, 16 May 2020 16:41:43 -0300
Subject: [PATCH] libbluray: enable building bdjava
---
srcpkgs/libbluray/template | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/libbluray/template b/srcpkgs/libbluray/template
index a758c0223a1..6d2aeb0a5fe 100644
--- a/srcpkgs/libbluray/template
+++ b/srcpkgs/libbluray/template
@@ -1,10 +1,10 @@
# Template file for 'libbluray'
pkgname=libbluray
version=1.2.0
-revision=1
+revision=2
build_style=gnu-configure
-configure_args="--disable-static --disable-optimizations --disable-bdjava-jar"
-hostmakedepends="pkg-config"
+configure_args="--disable-static --disable-optimizations"
+hostmakedepends="pkg-config apache-ant openjdk8"
makedepends="libxml2-devel fontconfig-devel"
short_desc="Library to access Blu-Ray disks for video playback"
maintainer="Orphaned <orphan@voidlinux.org>"
@@ -13,6 +13,14 @@ homepage="https://www.videolan.org/developers/libbluray.html"
distfiles="https://download.videolan.org/pub/videolan/libbluray/${version}/libbluray-${version}.tar.bz2"
checksum=cd41ea06fd2512a77ebf63872873641908ef81ce2fe4e4c842f6035a47696c11
+pre_build() {
+ export JAVA_HOME="/usr/lib/jvm/java-1.8-openjdk"
+}
+
+pre_install() {
+ export JAVA_HOME="/usr/lib/jvm/java-1.8-openjdk"
+}
+
libbluray-devel_package() {
depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
short_desc+=" - development files"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libbluray: enable building bdjava
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
@ 2020-05-19 8:21 ` DeepwaterCreations
2020-05-19 9:10 ` DeepwaterCreations
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: DeepwaterCreations @ 2020-05-19 8:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
New comment by DeepwaterCreations on void-packages repository
https://github.com/void-linux/void-packages/pull/22018#issuecomment-630665464
Comment:
Hmm... now I can't get anything but
```
[00007f9ac8001120] libbluray demux error: BD-J menus not supported. Playing without menus. BD-J support: 1, JVM found: 0, JVM usable: 0
```
even with openjdk installed... but that doesn't go away if I revert back to the unmodified libbluray template, so it might be some unrelated problem. (Previously it was `JVM found: 1, JVM usable: 0`)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libbluray: enable building bdjava
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
2020-05-19 8:21 ` DeepwaterCreations
@ 2020-05-19 9:10 ` DeepwaterCreations
2020-05-19 17:01 ` abenson
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: DeepwaterCreations @ 2020-05-19 9:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
New comment by DeepwaterCreations on void-packages repository
https://github.com/void-linux/void-packages/pull/22018#issuecomment-630693065
Comment:
Okay, never mind, I sorted my issue out. It was just a problem with JDK_HOME not being set.
So with your changes, the package installs with or without Java installed, and it does indeed fix my original problem. :+1:
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libbluray: enable building bdjava
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
2020-05-19 8:21 ` DeepwaterCreations
2020-05-19 9:10 ` DeepwaterCreations
@ 2020-05-19 17:01 ` abenson
2020-05-19 17:20 ` abenson
2020-05-19 17:20 ` [PR PATCH] [Merged]: " abenson
4 siblings, 0 replies; 6+ messages in thread
From: abenson @ 2020-05-19 17:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
New comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/22018#issuecomment-630951788
Comment:
Hm, menus work for me but sound doesn't... I haven't done much with bluray so I don't know if this disc or not.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libbluray: enable building bdjava
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
` (2 preceding siblings ...)
2020-05-19 17:01 ` abenson
@ 2020-05-19 17:20 ` abenson
2020-05-19 17:20 ` [PR PATCH] [Merged]: " abenson
4 siblings, 0 replies; 6+ messages in thread
From: abenson @ 2020-05-19 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by abenson on void-packages repository
https://github.com/void-linux/void-packages/pull/22018#issuecomment-630962099
Comment:
Sound works... turns out the speakers turn off if you have headphones plugged in.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: libbluray: enable building bdjava
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
` (3 preceding siblings ...)
2020-05-19 17:20 ` abenson
@ 2020-05-19 17:20 ` abenson
4 siblings, 0 replies; 6+ messages in thread
From: abenson @ 2020-05-19 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
There's a merged pull request on the void-packages repository
libbluray: enable building bdjava
https://github.com/void-linux/void-packages/pull/22018
Description:
Fixes #21641
I'm assuming optimizations were disabled for some reason, we could consider re-enabling them. @DeepwaterCreations, if you could test this out? I'd like to know if it can work without Java installed, because it currently doesn't have Java as a hard dependency.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-19 17:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-16 19:44 [PR PATCH] libbluray: enable building bdjava ericonr
2020-05-19 8:21 ` DeepwaterCreations
2020-05-19 9:10 ` DeepwaterCreations
2020-05-19 17:01 ` abenson
2020-05-19 17:20 ` abenson
2020-05-19 17:20 ` [PR PATCH] [Merged]: " abenson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).