[PR PATCH] vpnd: update to 0.1.2

[PR PATCH] vpnd: update to 0.1.2

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

There is a new pull request by emacsomancer against master on the void-packages repository

https://github.com/emacsomancer/void-packages vpnd-0.1.2
https://github.com/void-linux/void-packages/pull/22111

vpnd: update to 0.1.2
*Breaking changes:*
- in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
   - also new settings introduced
- `yad` removed from dependencies since notification option
  introduced (users who want systray icon should (re)install `yad`)

*Improvements:*
- optional notifications via notify-send(.sh)
- connectivity check (if ncat/nmap/curl are installed)
- ability to run w/o yad (if no systray is desired) via notify-send(.sh)
- fixes to formatting of `xbps` update output

A patch file from https://github.com/void-linux/void-packages/pull/22111.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vpnd-0.1.2-22111.patch --]
[-- Type: text/x-diff, Size: 2341 bytes --]

From c9242ec8587aff1fd27005eda0c4fdbf47faeb6f Mon Sep 17 00:00:00 2001
From: Benjamin Slade <slade@jnanam.net>
Date: Mon, 18 May 2020 22:08:20 -0600
Subject: [PATCH] vpnd: update to 0.1.2

*Breaking changes:*
- in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
   - also new settings introduced
- `yad` removed from dependencies since notification option
  introduced (users who want systray icon should (re)install `yad`)

*Improvements:*
- optional notifications via notify-send(.sh)
- connectivity check (if ncat/nmap/curl are installed)
- ability to run w/o yad (if no systray is desired) via notify-send(.sh)
- fixes to formatting of `xbps` update output
---
 srcpkgs/vpnd/INSTALL.msg | 9 +++++++++
 srcpkgs/vpnd/template    | 8 ++++----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/vpnd/INSTALL.msg b/srcpkgs/vpnd/INSTALL.msg
index 3dc156ea77a..b31475e7f50 100644
--- a/srcpkgs/vpnd/INSTALL.msg
+++ b/srcpkgs/vpnd/INSTALL.msg
@@ -1,2 +1,11 @@
+* Breaking changes for 0.1.2:
+  - no longer has `yad` as dependency - install `yad` if you want a systray icon
+  - in vpnd.conf, icons are now referenced without the 'icon:' prefix in the path 
+
+Has additional functionality when the following are installed:
+  - `yad` provides systray icon notifier
+  - `notify-send(.sh)` provides pop-up notifications
+  - `ncat`/`nmap`/`curl` provides connectivity checks
+
 See the vpnd.conf file in /etc for customisation options
 (including different icons themes).
diff --git a/srcpkgs/vpnd/template b/srcpkgs/vpnd/template
index 7efe0f122f4..75f82871b05 100644
--- a/srcpkgs/vpnd/template
+++ b/srcpkgs/vpnd/template
@@ -1,15 +1,15 @@
 # Template file for 'vpnd'
 pkgname=vpnd
-version=0.1.1
+version=0.1.2
 revision=1
 archs=noarch
-depends="bash yad"
-short_desc="Systray notifier for Void Linux packages"
+depends="bash"
+short_desc="Package update notifier daemon for Void Linux"
 maintainer="Benjamin Slade <slade@lambda-y.net>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/emacsomancer/vpnd"
 distfiles="https://gitlab.com/emacsomancer/vpnd/-/archive/${version}/${pkgname}-${version}.tar.gz"
-checksum=49e148766f1e0bdb4a48d58bd72448e72c977f4c326393d694ae0cce2b42f6f9
+checksum=8fe090f5a9512839f4989e60db2d6f9a8d3f91ef5103300166713108bb823ed3
 
 do_install() {
 	vbin vpnd

Re: vpnd: update to 0.1.2

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-630670026

Comment:
you probably want to add the conf file to `conf_files=` so users' changes won't get overwritten on update

Re: vpnd: update to 0.1.2

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-630670026

Comment:
you probably want to add the conf file to `conf_files=` so users' changes won't get overwritten on update

Re: vpnd: update to 0.1.2

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by emacsomancer on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-630719701

Comment:
thanks. I'll update accordingly.

query for the install text: should I mention breaking changes here (removal of yad as dependency, changes to .conf) at all? or just assume users will check the changelog?

Re: [PR PATCH] [Updated] vpnd: update to 0.1.2

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

There is an updated pull request by emacsomancer against master on the void-packages repository

https://github.com/emacsomancer/void-packages vpnd-0.1.2
https://github.com/void-linux/void-packages/pull/22111

vpnd: update to 0.1.2
*Breaking changes:*
- in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
   - also new settings introduced
- `yad` removed from dependencies since notification option
  introduced (users who want systray icon should (re)install `yad`)

*Improvements:*
- optional notifications via notify-send(.sh)
- connectivity check (if ncat/nmap/curl are installed)
- ability to run w/o yad (if no systray is desired) via notify-send(.sh)
- fixes to formatting of `xbps` update output

A patch file from https://github.com/void-linux/void-packages/pull/22111.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vpnd-0.1.2-22111.patch --]
[-- Type: text/x-diff, Size: 2311 bytes --]

From 3d6638d5a7e5746d99ee0a6982f0624ca93094d2 Mon Sep 17 00:00:00 2001
From: Benjamin Slade <slade@jnanam.net>
Date: Mon, 18 May 2020 22:08:20 -0600
Subject: [PATCH] vpnd: update to 0.1.2.1

* 0.1.2.1
- in package
  - simplify connectivity check to use ping (+ fixes)

- in template:
  - add relevant conf_files field

- in install msgs:
  - condense to 2 lines

* 0.1.2
- Breaking changes:
   - in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
     - also new settings introduced
   - `yad` removed from dependencies since notification option
  introduced (users who want systray icon should (re)install `yad`)

- Improvements:
   - optional notifications via notify-send(.sh)
   - connectivity check (if ncat/nmap/curl are installed)
   - ability to run w/o yad (if no systray is desired) via notify-send(.sh)
   - fixes to formatting of `xbps` update output
---
 srcpkgs/vpnd/INSTALL.msg | 4 ++--
 srcpkgs/vpnd/template    | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/vpnd/INSTALL.msg b/srcpkgs/vpnd/INSTALL.msg
index 3dc156ea77a..974925ce98c 100644
--- a/srcpkgs/vpnd/INSTALL.msg
+++ b/srcpkgs/vpnd/INSTALL.msg
@@ -1,2 +1,2 @@
-See the vpnd.conf file in /etc for customisation options
-(including different icons themes).
+- Has additional functionality when yad and notify-send(.sh) are installed
+* 0.1.2 breaking changes: reinstall yad for systray; new image paths in vpnd.conf
diff --git a/srcpkgs/vpnd/template b/srcpkgs/vpnd/template
index 7efe0f122f4..d015caeca08 100644
--- a/srcpkgs/vpnd/template
+++ b/srcpkgs/vpnd/template
@@ -1,15 +1,16 @@
 # Template file for 'vpnd'
 pkgname=vpnd
-version=0.1.1
+version=0.1.2.1
 revision=1
 archs=noarch
-depends="bash yad"
-short_desc="Systray notifier for Void Linux packages"
+depends="bash"
+conf_files="/etc/vpnd.conf"
+short_desc="Package update notifier daemon for Void Linux"
 maintainer="Benjamin Slade <slade@lambda-y.net>"
 license="GPL-3.0-or-later"
 homepage="https://gitlab.com/emacsomancer/vpnd"
 distfiles="https://gitlab.com/emacsomancer/vpnd/-/archive/${version}/${pkgname}-${version}.tar.gz"
-checksum=49e148766f1e0bdb4a48d58bd72448e72c977f4c326393d694ae0cce2b42f6f9
+checksum=a69066f28f3c65fad4718b35d9e75f7e5b82b85e0fb1f0cdbaea82eae259a69a
 
 do_install() {
 	vbin vpnd

Re: vpnd: update to 0.1.2.1

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

New comment by emacsomancer on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-631094175

Comment:
>     1. you probably want to add the conf file to `conf_files=` so users' changes won't get overwritten on update
> 
>     2. please don't bloat the install text with information the application provides on its own (i skimmed the source of your script)
> 
>     3. (btw: why not just `ping -c 1 kernel.org` for 'online check'?)

addressed in https://github.com/void-linux/void-packages/commit/3d6638d5a7e5746d99ee0a6982f0624ca93094d2

* 0.1.2.1
- in package
  - simplify connectivity check to use ping (+ fixes)

- in template:
  - add relevant conf_files field

- in install msgs:
  - condense to 2 lines

Re: vpnd: update to 0.1.2.1

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

New comment by emacsomancer on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-631094175

Comment:
>     1. you probably want to add the conf file to `conf_files=` so users' changes won't get overwritten on update
> 
>     2. please don't bloat the install text with information the application provides on its own (i skimmed the source of your script)
> 
>     3. (btw: why not just `ping -c 1 kernel.org` for 'online check'?)

addressed in https://github.com/void-linux/void-packages/commit/3d6638d5a7e5746d99ee0a6982f0624ca93094d2

* 0.1.2.1
  - in package
     - simplify connectivity check to use ping (+ fixes)

   - in template:
     - add relevant conf_files field

- in install msgs:
  - condense to 2 lines

Re: vpnd: update to 0.1.2.1

[emacsomancer]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

New comment by emacsomancer on void-packages repository

https://github.com/void-linux/void-packages/pull/22111#issuecomment-631094175

Comment:
>     1. you probably want to add the conf file to `conf_files=` so users' changes won't get overwritten on update
> 
>     2. please don't bloat the install text with information the application provides on its own (i skimmed the source of your script)
> 
>     3. (btw: why not just `ping -c 1 kernel.org` for 'online check'?)

addressed in https://github.com/void-linux/void-packages/commit/3d6638d5a7e5746d99ee0a6982f0624ca93094d2

* 0.1.2.1
  - in package
     - simplify connectivity check to use ping (+ fixes)
   - in template:
     - add relevant conf_files field
   - in install msgs:
     - condense to 2 lines

Re: [PR PATCH] [Merged]: vpnd: update to 0.1.2.1

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There's a merged pull request on the void-packages repository

vpnd: update to 0.1.2.1
https://github.com/void-linux/void-packages/pull/22111

Description:
*Breaking changes:*
- in vpnd.conf, icons are referenced _without_ the `icon:` prefix in the path
   - also new settings introduced
- `yad` removed from dependencies since notification option
  introduced (users who want systray icon should (re)install `yad`)

*Improvements:*
- optional notifications via notify-send(.sh)
- connectivity check (if ncat/nmap/curl are installed)
- ability to run w/o yad (if no systray is desired) via notify-send(.sh)
- fixes to formatting of `xbps` update output