[PR PATCH] python3-google-api-python-client: add missing dependency

[PR PATCH] python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

There is a new pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python-google-api-python-client
https://github.com/void-linux/void-packages/pull/22227

python3-google-api-python-client: add missing dependency
Some of the common API modules were split out into a core library which is missing as a dependency.

A patch file from https://github.com/void-linux/void-packages/pull/22227.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python-google-api-python-client-22227.patch --]
[-- Type: text/x-diff, Size: 3990 bytes --]

From ca11834296032053644ef2eb7fc3eb7375768e96 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 08:59:12 -0400
Subject: [PATCH 1/3] New package: python3-googleapis-common-protos-1.51.0.

Dependency for python3-google-api-core.
---
 .../python3-googleapis-common-protos/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-googleapis-common-protos/template

diff --git a/srcpkgs/python3-googleapis-common-protos/template b/srcpkgs/python3-googleapis-common-protos/template
new file mode 100644
index 00000000000..362a40fa555
--- /dev/null
+++ b/srcpkgs/python3-googleapis-common-protos/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-googleapis-common-protos'
+pkgname=python3-googleapis-common-protos
+version=1.51.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-protobuf"
+short_desc="Common protobufs used in Google APIs (Python3)"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/googleapis"
+distfiles="${PYPI_SITE}/g/googleapis-common-protos/googleapis-common-protos-${version}.tar.gz"
+checksum=013c91704279119150e44ef770086fdbba158c1f978a6402167d47d5409e226e
+
+post_install() {
+	chmod -R +r "${DESTDIR}/usr/lib/python3.8/site-packages"
+}

From 9ec5f111b3f4e3ac9d8b1b4db91b853096a571e1 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:00:43 -0400
Subject: [PATCH 2/3] New package: python3-google-api-core-1.16.0.

Dependency for python3-google-api-python-client.
---
 srcpkgs/python3-google-api-core/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/python3-google-api-core/template

diff --git a/srcpkgs/python3-google-api-core/template b/srcpkgs/python3-google-api-core/template
new file mode 100644
index 00000000000..411f3529702
--- /dev/null
+++ b/srcpkgs/python3-google-api-core/template
@@ -0,0 +1,16 @@
+# Template file for 'python3-google-api-core'
+pkgname=python3-google-api-core
+version=1.17.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-googleapis-common-protos python3-protobuf python3-google-auth
+ python3-requests python3-six python3-pytz"
+short_desc="Google API client core library for Python3"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/python-api-core"
+distfiles="${PYPI_SITE}/g/google-api-core/google-api-core-${version}.tar.gz"
+checksum=e4082a0b479dc2dee2f8d7b80ea8b5d0184885b773caab15ab1836277a01d689

From d6f5e986ba36226f175acb33b8bb908c3915151f Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:03:07 -0400
Subject: [PATCH 3/3] python3-google-api-python-client: add missing dependency

---
 srcpkgs/python3-google-api-python-client/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-google-api-python-client/template b/srcpkgs/python3-google-api-python-client/template
index c9d5e61d455..bb21ada922c 100644
--- a/srcpkgs/python3-google-api-python-client/template
+++ b/srcpkgs/python3-google-api-python-client/template
@@ -1,13 +1,13 @@
 # Template file for 'python3-google-api-python-client'
 pkgname=python3-google-api-python-client
 version=1.8.3
-revision=1
+revision=2
 archs=noarch
 wrksrc="${pkgname#*-}-${version}"
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-setuptools"
+hostmakedepends="python3-setuptools"
 depends="python3-httplib2 python3-google-auth python3-google-auth-httplib2
- python3-uritemplate python3-six"
+ python3-google-api-core python3-uritemplate python3-six"
 short_desc="Google API client library for Python3"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"

Re: [PR PATCH] [Updated] python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python-google-api-python-client
https://github.com/void-linux/void-packages/pull/22227

python3-google-api-python-client: add missing dependency
Some of the common API modules were split out into a core library which is missing as a dependency.

A patch file from https://github.com/void-linux/void-packages/pull/22227.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python-google-api-python-client-22227.patch --]
[-- Type: text/x-diff, Size: 3960 bytes --]

From 960321558c57703d7d0da0fa8ed27718029b5cfb Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 08:59:12 -0400
Subject: [PATCH 1/3] New package: python3-googleapis-common-protos-1.51.0.

Dependency for python3-google-api-core.
---
 .../python3-googleapis-common-protos/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-googleapis-common-protos/template

diff --git a/srcpkgs/python3-googleapis-common-protos/template b/srcpkgs/python3-googleapis-common-protos/template
new file mode 100644
index 00000000000..5fd565e3da9
--- /dev/null
+++ b/srcpkgs/python3-googleapis-common-protos/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-googleapis-common-protos'
+pkgname=python3-googleapis-common-protos
+version=1.51.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-protobuf"
+short_desc="Common protobufs used in Google APIs (Python3)"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/googleapis"
+distfiles="${PYPI_SITE}/g/googleapis-common-protos/googleapis-common-protos-${version}.tar.gz"
+checksum=013c91704279119150e44ef770086fdbba158c1f978a6402167d47d5409e226e
+
+post_install() {
+	chmod -R +r ${py3_sitelib}
+}

From 19c2436813a990e88ce260ddd412322c1658f21a Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:00:43 -0400
Subject: [PATCH 2/3] New package: python3-google-api-core-1.16.0.

Dependency for python3-google-api-python-client.
---
 srcpkgs/python3-google-api-core/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/python3-google-api-core/template

diff --git a/srcpkgs/python3-google-api-core/template b/srcpkgs/python3-google-api-core/template
new file mode 100644
index 00000000000..411f3529702
--- /dev/null
+++ b/srcpkgs/python3-google-api-core/template
@@ -0,0 +1,16 @@
+# Template file for 'python3-google-api-core'
+pkgname=python3-google-api-core
+version=1.17.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-googleapis-common-protos python3-protobuf python3-google-auth
+ python3-requests python3-six python3-pytz"
+short_desc="Google API client core library for Python3"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/python-api-core"
+distfiles="${PYPI_SITE}/g/google-api-core/google-api-core-${version}.tar.gz"
+checksum=e4082a0b479dc2dee2f8d7b80ea8b5d0184885b773caab15ab1836277a01d689

From 025bb1f2382262c482d2c924df8ceb06e1df55d3 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:03:07 -0400
Subject: [PATCH 3/3] python3-google-api-python-client: add missing dependency

---
 srcpkgs/python3-google-api-python-client/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-google-api-python-client/template b/srcpkgs/python3-google-api-python-client/template
index c9d5e61d455..bb21ada922c 100644
--- a/srcpkgs/python3-google-api-python-client/template
+++ b/srcpkgs/python3-google-api-python-client/template
@@ -1,13 +1,13 @@
 # Template file for 'python3-google-api-python-client'
 pkgname=python3-google-api-python-client
 version=1.8.3
-revision=1
+revision=2
 archs=noarch
 wrksrc="${pkgname#*-}-${version}"
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-setuptools"
+hostmakedepends="python3-setuptools"
 depends="python3-httplib2 python3-google-auth python3-google-auth-httplib2
- python3-uritemplate python3-six"
+ python3-google-api-core python3-uritemplate python3-six"
 short_desc="Google API client library for Python3"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"

Re: python3-google-api-python-client: add missing dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633236630

Comment:
There're some failing tests.
It reads:
> This test must be run from within the protobuf source package so that it can read test data files from the C++ source tree.

Is it OK?

Re: python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633266429

Comment:
I'm not sure what you mean by is it OK?

The packages build locally and I've used them in a small example program that uses the google-api-python-client library.

Looking at the output of Travis, it appears that some of the tests are failing on building dependencies such as expat, which is not something I have control over.

Re: [PR PATCH] [Updated] python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

There is an updated pull request by pbui against master on the void-packages repository

https://github.com/pbui/void-packages python-google-api-python-client
https://github.com/void-linux/void-packages/pull/22227

python3-google-api-python-client: add missing dependency
Some of the common API modules were split out into a core library which is missing as a dependency.

A patch file from https://github.com/void-linux/void-packages/pull/22227.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python-google-api-python-client-22227.patch --]
[-- Type: text/x-diff, Size: 3960 bytes --]

From 699ad612f26f4a6596163a1489779bb164f998e8 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 08:59:12 -0400
Subject: [PATCH 1/3] New package: python3-googleapis-common-protos-1.51.0.

Dependency for python3-google-api-core.
---
 .../python3-googleapis-common-protos/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/python3-googleapis-common-protos/template

diff --git a/srcpkgs/python3-googleapis-common-protos/template b/srcpkgs/python3-googleapis-common-protos/template
new file mode 100644
index 00000000000..5fd565e3da9
--- /dev/null
+++ b/srcpkgs/python3-googleapis-common-protos/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-googleapis-common-protos'
+pkgname=python3-googleapis-common-protos
+version=1.51.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-protobuf"
+short_desc="Common protobufs used in Google APIs (Python3)"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/googleapis"
+distfiles="${PYPI_SITE}/g/googleapis-common-protos/googleapis-common-protos-${version}.tar.gz"
+checksum=013c91704279119150e44ef770086fdbba158c1f978a6402167d47d5409e226e
+
+post_install() {
+	chmod -R +r ${py3_sitelib}
+}

From cdc96a0dc5114465cc741796fa6d829c6f34b86a Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:00:43 -0400
Subject: [PATCH 2/3] New package: python3-google-api-core-1.16.0.

Dependency for python3-google-api-python-client.
---
 srcpkgs/python3-google-api-core/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/python3-google-api-core/template

diff --git a/srcpkgs/python3-google-api-core/template b/srcpkgs/python3-google-api-core/template
new file mode 100644
index 00000000000..411f3529702
--- /dev/null
+++ b/srcpkgs/python3-google-api-core/template
@@ -0,0 +1,16 @@
+# Template file for 'python3-google-api-core'
+pkgname=python3-google-api-core
+version=1.17.0
+revision=1
+archs=noarch
+wrksrc="${pkgname#*-}-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-googleapis-common-protos python3-protobuf python3-google-auth
+ python3-requests python3-six python3-pytz"
+short_desc="Google API client core library for Python3"
+maintainer="Peter Bui <pbui@github.bx612.space>"
+license="Apache-2.0"
+homepage="https://github.com/googleapis/python-api-core"
+distfiles="${PYPI_SITE}/g/google-api-core/google-api-core-${version}.tar.gz"
+checksum=e4082a0b479dc2dee2f8d7b80ea8b5d0184885b773caab15ab1836277a01d689

From e034e5a40c93ed62f168438e93cec89cf86a1e11 Mon Sep 17 00:00:00 2001
From: Peter Bui <pbui@github.bx612.space>
Date: Sat, 23 May 2020 09:03:07 -0400
Subject: [PATCH 3/3] python3-google-api-python-client: add missing dependency

---
 srcpkgs/python3-google-api-python-client/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-google-api-python-client/template b/srcpkgs/python3-google-api-python-client/template
index c9d5e61d455..bb21ada922c 100644
--- a/srcpkgs/python3-google-api-python-client/template
+++ b/srcpkgs/python3-google-api-python-client/template
@@ -1,13 +1,13 @@
 # Template file for 'python3-google-api-python-client'
 pkgname=python3-google-api-python-client
 version=1.8.3
-revision=1
+revision=2
 archs=noarch
 wrksrc="${pkgname#*-}-${version}"
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-setuptools"
+hostmakedepends="python3-setuptools"
 depends="python3-httplib2 python3-google-auth python3-google-auth-httplib2
- python3-uritemplate python3-six"
+ python3-google-api-core python3-uritemplate python3-six"
 short_desc="Google API client library for Python3"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"

Re: python3-google-api-python-client: add missing dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633316762

Comment:
On 2020-05-24 10:49:12-0700, Peter Bui <notifications@github.com> wrote:
> I'm not sure what you mean by is it OK?

I meant the output of

	./xbps-src check <this-package-name>

Thanks,

-- 
Danh

Re: python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

New comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633322076

Comment:
I think we can ignore that error since the test requires looking at C++ source files that are not included part of the package:

https://github.com/protocolbuffers/protobuf/blob/master/python/google/protobuf/internal/test_util.py#L617

As noted on the PyPi page for this module, the Python parts are extracted from the larger protobuf repository and thus parts of the tests depend on the overall original repository, but the Python module should work without these files.

Re: python3-google-api-python-client: add missing dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633760494

Comment:
I'll push with this if you're (explicitly) OK with it:

```diff
diff --git a/srcpkgs/python3-google-api-core/template b/srcpkgs/python3-google-api-core/template
index 411f352970..e2f78f172c 100644
--- a/srcpkgs/python3-google-api-core/template
+++ b/srcpkgs/python3-google-api-core/template
@@ -8,9 +8,14 @@ build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-googleapis-common-protos python3-protobuf python3-google-auth
  python3-requests python3-six python3-pytz"
+checkdepends="$depends python3-mock python3-pytest"
 short_desc="Google API client core library for Python3"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"
 homepage="https://github.com/googleapis/python-api-core"
 distfiles="${PYPI_SITE}/g/google-api-core/google-api-core-${version}.tar.gz"
 checksum=e4082a0b479dc2dee2f8d7b80ea8b5d0184885b773caab15ab1836277a01d689
+
+do_check() {
+	: all tests require grpc, which is optional dependencies.
+}
diff --git a/srcpkgs/python3-google-api-python-client/template b/srcpkgs/python3-google-api-python-client/template
index bb21ada922..3f098cbc89 100644
--- a/srcpkgs/python3-google-api-python-client/template
+++ b/srcpkgs/python3-google-api-python-client/template
@@ -8,9 +8,20 @@ build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-httplib2 python3-google-auth python3-google-auth-httplib2
  python3-google-api-core python3-uritemplate python3-six"
+checkdepends="python3-mock $depends python3-oauth2client"
 short_desc="Google API client library for Python3"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"
 homepage="https://github.com/googleapis/google-api-python-client"
 distfiles="${PYPI_SITE}/g/google-api-python-client/google-api-python-client-${version}.tar.gz"
 checksum=be4e8dcf399d7d1dcaae004b7f18694907f740bf6e6cebda91da8ebd968c5481
+
+post_patch() {
+	# unittest2 is python2 thing.
+	vsed -i -e '/^import unittest2 as unittest/s/.*/import unittest/' \
+		tests/test_*.py
+}
+
+do_check() {
+	: 6 unittest is failing, cannot use py test to override
+}
diff --git a/srcpkgs/python3-googleapis-common-protos/template b/srcpkgs/python3-googleapis-common-protos/template
index 5fd565e3da..0dc5210e83 100644
--- a/srcpkgs/python3-googleapis-common-protos/template
+++ b/srcpkgs/python3-googleapis-common-protos/template
@@ -7,6 +7,7 @@ wrksrc="${pkgname#*-}-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-protobuf"
+checkdepends="python3-protobuf python3-six"
 short_desc="Common protobufs used in Google APIs (Python3)"
 maintainer="Peter Bui <pbui@github.bx612.space>"
 license="Apache-2.0"
```

Re: python3-google-api-python-client: add missing dependency

[pbui]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by pbui on void-packages repository

https://github.com/void-linux/void-packages/pull/22227#issuecomment-633774740

Comment:
LGTM.  Thanks for reviewing and adding the checkdepends.

Re: [PR PATCH] [Closed]: python3-google-api-python-client: add missing dependency

[sgn]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

There's a closed pull request on the void-packages repository

python3-google-api-python-client: add missing dependency
https://github.com/void-linux/void-packages/pull/22227

Description:
Some of the common API modules were split out into a core library which is missing as a dependency.