[PR PATCH] Add cross-arm-none-eabi-newlib as qmk dependency.

[PR PATCH] Add cross-arm-none-eabi-newlib as qmk dependency.

[Liebach]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

There is a new pull request by Liebach against master on the void-packages repository

https://github.com/Liebach/void-packages qmk-depend
https://github.com/void-linux/void-packages/pull/22363

Add cross-arm-none-eabi-newlib as qmk dependency.
Fixes building at least planck/rev6 firmware, possibly other keyboards
with ARM based controllers.

Found out with help from Discord users Erovia and fauxpark on the qmk server.

A patch file from https://github.com/void-linux/void-packages/pull/22363.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-qmk-depend-22363.patch --]
[-- Type: text/x-diff, Size: 851 bytes --]

From 6c95372f75c93dd59e32fcdee5106fa2cc53424e Mon Sep 17 00:00:00 2001
From: Morten Gade Liebach <m@lieba.ch>
Date: Wed, 27 May 2020 21:02:31 +0200
Subject: [PATCH] Add cross-arm-none-eabi-newlib as qmk dependency.

Fixes building at least planck/rev6 firmware, possibly other keyboards
with ARM based controllers.
---
 srcpkgs/qmk/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qmk/template b/srcpkgs/qmk/template
index 389df443e61..cfd67251d8c 100644
--- a/srcpkgs/qmk/template
+++ b/srcpkgs/qmk/template
@@ -16,7 +16,8 @@ depends="python3-appdirs
  avrdude
  dfu-util
  avr-gcc
- cross-arm-none-eabi-gcc"
+ cross-arm-none-eabi-gcc
+ cross-arm-none-eabi-newlib"
 short_desc="CLI tool for working with QMK firmware of mechanical keyboards"
 maintainer="RinsedSloth <afernandezh@protonmail.com>"
 license="MIT"

Re: Add cross-arm-none-eabi-newlib as qmk dependency.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22363#issuecomment-634894590

Comment:
Can't you add `cross-arm-none-eabi` as a dependency instead? It's a meta package, and includes gcc and newlib.

Re: Add cross-arm-none-eabi-newlib as qmk dependency.

[Liebach]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by Liebach on void-packages repository

https://github.com/void-linux/void-packages/pull/22363#issuecomment-634899929

Comment:
@ericonr Yes, definitely.

Shouldn't revision=1 be incremented too?

Re: Add cross-arm-none-eabi-newlib as qmk dependency.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/22363#issuecomment-634911067

Comment:
Yup! Otherwise the package won't be rebuilt.

Re: [PR PATCH] [Closed]: qmk: add cross-arm-none-eabi to dependencies

[Liebach]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There's a closed pull request on the void-packages repository

qmk: add cross-arm-none-eabi to dependencies
https://github.com/void-linux/void-packages/pull/22363

Description:
Fixes building at least planck/rev6 firmware, possibly other keyboards
with ARM based controllers.

Found out with help from Discord users Erovia and fauxpark on the qmk server.