* [PR PATCH] llhttp: update to 2.0.5
@ 2020-05-08 13:03 rmccask
2020-05-11 18:28 ` [PR PATCH] [Merged]: " Hoshpak
` (16 more replies)
0 siblings, 17 replies; 18+ messages in thread
From: rmccask @ 2020-05-08 13:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
There is a new pull request by rmccask against master on the void-packages repository
https://github.com/rmccask/void-packages llhttp-2.0.5
https://github.com/void-linux/void-packages/pull/21744
llhttp: update to 2.0.5
This is needed to update nodejs.
A patch file from https://github.com/void-linux/void-packages/pull/21744.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-llhttp-2.0.5-21744.patch --]
[-- Type: text/x-diff, Size: 1075 bytes --]
From 7cd21b4699e674c3776af173be54fdc1b9d360a0 Mon Sep 17 00:00:00 2001
From: Randy McCaskill <randy@mccaskill.us>
Date: Fri, 8 May 2020 09:02:09 -0400
Subject: [PATCH] llhttp: update to 2.0.5
---
srcpkgs/llhttp/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/llhttp/template b/srcpkgs/llhttp/template
index 3cf0b41e92d..7873503e2e0 100644
--- a/srcpkgs/llhttp/template
+++ b/srcpkgs/llhttp/template
@@ -1,6 +1,6 @@
# Template file for 'llhttp'
pkgname=llhttp
-version=1.1.4
+version=2.0.5
revision=1
wrksrc="llhttp-release-v${version}"
build_style=gnu-makefile
@@ -11,7 +11,7 @@ homepage="https://llhttp.org/"
# _always_ use releases. Those have the C code generated, otherwise
# we'd have a dep loop nodejs<->llhttp
distfiles="https://github.com/nodejs/llhttp/archive/release/v${version}.tar.gz"
-checksum=eeb07e60a8f4113b110dd758756da3db69e4e2575b0407afb0a7755aef504dbb
+checksum=48f882f0b6cecc48aec8f81072ee4d80fe9a4b5e1bce009e3cf8aecbe5892c1a
post_extract() {
# No need to pull in gyp for such a simple Makefile...
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PR PATCH] [Merged]: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
@ 2020-05-11 18:28 ` Hoshpak
2020-05-12 10:20 ` mustaqimM
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: Hoshpak @ 2020-05-11 18:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
There's a merged pull request on the void-packages repository
llhttp: update to 2.0.5
https://github.com/void-linux/void-packages/pull/21744
Description:
This is needed to update nodejs and nodejs-lts.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
2020-05-11 18:28 ` [PR PATCH] [Merged]: " Hoshpak
@ 2020-05-12 10:20 ` mustaqimM
2020-05-12 11:48 ` rmccask
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: mustaqimM @ 2020-05-12 10:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627251549
Comment:
@rmccask Are you working on the node packages?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
2020-05-11 18:28 ` [PR PATCH] [Merged]: " Hoshpak
2020-05-12 10:20 ` mustaqimM
@ 2020-05-12 11:48 ` rmccask
2020-05-12 12:39 ` mustaqimM
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-12 11:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627293761
Comment:
I have nodejs and nodejs-lts built but will build them again before I submit to reverify. I can send you the changes if you need them sooner. My build vm is a little slow.
-Randy
On May 12, 2020 6:20:21 AM EDT, Mustaqim Malim <notifications@github.com> wrote:
>@rmccask Are you working on the node packages?
>
>--
>You are receiving this because you were mentioned.
>Reply to this email directly or view it on GitHub:
>https://github.com/void-linux/void-packages/pull/21744#issuecomment-627251549
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (2 preceding siblings ...)
2020-05-12 11:48 ` rmccask
@ 2020-05-12 12:39 ` mustaqimM
2020-05-12 12:48 ` rmccask
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: mustaqimM @ 2020-05-12 12:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 219 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627316669
Comment:
I do need it but I'll wait since I see you're also busy with the icu package
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (3 preceding siblings ...)
2020-05-12 12:39 ` mustaqimM
@ 2020-05-12 12:48 ` rmccask
2020-05-12 12:49 ` rmccask
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-12 12:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627293761
Comment:
I have nodejs and nodejs-lts built but will build them again before I submit to reverify. I can send you the changes if you need them sooner. My build vm is a little slow.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (4 preceding siblings ...)
2020-05-12 12:48 ` rmccask
@ 2020-05-12 12:49 ` rmccask
2020-05-12 17:15 ` oliver-cfc
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-12 12:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 361 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627321764
Comment:
My test build of nodejs 14.2.0 without icu 67.1 just errored out with:
ERROR: icu4c v64.2 is too old, v65.x or later is required.
It built with the update icu already. Looks like I need to submit those together.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (5 preceding siblings ...)
2020-05-12 12:49 ` rmccask
@ 2020-05-12 17:15 ` oliver-cfc
2020-05-12 17:17 ` oliver-cfc
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: oliver-cfc @ 2020-05-12 17:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
New comment by oliver-cfc on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627477613
Comment:
I'm pretty new to node so may be missing something but 'npm install ' fails with llhttp-2.0.5_1
`$ npm i express
npm ERR! cb() never called!
npm ERR! This is an error with npm itself. Please report this error at:
npm ERR! <https://npm.community>
npm ERR! A complete log of this run can be found in:
npm ERR! /home/oliver/.npm/_logs/2020-05-12T17_11_37_457Z-debug.log`
Downgrading to llhttp-1.1.4_1 allows it to work again
`$ npm i express
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN nodeapi@1.0.0 No repository field.
+ express@4.17.1
added 50 packages from 37 contributors and audited 126 packages in 14.868s
found 0 vulnerabilities`
Does this mean I need to wait for a node upgrade (current on nodejs-13.2.0_1) before upgrading llhttp again?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (6 preceding siblings ...)
2020-05-12 17:15 ` oliver-cfc
@ 2020-05-12 17:17 ` oliver-cfc
2020-05-12 17:39 ` rmccask
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: oliver-cfc @ 2020-05-12 17:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 985 bytes --]
New comment by oliver-cfc on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627477613
Comment:
I'm pretty new to node so may be missing something but 'npm install ' fails with llhttp-2.0.5_1
```
$ npm i express
npm ERR! cb() never called!
npm ERR! This is an error with npm itself. Please report this error at:
npm ERR! <https://npm.community>
npm ERR! A complete log of this run can be found in:
npm ERR! /home/oliver/.npm/_logs/2020-05-12T17_11_37_457Z-debug.log
```
Downgrading to llhttp-1.1.4_1 allows it to work again
```
$ npm i express
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN nodeapi@1.0.0 No repository field.
+ express@4.17.1
added 50 packages from 37 contributors and audited 126 packages in 14.868s
found 0 vulnerabilities
```
Does this mean I need to wait for a node upgrade (current on nodejs-13.2.0_1) before upgrading llhttp again?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (7 preceding siblings ...)
2020-05-12 17:17 ` oliver-cfc
@ 2020-05-12 17:39 ` rmccask
2020-05-12 18:06 ` oliver-cfc
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-12 17:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627490352
Comment:
I see a lot of errors mentioning "npm ERR! cb() never called". You could wait for a new node package since it is being worked on but I don't think it should be necessary. A couple of suggestions I saw:
```
If you have npm version 5 or above, try this first:
$ sudo npm cache verify
Otherwise:
$ sudo npm cache clean
```
Another suggestion said that uninstalling the node package, rebooting and then reinstalling fixed it. I suspect that just cleared it out of memory but you could try it. Please let me know if either of these works.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (8 preceding siblings ...)
2020-05-12 17:39 ` rmccask
@ 2020-05-12 18:06 ` oliver-cfc
2020-05-12 19:12 ` rmccask
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: oliver-cfc @ 2020-05-12 18:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
New comment by oliver-cfc on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627504003
Comment:
The 'cache verify' came back OK... the 'cache clean' needed to be forced and had no effect. Uninstalling, rebooting, reinstalling had no effect.
I spun up a fresh void instance in virtualbox and can re-create the problem
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (9 preceding siblings ...)
2020-05-12 18:06 ` oliver-cfc
@ 2020-05-12 19:12 ` rmccask
2020-05-13 1:01 ` rmccask
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-12 19:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627537993
Comment:
I have reproduced it locally. I am working on it.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (10 preceding siblings ...)
2020-05-12 19:12 ` rmccask
@ 2020-05-13 1:01 ` rmccask
2020-05-13 7:15 ` mustaqimM
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-13 1:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627681099
Comment:
I have a new version of nodejs-lts and I put in a revbump for nodejs. I did builds of them both and they worked after the rebuild.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (11 preceding siblings ...)
2020-05-13 1:01 ` rmccask
@ 2020-05-13 7:15 ` mustaqimM
2020-05-13 12:29 ` rmccask
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: mustaqimM @ 2020-05-13 7:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627795906
Comment:
Ya, I read on one of the two git repos llhttp needs to be updated along with nodejs. Perhaps you could add a comment that notes both should get updated in the same PR
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (12 preceding siblings ...)
2020-05-13 7:15 ` mustaqimM
@ 2020-05-13 12:29 ` rmccask
2020-05-13 12:38 ` mustaqimM
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rmccask @ 2020-05-13 12:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
New comment by rmccask on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627949509
Comment:
@mustaqimM: Is it only because llhttp went from 1.X to 2.X or will it happen every time? I am thinking a comment in the llhttp template saying that nodejs and nodejs-lts need to be tested and possibly be included in the same PR might be enough. I think nghttp2 also uses llhttp so it might need revbump too?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (13 preceding siblings ...)
2020-05-13 12:29 ` rmccask
@ 2020-05-13 12:38 ` mustaqimM
2020-05-14 15:55 ` oliver-cfc
2020-05-28 14:37 ` nathanblair
16 siblings, 0 replies; 18+ messages in thread
From: mustaqimM @ 2020-05-13 12:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-627954492
Comment:
They work in-sync and should be updated together. I'm trying to find where I read that. (The same goes for the containerd and docker packages). Most likely every package that has a reverse dependency on it
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (14 preceding siblings ...)
2020-05-13 12:38 ` mustaqimM
@ 2020-05-14 15:55 ` oliver-cfc
2020-05-28 14:37 ` nathanblair
16 siblings, 0 replies; 18+ messages in thread
From: oliver-cfc @ 2020-05-14 15:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by oliver-cfc on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-628726948
Comment:
Confirmed all is good after the revbump for nodejs. Thanks for the fix.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: llhttp: update to 2.0.5
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
` (15 preceding siblings ...)
2020-05-14 15:55 ` oliver-cfc
@ 2020-05-28 14:37 ` nathanblair
16 siblings, 0 replies; 18+ messages in thread
From: nathanblair @ 2020-05-28 14:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
New comment by nathanblair on void-packages repository
https://github.com/void-linux/void-packages/pull/21744#issuecomment-635389799
Comment:
>
>
> My test build of nodejs 14.2.0 without icu 67.1 just errored out with:
> ERROR: icu4c v64.2 is too old, v65.x or later is required.
>
> It built with the update icu already. Looks like I need to submit those together.
This is precisely why I had made the static version of node in this PR: https://github.com/void-linux/void-packages/pull/21341
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2020-05-28 14:38 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 13:03 [PR PATCH] llhttp: update to 2.0.5 rmccask
2020-05-11 18:28 ` [PR PATCH] [Merged]: " Hoshpak
2020-05-12 10:20 ` mustaqimM
2020-05-12 11:48 ` rmccask
2020-05-12 12:39 ` mustaqimM
2020-05-12 12:48 ` rmccask
2020-05-12 12:49 ` rmccask
2020-05-12 17:15 ` oliver-cfc
2020-05-12 17:17 ` oliver-cfc
2020-05-12 17:39 ` rmccask
2020-05-12 18:06 ` oliver-cfc
2020-05-12 19:12 ` rmccask
2020-05-13 1:01 ` rmccask
2020-05-13 7:15 ` mustaqimM
2020-05-13 12:29 ` rmccask
2020-05-13 12:38 ` mustaqimM
2020-05-14 15:55 ` oliver-cfc
2020-05-28 14:37 ` nathanblair
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).