Re: awesome: add build option jit

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605698587

Comment:
You could make `lua51-lgi` a subpackage, and add a Lua 5.2 version while at it. That's what other modules are doing, and this one only differs in `make_install_args`, so it's easy to do.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605699613

Comment:
Just to be clear, make the lua51-lgi a sub package of `lua-lgi`, right? Should I keep the name `lua-lgi` or revert it back to `lgi`? 

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605712234

Comment:
yes, `lua-lgi`; also make a subpackage called `lgi`, make it meta, and depend it on `lua-lgi`, for transitional reasons.

Re: [WIP] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-605870703

Comment:
@q66 Should I name the commits like this:

```
lgi: convert to transitional package (for lua-lgi)
New package: lua-lgi-0.9.2
New package: lua51-lgi-0.9.2
New package: lua52-lgi-0.9.2
awesome: add build option jit
```

Also, the `lua*-lgi` package will have revision number of 1, right?

Re: [WIP] awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606033519

Comment:
hm? no, you should make a single commit, since it's a single template, like `lgi: rename to lua-lgi + add 5.1 and 5.2 support`

the version should stay the same, except with revision incremented by one, otherwise the transitional package won't trigger

Re: [WIP] awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606033519

Comment:
hm? no, you should make a single commit (and a second one for the `awesome` change), since it's a single template, like `lgi: rename to lua-lgi + add 5.1 and 5.2 support`

the version should stay the same, except with revision incremented by one, otherwise the transitional package won't trigger

Re: [WIP] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606058896

Comment:
The CI failed because of network? I didn't know that can happen.

Re: [WIP] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606058896

Comment:
The CI failed because of network? I didn't know that can happen.

Re: [WIP] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606058896

Comment:
The CI failed because of network? I didn't know that can happen.

Re: [WIP] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-606058896

Comment:
The CI failed because of network? I didn't know that can happen.

Re: [PR PATCH] [Updated] [WIP] awesome: add build option jit

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

There is an updated pull request by pullmoll against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

[WIP] awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 7135 bytes --]

From 4167c891196c4249cf7277f5a058349d3e321104 Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 03:25:45 +0700
Subject: [PATCH 1/2] lgi: rename to lua-lgi, add support for lua 5.1 an lua
 5.2

---
 srcpkgs/lgi              |  1 +
 srcpkgs/lgi/template     | 21 -----------
 srcpkgs/lua-lgi/template | 81 ++++++++++++++++++++++++++++++++++++++++
 srcpkgs/lua51-lgi        |  1 +
 srcpkgs/lua52-lgi        |  1 +
 5 files changed, 84 insertions(+), 21 deletions(-)
 create mode 120000 srcpkgs/lgi
 delete mode 100644 srcpkgs/lgi/template
 create mode 100644 srcpkgs/lua-lgi/template
 create mode 120000 srcpkgs/lua51-lgi
 create mode 120000 srcpkgs/lua52-lgi

diff --git a/srcpkgs/lgi b/srcpkgs/lgi
new file mode 120000
index 00000000000..db68c0a96c3
--- /dev/null
+++ b/srcpkgs/lgi
@@ -0,0 +1 @@
+lua-lgi
\ No newline at end of file
diff --git a/srcpkgs/lgi/template b/srcpkgs/lgi/template
deleted file mode 100644
index 5941e26ea66..00000000000
--- a/srcpkgs/lgi/template
+++ /dev/null
@@ -1,21 +0,0 @@
-# Template file for 'lgi'
-pkgname=lgi
-version=0.9.2
-revision=3
-build_style=gnu-makefile
-make_install_args="LUA_VERSION=5.3"
-hostmakedepends="pkg-config"
-makedepends="libglib-devel libffi-devel lua-devel
- gobject-introspection gir-freedesktop"
-depends="lua gir-freedesktop"
-short_desc="Lua binadings for gnome/gobject using gobject-introspection library"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="MIT"
-homepage="https://github.com/pavouk/lgi"
-distfiles="https://github.com/pavouk/lgi/archive/$version.tar.gz"
-checksum=cfc4105482b4730b3a40097c9d9e7e35c46df2fb255370bdeb2f45a886548c4f
-
-post_install() {
-	vbin tools/dump-typelib.lua dump-typelib
-	vlicense LICENSE
-}
diff --git a/srcpkgs/lua-lgi/template b/srcpkgs/lua-lgi/template
new file mode 100644
index 00000000000..f32f3285636
--- /dev/null
+++ b/srcpkgs/lua-lgi/template
@@ -0,0 +1,81 @@
+# Template file for 'lua-lgi'
+pkgname=lua-lgi
+version=0.9.2
+revision=4
+wrksrc="lgi-${version}"
+hostmakedepends="pkg-config"
+makedepends="lua-devel lua51-devel lua52-devel libglib-devel libffi-devel gobject-introspection gir-freedesktop"
+_depends="gir-freedesktop"
+depends="${_depends} lua"
+short_desc="Lua bindings for gnome/gobject using gobject-introspection library"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="MIT"
+homepage="https://github.com/pavouk/lgi"
+distfiles="https://github.com/pavouk/lgi/archive/$version.tar.gz"
+checksum=cfc4105482b4730b3a40097c9d9e7e35c46df2fb255370bdeb2f45a886548c4f
+
+_alternatives="
+ lgi:dump-typelib:/usr/bin/dump-typelib__luaver__
+"
+alternatives=${_alternatives/__luaver__/5.3}
+
+post_extract() {
+	mkdir -p lua5.1
+	mv * lua5.1 || true
+	cp -a lua5.1 lua5.2
+	cp -a lua5.1 lua5.3
+}
+
+do_build() {
+	for luaver in 5.1 5.2 5.3; do
+		cd ${wrksrc}/lua${luaver}
+		make LUA_VERSION="${luaver}" CC="$CC" AR="$AR" RANLIB="$RANLIB" CFLAGS="${_common_cflags} -I${XBPS_CROSS_BASE}/usr/include/lua${luaver}" ${makejobs}
+	done
+}
+
+do_install() {
+	vmkdir usr/bin
+	for luaver in 5.1 5.2 5.3; do
+		vmkdir usr/share/lua/${luaver}/
+		vmkdir usr/lib/lua/${luaver}/lgi/
+		cd ${wrksrc}/lua${luaver}
+
+		# fix lua version in shebang
+		vsed -e "s|env lua|env lua${luaver}|" -i tools/dump-typelib.lua
+
+		# don't know why it saids corelgilua51 instead of 5x
+		# the old lgi package has this too
+		mv "lgi/corelgilua51.so" "$DESTDIR/usr/lib/lua/${luaver}/lgi/"
+		vcopy tools/dump-typelib.lua usr/bin/dump-typelib$luaver
+		vcopy lgi usr/share/lua/${luaver}/lgi
+
+		vlicense ${wrksrc}/lua${luaver}/LICENSE
+	done
+}
+
+lgi_package() {
+	build_style="meta"
+	depends="lua-lgi"
+	short_desc+=" (transitional dummy package)"
+}
+
+_subpackage() {
+	luaver=$1
+	depends="${_depends} lua${luaver/\./}"
+	short_desc+=" (Lua $luaver)"
+	alternatives="${_alternatives/__luaver__/$luaver}"
+	pkg_install() {
+		vmove "usr/lib/lua/${luaver}/lgi/corelgilua51.so"
+		vmove "usr/bin/dump-typelib$luaver"
+		vmove "usr/share/lua/$luaver/lgi"
+		vlicense "${wrksrc}/lua$luaver/LICENSE"
+	}
+}
+
+lua51-lgi_package() {
+	_subpackage 5.1
+}
+
+lua52-lgi_package() {
+	_subpackage 5.2
+}
diff --git a/srcpkgs/lua51-lgi b/srcpkgs/lua51-lgi
new file mode 120000
index 00000000000..d00035eb25d
--- /dev/null
+++ b/srcpkgs/lua51-lgi
@@ -0,0 +1 @@
+lua-lgi/
\ No newline at end of file
diff --git a/srcpkgs/lua52-lgi b/srcpkgs/lua52-lgi
new file mode 120000
index 00000000000..db68c0a96c3
--- /dev/null
+++ b/srcpkgs/lua52-lgi
@@ -0,0 +1 @@
+lua-lgi
\ No newline at end of file

From b38428e8b6fb216fd1647d12ed47d62516bc342f Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 03:27:50 +0700
Subject: [PATCH 2/2] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index 3f559ea1f87..e46e8f3b462 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -1,17 +1,17 @@
 # Template file for 'awesome'
 pkgname=awesome
 version=4.3
-revision=4
+revision=5
 build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
 conf_files="/etc/xdg/awesome/rc.lua"
-hostmakedepends="ruby-asciidoctor ImageMagick lgi lua pkg-config xmlto"
+hostmakedepends="ruby-asciidoctor ImageMagick pkg-config xmlto"
 makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
- startup-notification-devel imlib2-devel lgi libxdg-basedir-devel
- gdk-pixbuf-devel lua-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lgi>=0.7.2 pango"
+ startup-notification-devel imlib2-devel libxdg-basedir-devel
+ gdk-pixbuf-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
+depends="dbus-x11 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,32 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT instead of lua"
+
+hostmakedepends+=" $(vopt_if jit 'lua51 LuaJIT lua51-lgi' 'lua lua-lgi')"
+makedepends+=" $(vopt_if jit \
+	'lua51-devel LuaJIT-devel lua51-lgi' \
+	'lua-devel lua-lgi')"
+depends+=" $(vopt_if jit lua51 lua)-lgi>=0.7.2"
+_luaname="$(vopt_if jit luajit lua)"
+
+if [ "$_luaname" = "luajit" ]; then
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	# Use correct lua name
+	vsed -e "s|COMMAND lua\b|COMMAND ${_luaname}|" \
+		-i awesomeConfig.cmake \
+		-i tests/examples/CMakeLists.txt
+	vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER ${_luaname}|" \
+		-i tests/examples/CMakeLists.txt
 }
 
 post_install() {

Re: [PR PATCH] [Updated] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

There is an updated pull request by ndgnuh against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 6955 bytes --]

From 35083c01013ac96c76f576b0674f3141eee4d23a Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:56:40 +0700
Subject: [PATCH 1/2] lgi: rename to lua-lgi, add support for lua5.1 and lua5.2

---
 srcpkgs/lgi              |  1 +
 srcpkgs/lgi/template     | 21 -----------
 srcpkgs/lua-lgi/template | 79 ++++++++++++++++++++++++++++++++++++++++
 srcpkgs/lua51-lgi        |  1 +
 srcpkgs/lua52-lgi        |  1 +
 5 files changed, 82 insertions(+), 21 deletions(-)
 create mode 120000 srcpkgs/lgi
 delete mode 100644 srcpkgs/lgi/template
 create mode 100644 srcpkgs/lua-lgi/template
 create mode 120000 srcpkgs/lua51-lgi
 create mode 120000 srcpkgs/lua52-lgi

diff --git a/srcpkgs/lgi b/srcpkgs/lgi
new file mode 120000
index 00000000000..db68c0a96c3
--- /dev/null
+++ b/srcpkgs/lgi
@@ -0,0 +1 @@
+lua-lgi
\ No newline at end of file
diff --git a/srcpkgs/lgi/template b/srcpkgs/lgi/template
deleted file mode 100644
index 5941e26ea66..00000000000
--- a/srcpkgs/lgi/template
+++ /dev/null
@@ -1,21 +0,0 @@
-# Template file for 'lgi'
-pkgname=lgi
-version=0.9.2
-revision=3
-build_style=gnu-makefile
-make_install_args="LUA_VERSION=5.3"
-hostmakedepends="pkg-config"
-makedepends="libglib-devel libffi-devel lua-devel
- gobject-introspection gir-freedesktop"
-depends="lua gir-freedesktop"
-short_desc="Lua binadings for gnome/gobject using gobject-introspection library"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="MIT"
-homepage="https://github.com/pavouk/lgi"
-distfiles="https://github.com/pavouk/lgi/archive/$version.tar.gz"
-checksum=cfc4105482b4730b3a40097c9d9e7e35c46df2fb255370bdeb2f45a886548c4f
-
-post_install() {
-	vbin tools/dump-typelib.lua dump-typelib
-	vlicense LICENSE
-}
diff --git a/srcpkgs/lua-lgi/template b/srcpkgs/lua-lgi/template
new file mode 100644
index 00000000000..07ee36c6916
--- /dev/null
+++ b/srcpkgs/lua-lgi/template
@@ -0,0 +1,79 @@
+# Template file for 'lua-lgi'
+pkgname=lua-lgi
+version=0.9.2
+revision=4
+wrksrc="lgi-${version}"
+hostmakedepends="pkg-config"
+makedepends="LuaJIT-devel lua51-devel lua52-devel lua-devel
+ libglib-devel libffi-devel gobject-introspection gir-freedesktop"
+_depends="gir-freedesktop"
+depends="${_depends} lua"
+short_desc="Lua bindings for gnome/gobject using gobject-introspection library"
+maintainer="Orphaned <orphan@voidlinux.org>"
+license="MIT"
+homepage="https://github.com/pavouk/lgi"
+distfiles="https://github.com/pavouk/lgi/archive/$version.tar.gz"
+checksum=cfc4105482b4730b3a40097c9d9e7e35c46df2fb255370bdeb2f45a886548c4f
+
+_alternatives="
+ lgi:dump-typelib:/usr/bin/dump-typelib__luaver__
+"
+alternatives=${_alternatives/__luaver__/5.3}
+
+post_extract() {
+	mkdir -p lua5.1
+	mv * lua5.1 || true
+	cp -a lua5.1 lua5.2
+	cp -a lua5.1 lua5.3
+}
+
+do_build() {
+	for lv in 5.1 5.2 5.3; do
+		cd ${wrksrc}/lua${lv}
+		make LUA_VERSION="${lv}" \
+			CFLAGS="$CFLAGS -I$XBPS_CROSS_BASE/usr/include/lua${lv}" \
+			LDFLAGS="$LDFLAGS" \
+			${makejobs}
+	done
+}
+
+do_install() {
+	vmkdir usr/bin
+	for luaver in 5.1 5.2 5.3; do
+		cd ${wrksrc}/lua${luaver}
+
+		# fix lua version in shebang
+		vsed -e "s|env lua|env lua${luaver}|" -i tools/dump-typelib.lua
+
+		# dump-typelib must be renamed for the alternative group
+		vcopy tools/dump-typelib.lua usr/bin/dump-typelib$luaver
+		make PREFIX=/usr DESTDIR=$DESTDIR LUA_VERSION=$luaver install
+	done
+	vlicense ${wrksrc}/lua5.3/LICENSE
+}
+
+lgi_package() {
+	build_style="meta"
+	depends="lua-lgi>=${version}_${revision}"
+	short_desc+=" (transitional dummy package)"
+}
+
+_subpackage() {
+	_luaver=$1
+	depends="${_depends} lua${_luaver/\./}"
+	short_desc+=" (Lua ${_luaver})"
+	alternatives="${_alternatives/__luaver__/${_luaver}}"
+	pkg_install() {
+		vmove usr/lib/lua/${_luaver}/lgi/corelgilua51.so
+		vmove usr/bin/dump-typelib${_luaver}
+		vmove usr/share/lua/${_luaver}/lgi
+	}
+}
+
+lua51-lgi_package() {
+	_subpackage 5.1
+}
+
+lua52-lgi_package() {
+	_subpackage 5.2
+}
diff --git a/srcpkgs/lua51-lgi b/srcpkgs/lua51-lgi
new file mode 120000
index 00000000000..d00035eb25d
--- /dev/null
+++ b/srcpkgs/lua51-lgi
@@ -0,0 +1 @@
+lua-lgi/
\ No newline at end of file
diff --git a/srcpkgs/lua52-lgi b/srcpkgs/lua52-lgi
new file mode 120000
index 00000000000..db68c0a96c3
--- /dev/null
+++ b/srcpkgs/lua52-lgi
@@ -0,0 +1 @@
+lua-lgi
\ No newline at end of file

From 10de253ae37fcbc04ff6f98215531c517d3e6f10 Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:57:29 +0700
Subject: [PATCH 2/2] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 33 ++++++++++++++++++++++++++++-----
 1 file changed, 28 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index 3f559ea1f87..e46e8f3b462 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -1,17 +1,17 @@
 # Template file for 'awesome'
 pkgname=awesome
 version=4.3
-revision=4
+revision=5
 build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
 conf_files="/etc/xdg/awesome/rc.lua"
-hostmakedepends="ruby-asciidoctor ImageMagick lgi lua pkg-config xmlto"
+hostmakedepends="ruby-asciidoctor ImageMagick pkg-config xmlto"
 makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
- startup-notification-devel imlib2-devel lgi libxdg-basedir-devel
- gdk-pixbuf-devel lua-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lgi>=0.7.2 pango"
+ startup-notification-devel imlib2-devel libxdg-basedir-devel
+ gdk-pixbuf-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
+depends="dbus-x11 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,32 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT instead of lua"
+
+hostmakedepends+=" $(vopt_if jit 'lua51 LuaJIT lua51-lgi' 'lua lua-lgi')"
+makedepends+=" $(vopt_if jit \
+	'lua51-devel LuaJIT-devel lua51-lgi' \
+	'lua-devel lua-lgi')"
+depends+=" $(vopt_if jit lua51 lua)-lgi>=0.7.2"
+_luaname="$(vopt_if jit luajit lua)"
+
+if [ "$_luaname" = "luajit" ]; then
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	# Use correct lua name
+	vsed -e "s|COMMAND lua\b|COMMAND ${_luaname}|" \
+		-i awesomeConfig.cmake \
+		-i tests/examples/CMakeLists.txt
+	vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER ${_luaname}|" \
+		-i tests/examples/CMakeLists.txt
 }
 
 post_install() {

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-608257244

Comment:
I saw Travis do stuff like updating xbps and some other base packages. Should that be done somewhere else?

Re: [PR PATCH] [Updated] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

There is an updated pull request by ndgnuh against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 2362 bytes --]

From b8fea24ec01c8de3dd7cb35a6d7f0af07f896365 Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:57:29 +0700
Subject: [PATCH] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index d372beedbd6..98ee8cc54da 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -1,7 +1,7 @@
 # Template file for 'awesome'
 pkgname=awesome
 version=4.3
-revision=6
+revision=7
 build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
@@ -11,7 +11,7 @@ makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
  startup-notification-devel imlib2-devel lua53-lgi libxdg-basedir-devel
  gdk-pixbuf-devel lua53-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lua53-lgi>=0.7.2 pango"
+depends="dbus-x11 $(vopt_if jit lua51-lgi lua53-lgi)>=0.7.2 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,32 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT instead of lua"
+
+hostmakedepends+=" $(vopt_if jit 'lua51 LuaJIT lua51-lgi' 'lua lua-lgi')"
+makedepends+=" $(vopt_if jit \
+	'lua51-devel LuaJIT-devel lua51-lgi' \
+	'lua-devel lua-lgi')"
+depends+=" $(vopt_if jit lua51 lua)-lgi>=0.7.2"
+_luaname="$(vopt_if jit luajit lua)"
+
+if [ "$_luaname" = "luajit" ]; then
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	# Use correct lua name
+	vsed -e "s|COMMAND lua\b|COMMAND ${_luaname}|" \
+		-i awesomeConfig.cmake \
+		-i tests/examples/CMakeLists.txt
+	vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER ${_luaname}|" \
+		-i tests/examples/CMakeLists.txt
 }
 
 post_install() {

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653576421

Comment:
I saw master has already have renamed `lgi`, so I dropped my old `lgi` commit. Also, this is the first time I rebase a PR, did I do it right?

Re: [PR PATCH] [Updated] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

There is an updated pull request by ndgnuh against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 2569 bytes --]

From c4412c1d184a780b036e7940b780e5f9b508203e Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:57:29 +0700
Subject: [PATCH] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 33 +++++++++++++++++++++++++++++----
 1 file changed, 29 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index d372beedbd6..a538554ad04 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -6,12 +6,12 @@ build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
 conf_files="/etc/xdg/awesome/rc.lua"
-hostmakedepends="ruby-asciidoctor ImageMagick lua53-lgi lua53 pkg-config xmlto"
+hostmakedepends="ruby-asciidoctor ImageMagick pkg-config xmlto"
 makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
- startup-notification-devel imlib2-devel lua53-lgi libxdg-basedir-devel
- gdk-pixbuf-devel lua53-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lua53-lgi>=0.7.2 pango"
+ startup-notification-devel imlib2-devel libxdg-basedir-devel
+ gdk-pixbuf-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
+depends="dbus-x11 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,34 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT to build Awesome"
+
+if [ "$build_option_jit" ]; then
+	hostmakedepends+=" lua51 LuaJIT lua51-lgi"
+	makedepends+=" lua51-devel LuaJIT-devel lua51-lgi"
+	depends+=" lua51-lgi>=0.7.2"
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+else
+	hostmakedepends+=" lua53 lua53-lgi"
+	makedepends+=" lua53-devel lua53-lgi"
+	depends+=" lua53-lgi>=0.7.2"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	if [ "$build_option_jit" ]; then
+		# Use correct lua name
+		vsed -e "s|COMMAND lua\b|COMMAND ${_luaname}|" \
+			-i awesomeConfig.cmake \
+			-i tests/examples/CMakeLists.txt
+		vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER ${_luaname}|" \
+			-i tests/examples/CMakeLists.txt
+	fi
 }
 
 post_install() {

Re: [PR PATCH] [Updated] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

There is an updated pull request by ndgnuh against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 2559 bytes --]

From c12b5f6b288f0f06068d0d4af16608fa3d3d5791 Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:57:29 +0700
Subject: [PATCH] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 33 +++++++++++++++++++++++++++++----
 1 file changed, 29 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index d372beedbd6..0cbbc7d3526 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -6,12 +6,12 @@ build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
 conf_files="/etc/xdg/awesome/rc.lua"
-hostmakedepends="ruby-asciidoctor ImageMagick lua53-lgi lua53 pkg-config xmlto"
+hostmakedepends="ruby-asciidoctor ImageMagick pkg-config xmlto"
 makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
- startup-notification-devel imlib2-devel lua53-lgi libxdg-basedir-devel
- gdk-pixbuf-devel lua53-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lua53-lgi>=0.7.2 pango"
+ startup-notification-devel imlib2-devel libxdg-basedir-devel
+ gdk-pixbuf-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
+depends="dbus-x11 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,34 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT to build Awesome"
+
+if [ "$build_option_jit" ]; then
+	hostmakedepends+=" lua51 LuaJIT lua51-lgi"
+	makedepends+=" lua51-devel LuaJIT-devel lua51-lgi"
+	depends+=" lua51-lgi>=0.7.2"
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+else
+	hostmakedepends+=" lua53 lua53-lgi"
+	makedepends+=" lua53-devel lua53-lgi"
+	depends+=" lua53-lgi>=0.7.2"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	if [ "$build_option_jit" ]; then
+		# Use correct lua name
+		vsed -e "s|COMMAND lua\b|COMMAND luajit|" \
+			-i awesomeConfig.cmake \
+			-i tests/examples/CMakeLists.txt
+		vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER luajit|" \
+			-i tests/examples/CMakeLists.txt
+	fi
 }
 
 post_install() {

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653626403

Comment:
bump rev

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653627129

Comment:
while at it, try removing the line that disables russian manpages, it seems to be old and might not be relevant anymore

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653627521

Comment:
also, are you sure lua51/lua51-devel are necessary?

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653704725

Comment:
So... @q66 is telling me to bump rev while @sgn told that there's no need for that if we don't switch default build option. What do I do? Originally, revision was bumped.

Re: awesome: add build option jit

[sgn]

[-- Attachment #1: Type: text/plain, Size: 200 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653704853

Comment:
There're no harm in bumping revision. I don't care much. Sorry.

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653705195

Comment:
Ok, I just wanted for everyone to come to an agreement. IMO this would be considered a revision so we should bump it. I'll check out some few other things and commit after that.

Re: awesome: add build option jit

[q66]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653707870

Comment:
the revision must be bumped because package metadata changes even if the option isn't enabled

Re: awesome: add build option jit

[sgn]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653710591

Comment:
On 2020-07-03 19:01:05-0700, Daniel Kolesa <notifications@github.com> wrote:
> the revision must be bumped because package metadata changes even if the option isn't enabled

Yes, that's right.

List of options is changed. revisions needs to be bumped.

-- 
Danh

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653705195

Comment:
Ok, I just wanted for everyone to come to an agreement. IMO this would be considered a revision so we should bump it. I'll check out some few other things and commit after that.

Edit: This might take a while. It's been a long time since my last bootstrap update. The internet is kind of crappy so it takes forever to update.

Re: [PR PATCH] [Updated] awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

There is an updated pull request by ndgnuh against master on the void-packages repository

https://github.com/ndgnuh/void-packages awesome-opt-jit
https://github.com/void-linux/void-packages/pull/20443

awesome: add build option jit
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137 

A patch file from https://github.com/void-linux/void-packages/pull/20443.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-awesome-opt-jit-20443.patch --]
[-- Type: text/x-diff, Size: 2629 bytes --]

From 2a34592906d6108f7d4c05cb8d7e0466acb3d7c9 Mon Sep 17 00:00:00 2001
From: hung <ndgnuh@protonmail.com>
Date: Fri, 3 Apr 2020 11:57:29 +0700
Subject: [PATCH] awesome: add build option for building with luajit

---
 srcpkgs/awesome/template | 35 ++++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/awesome/template b/srcpkgs/awesome/template
index d372beedbd6..9f213ec29e8 100644
--- a/srcpkgs/awesome/template
+++ b/srcpkgs/awesome/template
@@ -1,17 +1,17 @@
 # Template file for 'awesome'
 pkgname=awesome
 version=4.3
-revision=6
+revision=7
 build_style=cmake
 build_helper="qemu"
 configure_args="-DSYSCONFDIR=/etc"
 conf_files="/etc/xdg/awesome/rc.lua"
-hostmakedepends="ruby-asciidoctor ImageMagick lua53-lgi lua53 pkg-config xmlto"
+hostmakedepends="ruby-asciidoctor ImageMagick pkg-config xmlto"
 makedepends="libxcb-devel pango-devel xcb-util-devel xcb-util-image-devel
  xcb-util-keysyms-devel xcb-util-wm-devel xcb-util-cursor-devel
- startup-notification-devel imlib2-devel lua53-lgi libxdg-basedir-devel
- gdk-pixbuf-devel lua53-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
-depends="dbus-x11 lua53-lgi>=0.7.2 pango"
+ startup-notification-devel imlib2-devel libxdg-basedir-devel
+ gdk-pixbuf-devel dbus-devel libxkbcommon-devel xcb-util-xrm-devel"
+depends="dbus-x11 pango"
 short_desc="Highly configurable, next gen framework window manager for X"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
@@ -19,9 +19,34 @@ homepage="http://awesomewm.org"
 distfiles="https://github.com/awesomeWM/awesome/releases/download/v${version}/awesome-${version}.tar.xz"
 checksum=78264d6f012350b371e339127aca485260bc0aa935eff578ba75ce1a00e11753
 
+build_options="jit"
+desc_option_jit="Use LuaJIT to build Awesome"
+
+if [ "$build_option_jit" ]; then
+	hostmakedepends+=" LuaJIT lua51-lgi"
+	makedepends+=" LuaJIT-devel lua51-lgi"
+	depends+=" lua51-lgi>=0.7.2"
+	configure_args+="
+		-DLUA_LIBRARY=$XBPS_CROSS_BASE/usr/lib/libluajit-5.1.so
+		-DLUA_INCLUDE_DIR=$XBPS_CROSS_BASE/usr/include/luajit-2.1"
+else
+	hostmakedepends+=" lua53 lua53-lgi"
+	makedepends+=" lua53-devel lua53-lgi"
+	depends+=" lua53-lgi>=0.7.2"
+fi
+
 pre_configure() {
 	# Russian manpages fail to build.
 	vsed -i -e "s|es fr de ru|es fr de|g" CMakeLists.txt
+
+	if [ "$build_option_jit" ]; then
+		# Use correct lua name
+		vsed -e "s|COMMAND lua\b|COMMAND luajit|" \
+			-i awesomeConfig.cmake \
+			-i tests/examples/CMakeLists.txt
+		vsed -e "s|LUA_COV_RUNNER lua\b|LUA_COV_RUNNER luajit|" \
+			-i tests/examples/CMakeLists.txt
+	fi
 }
 
 post_install() {

Re: awesome: add build option jit

[ndgnuh]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by ndgnuh on void-packages repository

https://github.com/void-linux/void-packages/pull/20443#issuecomment-653911364

Comment:
I bumped the revision and remove `lua51`, `lua51-devel` dependencies.

Re: [PR PATCH] [Closed]: awesome: add build option jit

[sgn]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

There's a closed pull request on the void-packages repository

awesome: add build option jit
https://github.com/void-linux/void-packages/pull/20443

Description:
Enables users to build `awesome` with `LuaJIT`.

Change log:
- `lgi`: rename to `lua-lgi`, create alternative group `lgi`
- New package: `lua51-lgi` (dependencies for `awesome` running with `LuaJIT`)
- `./xbps-src pkg awesome -o jit`, this option is disabled by default.

Related/based on this PR: #16137