Re: firefox: build with pipewire patch to enable screenshare for wayland users

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-653936588

Comment:
Is there any attempt to get this patch or another solution to this problem into upstream webrtc?

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-758836938

Comment:
Closing this, then.

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-758815186

Comment:
Does seem to be the case according to https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-758806076

Comment:
I think it works ootb since FF 84

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-716187240

Comment:
This patch breaks cross builds. If there is interest in getting it in, please fix it.

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[jnbr]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

New comment by jnbr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-716121174

Comment:
I started a local build with this patch for all architectures we support.
I'm still no fan of pulling in a 800 lines patch.
This is more than all our current patches for firefox combined and it is already unpleasant to maintain.

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[klardotsh]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New comment by klardotsh on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-716083334

Comment:
What testing would still be needed for this? Is it enough to fire up some cross-compile jobs against this branch (perhaps building x86_64 and aarch64) and make sure they still produce seemingly-valid packages? (I could also test the aarch64 build if I were to revive my Snapdragon laptop...)

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-654381501

Comment:
The patches seem to have been upstreamed into WebRTC already, I think the issue is that Firefox is having issues properly linking to the library (that's what I understood from the bug report and the linked threads). We might need to verify that it applies cleanly for cross compiled platforms as well.

Re: firefox: build with pipewire patch to enable screenshare for wayland users

[absrd]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New comment by absrd on void-packages repository

https://github.com/void-linux/void-packages/pull/23291#issuecomment-654372479

Comment:
> Is there any attempt to get this patch or another solution to this problem into upstream webrtc?

https://bugzilla.mozilla.org/show_bug.cgi?id=1430775

Doesn't seem so, so each distro are making their patches.