* Re: build-style/cargo: pass config_args in do_check.
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23306@inbox.vuxu.org>
2020-07-05 20:37 ` build-style/cargo: pass config_args in do_check jnbr
@ 2020-07-06 0:45 ` ericonr
2020-07-06 7:00 ` jnbr
2020-07-06 7:01 ` [PR PATCH] [Merged]: " jnbr
3 siblings, 0 replies; 4+ messages in thread
From: ericonr @ 2020-07-06 0:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23306#issuecomment-653963193
Comment:
@jnbr should we add `--locked` to the build step as well? Or only for test and install?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: build-style/cargo: pass config_args in do_check.
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23306@inbox.vuxu.org>
2020-07-05 20:37 ` build-style/cargo: pass config_args in do_check jnbr
2020-07-06 0:45 ` ericonr
@ 2020-07-06 7:00 ` jnbr
2020-07-06 7:01 ` [PR PATCH] [Merged]: " jnbr
3 siblings, 0 replies; 4+ messages in thread
From: jnbr @ 2020-07-06 7:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 319 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/23306#issuecomment-654052451
Comment:
No, this would break packages that do not ship a Cargo.lock file.
Actually, I just checked, we don't need it for `cargo test`,it is only `cargo install`, which behaves differently.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PR PATCH] [Merged]: build-style/cargo: pass config_args in do_check.
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23306@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-07-06 7:00 ` jnbr
@ 2020-07-06 7:01 ` jnbr
3 siblings, 0 replies; 4+ messages in thread
From: jnbr @ 2020-07-06 7:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 286 bytes --]
There's a merged pull request on the void-packages repository
build-style/cargo: pass config_args in do_check.
https://github.com/void-linux/void-packages/pull/23306
Description:
Cargo rebuilds the package if the configure_args aren't the same, which
makes it test the wrong binary.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: build-style/cargo: pass config_args in do_check.
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23306@inbox.vuxu.org>
@ 2020-07-05 20:37 ` jnbr
2020-07-06 0:45 ` ericonr
` (2 subsequent siblings)
3 siblings, 0 replies; 4+ messages in thread
From: jnbr @ 2020-07-05 20:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New comment by jnbr on void-packages repository
https://github.com/void-linux/void-packages/pull/23306#issuecomment-653936213
Comment:
Not sure if it makes a difference here but I would add `--locked` as well
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-06 7:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23306@inbox.vuxu.org>
2020-07-05 20:37 ` build-style/cargo: pass config_args in do_check jnbr
2020-07-06 0:45 ` ericonr
2020-07-06 7:00 ` jnbr
2020-07-06 7:01 ` [PR PATCH] [Merged]: " jnbr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).