Re: [PR PATCH] [Updated] [WIP] [Help needed] rhythmbox: optionalise brasero

Re: [PR PATCH] [Updated] [WIP] [Help needed] rhythmbox: optionalise brasero

[mnabid]

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

There is an updated pull request by mnabid against master on the void-packages repository

https://github.com/mnabid/void-packages rhythmbox
https://github.com/void-linux/void-packages/pull/22700

[WIP] [Help needed] rhythmbox: optionalise brasero
This PR adds a `build_option` for brasero and disables it by default. 

Note, `rhythmbox` from both [**Ubuntu**](https://packages.ubuntu.com/groovy/rhythmbox) and [**Debian**](https://packages.debian.org/sid/rhythmbox) repos doesn't have `brasero` as dependency. [**Arch Linux**](https://www.archlinux.org/packages/extra/x86_64/rhythmbox/) lists `brasero` as an optional dependency. But the one from Void repo pulls down `brasero` as hard dependency, which shouldn't be the case. 

A patch file from https://github.com/void-linux/void-packages/pull/22700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhythmbox-22700.patch --]
[-- Type: text/x-diff, Size: 1795 bytes --]

From 8c3a223537000196cbb4659c4cb461a269af7c71 Mon Sep 17 00:00:00 2001
From: Nafis <mnabid.25@outlook.com>
Date: Mon, 6 Jul 2020 14:58:45 +0600
Subject: [PATCH] rhythmbox: optionalise brasero

---
 srcpkgs/rhythmbox/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/rhythmbox/template b/srcpkgs/rhythmbox/template
index bd3a56f6359..ee9955f8826 100644
--- a/srcpkgs/rhythmbox/template
+++ b/srcpkgs/rhythmbox/template
@@ -1,11 +1,11 @@
 # Template file for 'rhythmbox'
 pkgname=rhythmbox
 version=3.4.4
-revision=2
+revision=3
 build_style=gnu-configure
 build_helper=gir
 configure_args="--disable-static --with-gudev --without-hal
- $(vopt_if gir --enable-vala)
+ $(vopt_if gir --enable-vala) $(vopt_with brasero)
  ac_cv_strftime_supports_E_O=yes"
 hostmakedepends="pkg-config intltool gnome-doc-utils itstool glib-devel
  $(vopt_if gir 'gobject-introspection vala')"
@@ -14,7 +14,7 @@ makedepends="gtk+3-devel libsoup-gnome-devel totem-pl-parser-devel
  libmtp-devel avahi-glib-libs-devel libpeas-devel brasero-devel
  libnotify-devel tdb-devel libsecret-devel libSM-devel grilo-devel
  gst-plugins-base1-devel clutter-gtk-devel python3-devel python-gobject-devel
- libdmapsharing-devel"
+ libdmapsharing-devel $(vopt_if brasero brasero-devel)"
 depends="gir-freedesktop desktop-file-utils hicolor-icon-theme"
 short_desc="GNOME integrated music management application"
 maintainer="Orphaned <orphan@voidlinux.org>"
@@ -26,7 +26,8 @@ checksum=ee0eb0d7d7bdf696ac9471b19ff3bea3240d63b6cb8a134bf632054af8665d90
 python_version=3
 pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
 
-build_options="gir"
+build_options="gir brasero"
+desc_option_brasero="Enable burning discs"
 build_options_default="gir"
 
 pre_build() {