[PR PATCH] python3-jupyter_console: tarball from github instead of pypi

[PR PATCH] python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

There is a new pull request by non-Jedi against master on the void-packages repository

https://github.com/non-Jedi/void-packages python3-jupyter_console/add-script
https://github.com/void-linux/void-packages/pull/23446

python3-jupyter_console: tarball from github instead of pypi
The tarball on pypi does not include the scripts dir which is where
/usr/bin/jupyter-console is installed from. Earlier versions included
the scripts directory on pypi.

A patch file from https://github.com/void-linux/void-packages/pull/23446.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-jupyter_console/add-script-23446.patch --]
[-- Type: text/x-diff, Size: 1581 bytes --]

From 83058bc34da0e5079579bcca372bd7d8f6f692e9 Mon Sep 17 00:00:00 2001
From: Adam Beckmeyer <adam_gpg@thebeckmeyers.xyz>
Date: Tue, 7 Jul 2020 09:49:55 -0400
Subject: [PATCH] python3-jupyter_console: tarball from github instead of pypi

The tarball on pypi does not include the scripts dir which is where
/usr/bin/jupyter-console is installed from. Earlier versions included
the scripts directory on pypi.
---
 srcpkgs/python3-jupyter_console/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-jupyter_console/template b/srcpkgs/python3-jupyter_console/template
index 85cdf4df567..3a56c47392b 100644
--- a/srcpkgs/python3-jupyter_console/template
+++ b/srcpkgs/python3-jupyter_console/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-jupyter_console'
 pkgname=python3-jupyter_console
 version=6.1.0
-revision=1
+revision=2
 archs=noarch
 wrksrc="jupyter_console-${version}"
 build_style=python3-module
@@ -13,8 +13,9 @@ short_desc="Jupyter terminal console (Python3)"
 maintainer="Alessio Sergi <al3hex@gmail.com>"
 license="BSD-3-Clause"
 homepage="https://github.com/jupyter/jupyter_console"
-distfiles="${PYPI_SITE}/j/jupyter_console/jupyter_console-${version}.tar.gz"
-checksum=6f6ead433b0534909df789ea64f0a14cdf9b6b2360757756f08182be4b9e431b
+# pypi release of jupyter_console v6.1.0 does not include scripts dir
+distfiles="${homepage}/archive/${version}.tar.gz"
+checksum=838c95c99ce52978e1660e7a30dd933dede158e2f4da1bc5fad1a8fad44570b7
 # alternatives will be a conflict
 conflicts="python-jupyter_console<=6.0.0_2"
 

Re: python3-jupyter_console: tarball from github instead of pypi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-654953208

Comment:
(I'm the author of the later)
Which scripts are missing?

Re: python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

New comment by non-Jedi on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-654956912

Comment:
It's not you that's missing anything. I think they just screwed up their pypi release. It doesn't include the [scripts dir](https://github.com/jupyter/jupyter_console/tree/master/scripts) which is where /usr/bin/jupyter-console is installed from.

Re: python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by non-Jedi on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-654956912

Comment:
I think they just screwed up their pypi release. It doesn't include the [scripts dir](https://github.com/jupyter/jupyter_console/tree/master/scripts) which is where /usr/bin/jupyter-console is installed from. Actually from my testing, `setup.py` might automatically generate that script but only when there's a `script` directory (even if it's empty).

Re: [PR PATCH] [Merged]: python3-jupyter_console: tarball from github instead of pypi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There's a merged pull request on the void-packages repository

python3-jupyter_console: tarball from github instead of pypi
https://github.com/void-linux/void-packages/pull/23446

Description:
The tarball on pypi does not include the scripts dir which is where
/usr/bin/jupyter-console is installed from. Earlier versions included
the scripts directory on pypi.

This was included in #20409 but not in #19967, which are similar PRs, but the latter was actually merged.

Re: python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by non-Jedi on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-655517961

Comment:
Thanks!

Re: python3-jupyter_console: tarball from github instead of pypi

[sgn]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-655610980

Comment:
I tempted to revert this.
https://github.com/keybase/client/issues/10800

Re: python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New comment by non-Jedi on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-655615535

Comment:
Oof; that's not good (of course that issue affects a lot more than just this package). The alternative workaround is to `mkdir scripts` in `pre_build` (it's been months since I missed with setuptools, so I'm not 100% positive this works).

Re: python3-jupyter_console: tarball from github instead of pypi

[non-Jedi]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

New comment by non-Jedi on void-packages repository

https://github.com/void-linux/void-packages/pull/23446#issuecomment-655626390

Comment:
The reason `/usr/bin/jupyter-console` is not created automatically is that [setuptools isn't being used by setup.py unless `'develop' in sys.argv or any(a.startswith('bdist') for a in sys.argv)`](https://github.com/jupyter/jupyter_console/blob/81fcbde0ab502f1d434d3bad26c6e9bf2e2885ca/setup.py#L93) which is quite annoying for our purposes (otherwise it falls back to distutils which doesn't have the script-creation feature). I'll see if patching that away works well.