Re: [PR REVIEW] cpputest: update to 4.0.

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r450754652

Comment:
Moved line and rebases onto master. Thank you for the review.

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r450754652

Comment:
Moved line and rebased onto master. Thank you for the review.

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r450772583

Comment:
```
Linting srcpkgs/cpputest/template...

srcpkgs/cpputest/template: Place configure_args+= after checksum=
```

Re: [PR REVIEW] cpputest: update to 4.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r450840147

Comment:
make it conditional on `XBPS_CHECK_PKGS`, some people like to run tests

Re: [PR REVIEW] cpputest: update to 4.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r450840147

Comment:
it complains because you have a needless `+=`. please make it conditional on `XBPS_CHECK_PKGS`, some people like to run tests

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451069498

Comment:
Tests work only on native builds. Is disabling them on cross OΚ?

Re: [PR REVIEW] cpputest: update to 4.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451163896

Comment:
of course tests only work on native builds. that is implied , no need check on $CROSS_BUILD.

Re: [PR REVIEW] cpputest: update to 4.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451164981

Comment:
see `srcpkgs/json-c++/template` for an example, set `XBPS_CHECK_PKGS=yes` in `etc/conf` to run do_check

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451393304

Comment:
> of course tests only work on native builds. that is implied , no need check on $CROSS_BUILD.

It runs tests during build.

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 297 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451393304

Comment:
> of course tests only work on native builds. that is implied , no need check on $CROSS_BUILD.

It runs tests during build, that is the problem... 

Re: [PR PATCH] [Updated] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 317 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages cpputest
https://github.com/void-linux/void-packages/pull/23219

cpputest: update to 4.0.


A patch file from https://github.com/void-linux/void-packages/pull/23219.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cpputest-23219.patch --]
[-- Type: text/x-diff, Size: 1364 bytes --]

From e64c8e296de69689d797a50190cb1270e58f5f66 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Wed, 24 Jun 2020 23:55:16 +0300
Subject: [PATCH] cpputest: update to 4.0.

---
 srcpkgs/cpputest/template | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/cpputest/template b/srcpkgs/cpputest/template
index 1b6e933897b..302db63faa8 100644
--- a/srcpkgs/cpputest/template
+++ b/srcpkgs/cpputest/template
@@ -1,15 +1,19 @@
 # Template file for 'cpputest'
-pkgname="cpputest"
-version="3.8"
+pkgname=cpputest
+version=4.0
 revision=1
-build_style="cmake"
+build_style=cmake
 short_desc="CppUTest unit testing and mocking framework for C/C++"
 maintainer="Julien Dehos <dehos@lisic.univ-littoral.fr>"
+license="BSD-3-Clause"
 homepage="http://cpputest.github.io/"
-license="BSD"
-distfiles="https://github.com/cpputest/${pkgname}/releases/download/v${version}/${pkgname}-${version}.tar.gz"
-checksum="c81dccc5a1bfc7fc6511590c0a61def5f78e3fb19cb8e1f889d8d3395a476456"
-configure_args+=" -DTESTS=OFF"
+distfiles="https://github.com/cpputest/cpputest/releases/download/v${version}/cpputest-${version}.tar.gz"
+checksum=21c692105db15299b5529af81a11a7ad80397f92c122bd7bf1e4a4b0e85654f7
+
+if [ "$CROSS_BUILD" ]; then
+		configure_args=" -DTESTS_BUILD_DISCOVER=OFF"
+fi
+
 post_install() {
 	vlicense COPYING
 }

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451413299

Comment:
The problem was not actual with building or running tests but rather with discovering tests during build. I disabled it on cross and tested locally with aarch64 and armv7l.

Re: [PR REVIEW] cpputest: update to 4.0.

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23219#discussion_r451413299

Comment:
The problem was not actually with building or running tests but rather with discovering tests during build. I disabled it on cross and tested building locally with aarch64 and armv7l.

Re: [PR PATCH] [Closed]: cpputest: update to 4.0.

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

There's a closed pull request on the void-packages repository

cpputest: update to 4.0.
https://github.com/void-linux/void-packages/pull/23219

Description: