* Re: [PR REVIEW] New package: kiten-20.04.2
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23096@inbox.vuxu.org>
@ 2020-07-09 16:08 ` sgn
2020-07-09 16:09 ` sgn
` (3 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-07-09 16:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23096#discussion_r452328474
Comment:
`-DBUILD_TESTING=ON`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] New package: kiten-20.04.2
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23096@inbox.vuxu.org>
2020-07-09 16:08 ` [PR REVIEW] New package: kiten-20.04.2 sgn
@ 2020-07-09 16:09 ` sgn
2020-07-09 16:09 ` sgn
` (2 subsequent siblings)
4 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-07-09 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23096#discussion_r452329376
Comment:
This line is too long, please wrap at 72 characters.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] New package: kiten-20.04.2
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23096@inbox.vuxu.org>
2020-07-09 16:08 ` [PR REVIEW] New package: kiten-20.04.2 sgn
2020-07-09 16:09 ` sgn
@ 2020-07-09 16:09 ` sgn
2020-07-09 16:09 ` sgn
2020-07-09 16:09 ` sgn
4 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-07-09 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23096#discussion_r452329799
Comment:
indent with TAB, and move after the below `if`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] New package: kiten-20.04.2
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23096@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-07-09 16:09 ` sgn
@ 2020-07-09 16:09 ` sgn
2020-07-09 16:09 ` sgn
4 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-07-09 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23096#discussion_r452330184
Comment:
I'll just merge this with above `hostmakedepends` regardless of `$CROSS_BUILD`
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] New package: kiten-20.04.2
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23096@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-07-09 16:09 ` sgn
@ 2020-07-09 16:09 ` sgn
4 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-07-09 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 175 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/23096#discussion_r452329117
Comment:
`khtml` should be auto-detected.
^ permalink raw reply [flat|nested] 5+ messages in thread