* [PR PATCH] New package: lainsafecli-0.4
@ 2020-07-15 5:22 qorg11
2020-07-15 5:31 ` qorg11
` (20 more replies)
0 siblings, 21 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 5:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 316 bytes --]
There is a new pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages add-lainsafe
https://github.com/void-linux/void-packages/pull/23582
New package: lainsafecli-0.4
A patch file from https://github.com/void-linux/void-packages/pull/23582.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-lainsafe-23582.patch --]
[-- Type: text/x-diff, Size: 1069 bytes --]
From 6941b15c937591639383de919ea92b521f582605 Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Wed, 15 Jul 2020 07:23:01 +0200
Subject: [PATCH] New package: lainsafecli-0.4
---
srcpkgs/lainsafecli/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/lainsafecli/template
diff --git a/srcpkgs/lainsafecli/template b/srcpkgs/lainsafecli/template
new file mode 100644
index 00000000000..211c485286c
--- /dev/null
+++ b/srcpkgs/lainsafecli/template
@@ -0,0 +1,18 @@
+# Template file for 'lainsafecli'
+pkgname=lainsafecli
+version=0.4
+revision=1
+archs="noarch"
+create_wrksrc=yes
+depends="perl perl-LWP perl-LWP-Protocol-https"
+build_style=meta
+short_desc="Command line interface for lainsafe."
+maintainer="qorg11 <qorg@vxempire.xyz>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/qorg11/lainsafe"
+distfiles="https://github.com/qorg11/lainsafe/archive/${version}.tar.gz"
+checksum=6359da930c002178a8ae34278a1874697db25f9778b16038de732bcaab64c4ff
+
+do_install() {
+ cd lainsafe-0.4/ && make
+}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
@ 2020-07-15 5:31 ` qorg11
2020-07-15 5:55 ` [PR REVIEW] " fosslinux
` (19 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 5:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
New comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#issuecomment-658554837
Comment:
whoops, apparently `xi lainsafecli`installs nothing.
How do I fix the makefile?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
2020-07-15 5:31 ` qorg11
@ 2020-07-15 5:55 ` fosslinux
2020-07-15 5:55 ` fosslinux
` (18 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: fosslinux @ 2020-07-15 5:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454808982
Comment:
Don't do this either. The cd command is unnessecary if you remove the build_style and let it extract itself correctly. In addition, the Makefile has no default target so this does nothing.
The Makefile also does not respect `$DESTDIR` which `xbps-src` requires. IMO, reimplement the Makefile in xbps-src, with something like:
```
vbin lainsafecli
vman doc/lainsafecli.1
```
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
2020-07-15 5:31 ` qorg11
2020-07-15 5:55 ` [PR REVIEW] " fosslinux
@ 2020-07-15 5:55 ` fosslinux
2020-07-15 5:55 ` fosslinux
` (17 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: fosslinux @ 2020-07-15 5:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 173 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454807098
Comment:
Not needed, actually bad
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (2 preceding siblings ...)
2020-07-15 5:55 ` fosslinux
@ 2020-07-15 5:55 ` fosslinux
2020-07-15 6:14 ` qorg11
` (16 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: fosslinux @ 2020-07-15 5:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 210 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454807980
Comment:
Remove build_style, let it extract it itself into a directory
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (3 preceding siblings ...)
2020-07-15 5:55 ` fosslinux
@ 2020-07-15 6:14 ` qorg11
2020-07-15 6:21 ` qorg11
` (15 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 6:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454815396
Comment:
The default Makefile target is install: https://github.com/qorg11/lainsafe/blob/master/Makefile
should I add a new targes (e.g. xbpsinstall) that does this:
~~~
vbin lainsafecli
vman doc/lainsafecli.1
~~~
?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (4 preceding siblings ...)
2020-07-15 6:14 ` qorg11
@ 2020-07-15 6:21 ` qorg11
2020-07-15 6:32 ` qorg11
` (14 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 6:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454817985
Comment:
You mean `create_wrksrc`? If I remove it i guest this:
`=> ERROR: lainsafecli-0.4_1: cannot access wrksrc directory [/builddir/lainsafecli-0.4]`
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (5 preceding siblings ...)
2020-07-15 6:21 ` qorg11
@ 2020-07-15 6:32 ` qorg11
2020-07-15 8:45 ` fosslinux
` (13 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 6:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454817985
Comment:
You mean `create_wrksrc`? If I remove it i guest this:
`=> ERROR: lainsafecli-0.4_1: cannot access wrksrc directory [/builddir/lainsafecli-0.4]`
Maybe because the repo name is lainsafe? (instead of lainsafecli)
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (6 preceding siblings ...)
2020-07-15 6:32 ` qorg11
@ 2020-07-15 8:45 ` fosslinux
2020-07-15 8:48 ` fosslinux
` (12 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: fosslinux @ 2020-07-15 8:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454891965
Comment:
Oh, yeah. So, you should make it be `wrksrc="lainsafecli-${version}"` then
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (7 preceding siblings ...)
2020-07-15 8:45 ` fosslinux
@ 2020-07-15 8:48 ` fosslinux
2020-07-15 11:36 ` ahesford
` (11 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: fosslinux @ 2020-07-15 8:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
New review comment by fosslinux on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454893930
Comment:
No, the makefile does not have a "default" target. Standard makefile behavior is for the default target to be `all`, it might just be a quirk of GNU make that it happens to run install. I also don't understand the `install: lainsafe` since there is no lainsafe target. Anyway, no, you should not add a new void-specific target. Those command are specific to xbps-src and will not work in your Makefile.
You have two options:
1. Bypass the makefile and use the vbin and vman commands directly in do_install.
2. Fix the Makefile so that it respects $DESTDIR and $PREFIX.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (8 preceding siblings ...)
2020-07-15 8:48 ` fosslinux
@ 2020-07-15 11:36 ` ahesford
2020-07-15 15:03 ` qorg11
` (10 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-15 11:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r454985449
Comment:
The default target in any Makefile is the first listed, not `all` or some other special keyword.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (9 preceding siblings ...)
2020-07-15 11:36 ` ahesford
@ 2020-07-15 15:03 ` qorg11
2020-07-15 15:03 ` qorg11
` (9 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r455123507
Comment:
It still get it. Maybe because the tar file?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (10 preceding siblings ...)
2020-07-15 15:03 ` qorg11
@ 2020-07-15 15:03 ` qorg11
2020-07-15 15:49 ` qorg11
` (8 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r455123507
Comment:
I still get it. Maybe because the tar file?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR REVIEW] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (11 preceding siblings ...)
2020-07-15 15:03 ` qorg11
@ 2020-07-15 15:49 ` qorg11
2020-07-15 16:10 ` [PR PATCH] [Closed]: " qorg11
` (7 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 15:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
New review comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#discussion_r455154608
Comment:
>Bypass the makefile and use the vbin and vman commands directly in do_install.
Fixed by doing that.
Now I only have to extract the tar file in the lainsafecli-${version} directory. By default it extracts it in the lainsafe-${version} directory. I guess it happens because the tar file has a lainsafe-${version} inside.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Closed]: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (12 preceding siblings ...)
2020-07-15 15:49 ` qorg11
@ 2020-07-15 16:10 ` qorg11
2020-07-15 17:32 ` [PR PATCH] [Updated] " qorg11
` (6 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 16:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
There's a closed pull request on the void-packages repository
New package: lainsafecli-0.4
https://github.com/void-linux/void-packages/pull/23582
Description:
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (13 preceding siblings ...)
2020-07-15 16:10 ` [PR PATCH] [Closed]: " qorg11
@ 2020-07-15 17:32 ` qorg11
2020-07-15 17:49 ` qorg11
` (5 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 17:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages add-lainsafe
https://github.com/void-linux/void-packages/pull/23582
New package: lainsafecli-0.4
A patch file from https://github.com/void-linux/void-packages/pull/23582.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-lainsafe-23582.patch --]
[-- Type: text/x-diff, Size: 2175 bytes --]
From 6941b15c937591639383de919ea92b521f582605 Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Wed, 15 Jul 2020 07:23:01 +0200
Subject: [PATCH 1/2] New package: lainsafecli-0.4
---
srcpkgs/lainsafecli/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/lainsafecli/template
diff --git a/srcpkgs/lainsafecli/template b/srcpkgs/lainsafecli/template
new file mode 100644
index 00000000000..211c485286c
--- /dev/null
+++ b/srcpkgs/lainsafecli/template
@@ -0,0 +1,18 @@
+# Template file for 'lainsafecli'
+pkgname=lainsafecli
+version=0.4
+revision=1
+archs="noarch"
+create_wrksrc=yes
+depends="perl perl-LWP perl-LWP-Protocol-https"
+build_style=meta
+short_desc="Command line interface for lainsafe."
+maintainer="qorg11 <qorg@vxempire.xyz>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/qorg11/lainsafe"
+distfiles="https://github.com/qorg11/lainsafe/archive/${version}.tar.gz"
+checksum=6359da930c002178a8ae34278a1874697db25f9778b16038de732bcaab64c4ff
+
+do_install() {
+ cd lainsafe-0.4/ && make
+}
From f6dd25e373e1402828bf21236b3f5baee9acf762 Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Wed, 15 Jul 2020 18:07:04 +0200
Subject: [PATCH 2/2] lainsafecli: fixed template
---
srcpkgs/lainsafecli/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/lainsafecli/template b/srcpkgs/lainsafecli/template
index 211c485286c..296c7e493ec 100644
--- a/srcpkgs/lainsafecli/template
+++ b/srcpkgs/lainsafecli/template
@@ -3,9 +3,8 @@ pkgname=lainsafecli
version=0.4
revision=1
archs="noarch"
-create_wrksrc=yes
+wrksrc=lainsafe-${version}
depends="perl perl-LWP perl-LWP-Protocol-https"
-build_style=meta
short_desc="Command line interface for lainsafe."
maintainer="qorg11 <qorg@vxempire.xyz>"
license="GPL-3.0-or-later"
@@ -13,6 +12,7 @@ homepage="https://github.com/qorg11/lainsafe"
distfiles="https://github.com/qorg11/lainsafe/archive/${version}.tar.gz"
checksum=6359da930c002178a8ae34278a1874697db25f9778b16038de732bcaab64c4ff
-do_install() {
- cd lainsafe-0.4/ && make
+do_install(){
+ vbin lainsafecli
+ vman doc/lainsafecli.1
}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (14 preceding siblings ...)
2020-07-15 17:32 ` [PR PATCH] [Updated] " qorg11
@ 2020-07-15 17:49 ` qorg11
2020-07-15 17:53 ` qorg11
` (4 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 17:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages add-lainsafe
https://github.com/void-linux/void-packages/pull/23582
New package: lainsafecli-0.4
A patch file from https://github.com/void-linux/void-packages/pull/23582.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-lainsafe-23582.patch --]
[-- Type: text/x-diff, Size: 1076 bytes --]
From 24bca7856c082808ff4a0b67bb768726c3f0c30c Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Wed, 15 Jul 2020 19:47:59 +0200
Subject: [PATCH] New package: lainsafecli-0.4
---
srcpkgs/lainsafecli/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/lainsafecli/template
diff --git a/srcpkgs/lainsafecli/template b/srcpkgs/lainsafecli/template
new file mode 100644
index 00000000000..296c7e493ec
--- /dev/null
+++ b/srcpkgs/lainsafecli/template
@@ -0,0 +1,18 @@
+# Template file for 'lainsafecli'
+pkgname=lainsafecli
+version=0.4
+revision=1
+archs="noarch"
+wrksrc=lainsafe-${version}
+depends="perl perl-LWP perl-LWP-Protocol-https"
+short_desc="Command line interface for lainsafe."
+maintainer="qorg11 <qorg@vxempire.xyz>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/qorg11/lainsafe"
+distfiles="https://github.com/qorg11/lainsafe/archive/${version}.tar.gz"
+checksum=6359da930c002178a8ae34278a1874697db25f9778b16038de732bcaab64c4ff
+
+do_install(){
+ vbin lainsafecli
+ vman doc/lainsafecli.1
+}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Updated] New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (15 preceding siblings ...)
2020-07-15 17:49 ` qorg11
@ 2020-07-15 17:53 ` qorg11
2020-07-15 19:30 ` ahesford
` (3 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 17:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
There is an updated pull request by qorg11 against master on the void-packages repository
https://github.com/qorg11/void-packages add-lainsafe
https://github.com/void-linux/void-packages/pull/23582
New package: lainsafecli-0.4
A patch file from https://github.com/void-linux/void-packages/pull/23582.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-lainsafe-23582.patch --]
[-- Type: text/x-diff, Size: 1076 bytes --]
From 3e4bed7b01e02ca5953930d625d44ffa1a0788a6 Mon Sep 17 00:00:00 2001
From: qorg11 <qorg@vxempire.xyz>
Date: Wed, 15 Jul 2020 19:49:41 +0200
Subject: [PATCH] New package: lainsafecli-0.4
---
srcpkgs/lainsafecli/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/lainsafecli/template
diff --git a/srcpkgs/lainsafecli/template b/srcpkgs/lainsafecli/template
new file mode 100644
index 00000000000..2f23e67462e
--- /dev/null
+++ b/srcpkgs/lainsafecli/template
@@ -0,0 +1,18 @@
+# Template file for 'lainsafecli'
+pkgname=lainsafecli
+version=0.4
+revision=1
+archs="noarch"
+wrksrc=lainsafe-${version}
+depends="perl perl-LWP perl-LWP-Protocol-https"
+short_desc="Command line interface for lainsafe"
+maintainer="qorg11 <qorg@vxempire.xyz>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/qorg11/lainsafe"
+distfiles="https://github.com/qorg11/lainsafe/archive/${version}.tar.gz"
+checksum=6359da930c002178a8ae34278a1874697db25f9778b16038de732bcaab64c4ff
+
+do_install() {
+ vbin lainsafecli
+ vman doc/lainsafecli.1
+}
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (16 preceding siblings ...)
2020-07-15 17:53 ` qorg11
@ 2020-07-15 19:30 ` ahesford
2020-07-15 19:33 ` qorg11
` (2 subsequent siblings)
20 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-15 19:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#issuecomment-658962862
Comment:
In light of the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements), can you make a case for why this single perl script and a manual page that provides little more than the help text merits packaging?
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (17 preceding siblings ...)
2020-07-15 19:30 ` ahesford
@ 2020-07-15 19:33 ` qorg11
2020-07-15 19:40 ` ahesford
2020-07-15 19:40 ` [PR PATCH] [Closed]: " ahesford
20 siblings, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 19:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#issuecomment-658964689
Comment:
It is a simple/small yet very useful script. Saves minutes of time
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (18 preceding siblings ...)
2020-07-15 19:33 ` qorg11
@ 2020-07-15 19:40 ` ahesford
2020-07-15 19:40 ` [PR PATCH] [Closed]: " ahesford
20 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-15 19:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/23582#issuecomment-658968079
Comment:
The script can be run just as effectively from `/usr/local/bin` or your home directory.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PR PATCH] [Closed]: New package: lainsafecli-0.4
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
` (19 preceding siblings ...)
2020-07-15 19:40 ` ahesford
@ 2020-07-15 19:40 ` ahesford
20 siblings, 0 replies; 24+ messages in thread
From: ahesford @ 2020-07-15 19:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
There's a closed pull request on the void-packages repository
New package: lainsafecli-0.4
https://github.com/void-linux/void-packages/pull/23582
Description:
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 16:11 [PR PATCH] " qorg11
2020-07-15 16:53 ` pullmoll
@ 2020-07-15 17:35 ` qorg11
1 sibling, 0 replies; 24+ messages in thread
From: qorg11 @ 2020-07-15 17:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by qorg11 on void-packages repository
https://github.com/void-linux/void-packages/pull/23588#issuecomment-658903464
Comment:
I have reopened the old PR.
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: New package: lainsafecli-0.4
2020-07-15 16:11 [PR PATCH] " qorg11
@ 2020-07-15 16:53 ` pullmoll
2020-07-15 17:35 ` qorg11
1 sibling, 0 replies; 24+ messages in thread
From: pullmoll @ 2020-07-15 16:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
New comment by pullmoll on void-packages repository
https://github.com/void-linux/void-packages/pull/23588#issuecomment-658879282
Comment:
Please don't close and open new PRs but use `git push -f` to force push to your branch.
Also please squash commits so the current template can be viewed without going through the commits.
Thank you :)
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2020-07-15 19:40 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 5:22 [PR PATCH] New package: lainsafecli-0.4 qorg11
2020-07-15 5:31 ` qorg11
2020-07-15 5:55 ` [PR REVIEW] " fosslinux
2020-07-15 5:55 ` fosslinux
2020-07-15 5:55 ` fosslinux
2020-07-15 6:14 ` qorg11
2020-07-15 6:21 ` qorg11
2020-07-15 6:32 ` qorg11
2020-07-15 8:45 ` fosslinux
2020-07-15 8:48 ` fosslinux
2020-07-15 11:36 ` ahesford
2020-07-15 15:03 ` qorg11
2020-07-15 15:03 ` qorg11
2020-07-15 15:49 ` qorg11
2020-07-15 16:10 ` [PR PATCH] [Closed]: " qorg11
2020-07-15 17:32 ` [PR PATCH] [Updated] " qorg11
2020-07-15 17:49 ` qorg11
2020-07-15 17:53 ` qorg11
2020-07-15 19:30 ` ahesford
2020-07-15 19:33 ` qorg11
2020-07-15 19:40 ` ahesford
2020-07-15 19:40 ` [PR PATCH] [Closed]: " ahesford
2020-07-15 16:11 [PR PATCH] " qorg11
2020-07-15 16:53 ` pullmoll
2020-07-15 17:35 ` qorg11
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).