[PR PATCH] Audacious

[PR PATCH] Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

There is a new pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages audacious
https://github.com/void-linux/void-packages/pull/23672

Audacious


A patch file from https://github.com/void-linux/void-packages/pull/23672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-23672.patch --]
[-- Type: text/x-diff, Size: 2278 bytes --]

From a8a39b32ec89b97c2d4fc3a9c32e5af8b12ea4a3 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Mon, 20 Jul 2020 22:11:08 +0300
Subject: [PATCH 1/2] audacious: update to 4.0.5.

---
 srcpkgs/audacious/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/audacious/template b/srcpkgs/audacious/template
index b1b07c0ab0f..0aaaaccfc74 100644
--- a/srcpkgs/audacious/template
+++ b/srcpkgs/audacious/template
@@ -1,6 +1,6 @@
 # Template file for 'audacious'
 pkgname=audacious
-version=4.0.4
+version=4.0.5
 revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
@@ -13,7 +13,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.${pkgname}-media-player.org/${pkgname}-${version}.tar.bz2"
-checksum=27fae151760cc65193f31224d5ba08fe9f52d2c31b9a688e8a5468b97f7c95bf
+checksum=51aea9e6a3b17f5209d49283a2dee8b9a7cd7ea96028316909da9f0bfe931f09
 
 build_options="gtk qt"
 build_options_default="qt"

From b375a566aba23dbac6b9fa2f9c944d8f54f468db Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Mon, 20 Jul 2020 22:14:29 +0300
Subject: [PATCH 2/2] audacious-plugins: update to 4.0.5.

---
 srcpkgs/audacious-plugins/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 72a7bb0ef58..02fda205065 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -1,7 +1,7 @@
 # Template file for 'audacious-plugins'
 pkgname=audacious-plugins
-version=4.0.4
-revision=2
+version=4.0.5
+revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
 hostmakedepends="gettext pkg-config"
@@ -16,7 +16,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.audacious-media-player.org/${pkgname}-${version}.tar.bz2"
-checksum=36f240ab61bf19cbca2ab6da6fc44667ae582f062627e33e656224f2fab85c48
+checksum=9f0251922886934f2aa32739b5a30eadfefa7c70dd7b3e78f94aa6fc54e0c55b
 
 build_options="gtk qt"
 build_options_default="qt"

Re: Audacious

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-661285206

Comment:
Do these versions need to be kept in sync? If so, could be nice to have a comment to that effect

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-661298366

Comment:
> Do these versions need to be kept in sync? If so, could be nice to have a comment to that effect

I think they do... I should verify that before adding a comment.

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662390106

Comment:
@ericonr Is it possible to declare a versioned runtime dep on the plugins?

Re: Audacious

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662564324

Comment:
> Is it possible to declare a versioned runtime dep on the plugins?

What do you mean?

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662605645

Comment:
Add something like audacious-plugins-${version} in the depends array of the audacious template.

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662605645

Comment:
Adding something like audacious-plugins-${version} in the depends array of the audacious template. 

Re: Audacious

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662610758

Comment:
Dependency in form of pkgname-version_revison do work in general. In this case, it would create cyclic depenency on update, thus cannot be build at all. Also audacious should not runtime depends on audacious-plugins.

Even for closer synchronization relation we use comments for now, see python3 template.

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-662657900

Comment:
@Chocimier Thank you for the explanation 👍

Re: [PR PATCH] [Updated] Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 303 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages audacious
https://github.com/void-linux/void-packages/pull/23672

Audacious


A patch file from https://github.com/void-linux/void-packages/pull/23672.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-audacious-23672.patch --]
[-- Type: text/x-diff, Size: 2350 bytes --]

From a739416394a1c5b006caefbcc291630421f5a4d3 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 24 Jul 2020 14:46:01 +0300
Subject: [PATCH 1/2] audacious-plugins: update to 4.0.5.

---
 srcpkgs/audacious-plugins/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/audacious-plugins/template b/srcpkgs/audacious-plugins/template
index 72a7bb0ef58..f9f969fc821 100644
--- a/srcpkgs/audacious-plugins/template
+++ b/srcpkgs/audacious-plugins/template
@@ -1,7 +1,8 @@
 # Template file for 'audacious-plugins'
+#Keep in sync with audacious!
 pkgname=audacious-plugins
-version=4.0.4
-revision=2
+version=4.0.5
+revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
 hostmakedepends="gettext pkg-config"
@@ -16,7 +17,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.audacious-media-player.org/${pkgname}-${version}.tar.bz2"
-checksum=36f240ab61bf19cbca2ab6da6fc44667ae582f062627e33e656224f2fab85c48
+checksum=9f0251922886934f2aa32739b5a30eadfefa7c70dd7b3e78f94aa6fc54e0c55b
 
 build_options="gtk qt"
 build_options_default="qt"

From 63ee28defa90d0cca3870ece91fa2f7532bcb581 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Fri, 24 Jul 2020 14:46:05 +0300
Subject: [PATCH 2/2] audacious: update to 4.0.5.

---
 srcpkgs/audacious/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/audacious/template b/srcpkgs/audacious/template
index b1b07c0ab0f..ba0fbf3c35b 100644
--- a/srcpkgs/audacious/template
+++ b/srcpkgs/audacious/template
@@ -1,6 +1,7 @@
 # Template file for 'audacious'
+#Keep in sync with audacious-plugins!
 pkgname=audacious
-version=4.0.4
+version=4.0.5
 revision=1
 build_style=gnu-configure
 configure_args="$(vopt_enable gtk) $(vopt_enable qt)"
@@ -13,7 +14,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-2-Clause"
 homepage="https://audacious-media-player.org/"
 distfiles="https://distfiles.${pkgname}-media-player.org/${pkgname}-${version}.tar.bz2"
-checksum=27fae151760cc65193f31224d5ba08fe9f52d2c31b9a688e8a5468b97f7c95bf
+checksum=51aea9e6a3b17f5209d49283a2dee8b9a7cd7ea96028316909da9f0bfe931f09
 
 build_options="gtk qt"
 build_options_default="qt"

Re: Audacious

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/23672#issuecomment-663500860

Comment:
@Chocimier @ericonr : Added comments to both templates.

Re: [PR PATCH] [Merged]: Audacious

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

There's a merged pull request on the void-packages repository

Audacious
https://github.com/void-linux/void-packages/pull/23672

Description: