Github messages for voidlinux
 help / color / mirror / Atom feed
From: fosslinux <fosslinux@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: NetworkManager-l2tp-1.8.2
Date: Wed, 22 Jul 2020 09:15:47 +0200	[thread overview]
Message-ID: <20200722071547.r-QG_kagdTYczXS418ki-CRh6uIYGEpDas4dqzNhSLc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23646@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/23646#discussion_r458583503

Comment:
@ericonr that's kinda silly IMO, that the binaries are in there, but w/e, you're right

@dkosovic So `glib-devel` is still good here. But, for future reference `glib-devel` actually contains different content to `libglib-devel`. This is because, in void's packaging system, a symlink just means "use this template". As you can see [here](https://github.com/void-linux/void-packages/blob/master/srcpkgs/glib/template#L26) and [here](https://github.com/void-linux/void-packages/blob/master/srcpkgs/glib/template#L38), they are both from the same template `glib`. It's just that the files get moved out to those "subpackages". So, despite them being symlinks, they actually have different content. Two subpackages from the same template can be necessary, as they are in this case :) HTH

  parent reply	other threads:[~2020-07-22  7:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-19  6:59 [PR PATCH] " dkosovic
2020-07-19  8:19 ` [PR PATCH] [Updated] " dkosovic
2020-07-19  9:03 ` dkosovic
2020-07-22  6:22 ` [PR REVIEW] " fosslinux
2020-07-22  6:22 ` fosslinux
2020-07-22  6:22 ` fosslinux
2020-07-22  6:22 ` fosslinux
2020-07-22  6:22 ` fosslinux
2020-07-22  6:33 ` ericonr
2020-07-22  7:01 ` dkosovic
2020-07-22  7:04 ` dkosovic
2020-07-22  7:15 ` fosslinux [this message]
2020-07-22  7:21 ` dkosovic
2020-07-22  7:43 ` dkosovic
2020-07-22  7:51 ` fosslinux
2020-07-22 12:13 ` [PR PATCH] [Updated] " dkosovic
2020-07-22 12:27 ` [PR REVIEW] " sgn
2020-07-22 12:28 ` sgn
2020-07-22 22:35 ` dkosovic
2020-07-23  1:45 ` sgn
2020-07-23  2:10 ` dkosovic
2020-07-23  2:17 ` sgn
2020-07-23  2:18 ` sgn
2020-07-23  2:42 ` dkosovic
2020-07-23 11:16 ` sgn
2020-07-23 13:32 ` [PR PATCH] [Closed]: " sgn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200722071547.r-QG_kagdTYczXS418ki-CRh6uIYGEpDas4dqzNhSLc@z \
    --to=fosslinux@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).