From: reback00 <reback00@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: textadept-10.8
Date: Sun, 26 Jul 2020 13:27:11 +0200 [thread overview]
Message-ID: <20200726112711.0NLfXWODAlDR5T-HcnvhKtLPaQil0TFynOZGB7cv6qA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15627@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 2761 bytes --]
New comment by reback00 on void-packages repository
https://github.com/void-linux/void-packages/pull/15627#issuecomment-663976169
Comment:
> textadept_${version}.modules.zip is not used at all.
@domrc Can you please check this issue? I think modules.zip does not carry the dependencies. But your commit had dependencies removed. It seems they're just some "plugins" for TA on the zip. I think we cannot remove the dep files and add modules.zip instead of them, [because](https://github.com/void-linux/void-packages/pull/15627#issuecomment-549018252):
> Ideally, deps should be added to distfiles for caching...
The idea behind listing them is that there are some dependencies downloaded during build process. We want them to not download when they are already downloaded. Except for some deps that has `/hg/`on their urls. They can't be downloaded through xbps, so we skipped them.
I was thinking if I should add a comment explaining this to future contributors are aware of this:
```
# Note: The dependency file versions must be checked and updated manually for
# distfiles and skip_extraction variables on every new release (and checksums
# updated accordingly). This is so that xbps can use caching for them. Details:
# https://github.com/void-linux/void-packages/pull/15627#issuecomment-549018252
```
Another question, is the modules.zip official? Are they reliable? (Just asking, because I haven't used them.)
> Scintilla, lua et al. are downloaded during configure again.
Yes. I can confirm it's happening. This happens even when I list the deps (tested locally):
```
distfiles="https://github.com/rgieseke/textadept/archive/textadept_${version}.tar.gz
http://www.lua.org/ftp/lua-5.3.5.tar.gz
http://www.inf.puc-rio.br/~roberto/lpeg/lpeg-1.0.2.tar.gz
http://github.com/keplerproject/luafilesystem/archive/v1_7_0_2.zip
http://invisible-mirror.net/archives/cdk/cdk-5.0-20150928.tgz
http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.20.tar.gz
https://foicica.com/textadept/download/textadept_${version}.modules.zip"
checksum="33d5c2eb36c93f48af2fa9fe6ae81ab2592b95af2fbe4f45144cd5b6d8a34ce0
0c2eed3f960446e1a3e4b9a1ca2f3ff893b6ce41942cf54d5dd59ab4b3b058ac
48d66576051b6c78388faad09b70493093264588fcd0f258ddaab1cdd4a15ffe
9174ab891f1d392b42a587b2afb737f9565ecf8a860d2e5a2bff457858f58478
028da75d5f777a1c4184f88e34918bd273bd83bbe3c959bc11710c4f0ea2e448
6c0d87c94ab9915e76ecd313baec08dedf3bd56de83743d9aa923a081935d2f5
2b2a94f43129ca81d67fde0b206fcd96e352b09a7f687833baa4ee8c5e46b32c"
skip_extraction="
lua-5.3.5.tar.gz
lpeg-1.0.2.tar.gz
v1_7_0_2.zip
cdk-5.0-20150928.tgz
libtermkey-0.20.tar.gz
"
```
I can look into this when I get time, but any help from you guys is appreciated.
next prev parent reply other threads:[~2020-07-26 11:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 18:53 [PR PATCH] New package: textadept-10.6 voidlinux-github
2019-10-31 22:57 ` voidlinux-github
2019-11-02 7:15 ` voidlinux-github
2019-11-02 7:43 ` voidlinux-github
2019-11-04 4:23 ` [PR PATCH] [Updated] " voidlinux-github
2019-11-04 5:15 ` voidlinux-github
2019-11-04 5:55 ` voidlinux-github
2019-11-04 11:41 ` [PR PATCH] [Updated] " voidlinux-github
2019-11-04 12:41 ` voidlinux-github
2019-11-06 3:20 ` voidlinux-github
2019-11-06 4:31 ` voidlinux-github
2020-05-18 20:21 ` Anachron
2020-07-17 8:17 ` [PR PATCH] [Updated] " reback00
2020-07-17 8:23 ` reback00
2020-07-17 8:26 ` [PR REVIEW] " reback00
2020-07-17 8:26 ` reback00
2020-07-17 8:26 ` reback00
2020-07-17 8:26 ` reback00
2020-07-17 8:41 ` New package: textadept-10.8 reback00
2020-07-22 21:38 ` Chocimier
2020-07-22 23:49 ` q66
2020-07-26 11:27 ` reback00 [this message]
2020-07-26 11:27 ` reback00
2020-07-26 11:28 ` reback00
2020-07-26 11:47 ` q66
2020-07-26 14:18 ` reback00
2020-07-26 14:23 ` reback00
2020-08-11 16:18 ` [PR PATCH] [Updated] " reback00
2020-08-11 16:57 ` reback00
2020-08-11 17:04 ` reback00
2020-08-11 19:44 ` q66
2020-08-11 19:45 ` q66
2020-08-12 16:29 ` [PR PATCH] [Updated] " reback00
2020-08-12 17:38 ` reback00
2020-08-12 20:41 ` q66
2020-08-12 20:55 ` q66
2020-08-12 20:55 ` [PR PATCH] [Closed]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200726112711.0NLfXWODAlDR5T-HcnvhKtLPaQil0TFynOZGB7cv6qA@z \
--to=reback00@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).