Github messages for voidlinux
 help / color / mirror / Atom feed
From: reback00 <reback00@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: textadept-10.8
Date: Sun, 26 Jul 2020 16:23:35 +0200	[thread overview]
Message-ID: <20200726142335.O0JFoV4RK2Qu3gY7Zf-yRG6DzKUMiKq3ZNx7chdHQVc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-15627@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 2261 bytes --]

New comment by reback00 on void-packages repository

https://github.com/void-linux/void-packages/pull/15627#issuecomment-663993671

Comment:
I found out what's the issue. The deps are downloaded just fine. But they are not copied to `src` (under build dir). If they are put there before the `make` calls, it will take those files and proceed. So we'd have to manually copy them to src:

```
post_extract() {
	echo "${skip_extraction}" | while read archive ; do
		if [ -f "${XBPS_SRCDISTDIR}/${sourcepkg}-${version}/${archive}" ]; then
			cp "${XBPS_SRCDISTDIR}/${sourcepkg}-${version}/${archive}" \
				"${wrksrc}/${build_wrksrc}/"
		fi
	done
}
```

I also did some testing. It seems xbps is now able to download from `/hg/` urls. So we can now have 100% files cached:

```
distfiles="https://github.com/rgieseke/textadept/archive/textadept_${version}.tar.gz
 http://foicica.com/hg/scintilla/archive/99fa62b828ee.zip
 http://foicica.com/hg/gtdialog/archive/db67f8a489e8.zip
 https://foicica.com/hg/bombay/archive/tip.zip>bombay.zip
 http://www.lua.org/ftp/lua-5.3.5.tar.gz
 http://www.inf.puc-rio.br/~roberto/lpeg/lpeg-1.0.2.tar.gz
 http://github.com/keplerproject/luafilesystem/archive/v1_7_0_2.zip
 http://invisible-mirror.net/archives/cdk/cdk-5.0-20150928.tgz
 http://www.leonerd.org.uk/code/libtermkey/libtermkey-0.20.tar.gz
 https://foicica.com/textadept/download/textadept_${version}.modules.zip"
checksum="..."
skip_extraction="
 99fa62b828ee.zip
 db67f8a489e8.zip
 bombay.zip
 lua-5.3.5.tar.gz
 lpeg-1.0.2.tar.gz
 v1_7_0_2.zip
 cdk-5.0-20150928.tgz
 libtermkey-0.20.tar.gz
"
```

> * textadept_${version}.modules.zip is not used at all.
> * Scintilla, lua et al. are downloaded during configure again.

So the second issue should be solved. I have these applied in a version [here](https://notabug.org/reback00/void-goodies/src/master/srcpkgs/textadept) if anyone's interested. I'll push an update once we figure out modules.zip

So, what can we do with modules.zip. It's optional and it's just plugins. Should we discard it completely? Should we create another package for it, like `textadept-modules` (similar to `geany-plugins`)? EDIT: Can we/should we create a subpackage in the template for the modules?

  parent reply	other threads:[~2020-07-26 14:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19 18:53 [PR PATCH] New package: textadept-10.6 voidlinux-github
2019-10-31 22:57 ` voidlinux-github
2019-11-02  7:15 ` voidlinux-github
2019-11-02  7:43 ` voidlinux-github
2019-11-04  4:23 ` [PR PATCH] [Updated] " voidlinux-github
2019-11-04  5:15 ` voidlinux-github
2019-11-04  5:55 ` voidlinux-github
2019-11-04 11:41 ` [PR PATCH] [Updated] " voidlinux-github
2019-11-04 12:41 ` voidlinux-github
2019-11-06  3:20 ` voidlinux-github
2019-11-06  4:31 ` voidlinux-github
2020-05-18 20:21 ` Anachron
2020-07-17  8:17 ` [PR PATCH] [Updated] " reback00
2020-07-17  8:23 ` reback00
2020-07-17  8:26 ` [PR REVIEW] " reback00
2020-07-17  8:26 ` reback00
2020-07-17  8:26 ` reback00
2020-07-17  8:26 ` reback00
2020-07-17  8:41 ` New package: textadept-10.8 reback00
2020-07-22 21:38 ` Chocimier
2020-07-22 23:49 ` q66
2020-07-26 11:27 ` reback00
2020-07-26 11:27 ` reback00
2020-07-26 11:28 ` reback00
2020-07-26 11:47 ` q66
2020-07-26 14:18 ` reback00
2020-07-26 14:23 ` reback00 [this message]
2020-08-11 16:18 ` [PR PATCH] [Updated] " reback00
2020-08-11 16:57 ` reback00
2020-08-11 17:04 ` reback00
2020-08-11 19:44 ` q66
2020-08-11 19:45 ` q66
2020-08-12 16:29 ` [PR PATCH] [Updated] " reback00
2020-08-12 17:38 ` reback00
2020-08-12 20:41 ` q66
2020-08-12 20:55 ` q66
2020-08-12 20:55 ` [PR PATCH] [Closed]: " q66

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200726142335.O0JFoV4RK2Qu3gY7Zf-yRG6DzKUMiKq3ZNx7chdHQVc@z \
    --to=reback00@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).