Re: mpd: add shoutcast support

Re: mpd: add shoutcast support

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/23292#issuecomment-661861735

Comment:
Thanks for tagging, wasn't aware of this pr.
I see no issues here building mpd with shoutcast support by default.
Then, this needs a revbump though.

Re: mpd: add shoutcast support

[lxeiqr]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

New comment by lxeiqr on void-packages repository

https://github.com/void-linux/void-packages/pull/23292#issuecomment-665085147

Comment:
I'm sorry, but I don't use Void Linux on any of my computers at the moment. I can update the version, but someone else will have to check it out.

Re: [PR PATCH] [Updated] mpd: add shoutcast support

[lxeiqr]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

There is an updated pull request by lxeiqr against master on the void-packages repository

https://github.com/lxeiqr/void-packages mpd-shout
https://github.com/void-linux/void-packages/pull/23292

mpd: add shoutcast support
Enables libshout support in mpd by default

A patch file from https://github.com/void-linux/void-packages/pull/23292.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpd-shout-23292.patch --]
[-- Type: text/x-diff, Size: 3427 bytes --]

From 67201389b622d0f543e0181e6cfd7a593667f06e Mon Sep 17 00:00:00 2001
From: lxeiqr <lxeiqr@protonmail.com>
Date: Mon, 29 Jun 2020 00:53:36 +0000
Subject: [PATCH 1/2] mpd: Add shoutcast support

---
 srcpkgs/mpd/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/mpd/template b/srcpkgs/mpd/template
index 3800902e45c..95215ca4bc4 100644
--- a/srcpkgs/mpd/template
+++ b/srcpkgs/mpd/template
@@ -6,7 +6,7 @@ build_style=meson
 configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
  -Dsoundcloud=enabled -Dpipe=true -Dtwolame=enabled -Dbzip2=enabled
  -Dzzip=enabled -Dsmbclient=disabled -Dsystemd=disabled -Dqobuz=disabled
- -Dchromaprint=disabled -Dsoxr=enabled -Dshout=disabled -Dadplug=disabled
+ -Dchromaprint=disabled -Dsoxr=enabled -Dadplug=disabled
  -Dfluidsynth=disabled -Dgme=disabled -Dwildmidi=disabled -Dsidplay=disabled
  -Dshine=disabled -Ddocumentation=true -Daudiofile=enabled -Dtremor=disabled
  -Dsolaris_output=disabled
@@ -14,7 +14,7 @@ configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
  -Dao=$(vopt_if libao enabled disabled) -Dmpcdec=$(vopt_if mpcdec enabled disabled)
  -Dsndio=$(vopt_if sndio enabled disabled) -Dpulse=$(vopt_if pulseaudio enabled disabled)
  -Dwavpack=$(vopt_if wavpack enabled disabled) -Dcdio_paranoia=$(vopt_if cdio enabled disabled)
- -Dopenal=$(vopt_if openal enabled disabled)"
+ -Dopenal=$(vopt_if openal enabled disabled) -Dshout=$(vopt_if shoutcast enabled disabled)"
 conf_files="/etc/mpd.conf"
 hostmakedepends="pkg-config"
 makedepends="avahi-glib-libs-devel boost-devel faad2-devel ffmpeg-devel
@@ -22,7 +22,7 @@ makedepends="avahi-glib-libs-devel boost-devel faad2-devel ffmpeg-devel
  libmodplug-devel libmpdclient-devel libnfs-devel libsamplerate-devel
  libsoup-devel libupnp1.8-devel mpg123-devel opus-devel yajl-devel
  zziplib-devel libsoxr-devel audiofile-devel twolame-devel
- $(vopt_if cdio 'libcdio-paranoia-devel')
+ $(vopt_if cdio 'libcdio-paranoia-devel') $(vopt_if shoutcast 'libshout-devel')
  $(vopt_if jack 'jack-devel') $(vopt_if lame 'lame-devel')
  $(vopt_if libao 'libao-devel') $(vopt_if mpcdec 'libmpcdec-devel')
  $(vopt_if pulseaudio 'pulseaudio-devel') $(vopt_if sndio 'sndio-devel')
@@ -47,10 +47,10 @@ make_dirs="
  /var/lib/mpd/playlists 0755 mpd mpd"
 
 # Package build options
-build_options="jack lame mpcdec pulseaudio libao wavpack sndio cdio openal"
+build_options="jack lame mpcdec pulseaudio libao wavpack sndio cdio openal shoutcast"
 desc_option_cdio="Enable libcdio_paranoia input plugin"
 desc_option_openal="Enable OpenAL output plugin"
-build_options_default="jack pulseaudio libao sndio cdio"
+build_options_default="jack pulseaudio libao sndio cdio shoutcast"
 
 if [ "$XBPS_CHECK_PKGS" ]; then
 	configure_args+=" -Dtest=true"

From 6ff948b1977a1cb92fd87c20cb1ca235c8d608ca Mon Sep 17 00:00:00 2001
From: lxeiqr <64892742+lxeiqr@users.noreply.github.com>
Date: Tue, 28 Jul 2020 16:49:56 +0200
Subject: [PATCH 2/2] mpd: update to 0.21.25

---
 srcpkgs/mpd/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/mpd/template b/srcpkgs/mpd/template
index 95215ca4bc4..95cbc93756c 100644
--- a/srcpkgs/mpd/template
+++ b/srcpkgs/mpd/template
@@ -1,6 +1,6 @@
 # Template file for 'mpd'
 pkgname=mpd
-version=0.21.24
+version=0.21.25
 revision=1
 build_style=meson
 configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true

Re: mpd: add shoutcast support

[daniel-eys]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

New comment by daniel-eys on void-packages repository

https://github.com/void-linux/void-packages/pull/23292#issuecomment-665094527

Comment:
Please update `checksum=` (sha256sum) as well. (and squash the commits into one)
I can confirm 0.21.25 working on x86_64.

Re: [PR PATCH] [Updated] mpd: add shoutcast support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

There is an updated pull request by ahesford against master on the void-packages repository

https://github.com/lxeiqr/void-packages mpd-shout
https://github.com/void-linux/void-packages/pull/23292

mpd: add shoutcast support
Enables libshout support in mpd by default

A patch file from https://github.com/void-linux/void-packages/pull/23292.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mpd-shout-23292.patch --]
[-- Type: text/x-diff, Size: 3376 bytes --]

From 7d2fcb8ee6e27e94c2d66b1864b8b341950544d9 Mon Sep 17 00:00:00 2001
From: lxeiqr <lxeiqr@protonmail.com>
Date: Mon, 29 Jun 2020 00:53:36 +0000
Subject: [PATCH] mpd: update to 0.21.25, add shoutcast support

---
 srcpkgs/mpd/template | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/mpd/template b/srcpkgs/mpd/template
index 3800902e45c..80a256af988 100644
--- a/srcpkgs/mpd/template
+++ b/srcpkgs/mpd/template
@@ -1,12 +1,12 @@
 # Template file for 'mpd'
 pkgname=mpd
-version=0.21.24
+version=0.21.25
 revision=1
 build_style=meson
 configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
  -Dsoundcloud=enabled -Dpipe=true -Dtwolame=enabled -Dbzip2=enabled
  -Dzzip=enabled -Dsmbclient=disabled -Dsystemd=disabled -Dqobuz=disabled
- -Dchromaprint=disabled -Dsoxr=enabled -Dshout=disabled -Dadplug=disabled
+ -Dchromaprint=disabled -Dsoxr=enabled -Dadplug=disabled
  -Dfluidsynth=disabled -Dgme=disabled -Dwildmidi=disabled -Dsidplay=disabled
  -Dshine=disabled -Ddocumentation=true -Daudiofile=enabled -Dtremor=disabled
  -Dsolaris_output=disabled
@@ -14,7 +14,7 @@ configure_args="-Dopus=enabled -Dmikmod=enabled -Dneighbor=true
  -Dao=$(vopt_if libao enabled disabled) -Dmpcdec=$(vopt_if mpcdec enabled disabled)
  -Dsndio=$(vopt_if sndio enabled disabled) -Dpulse=$(vopt_if pulseaudio enabled disabled)
  -Dwavpack=$(vopt_if wavpack enabled disabled) -Dcdio_paranoia=$(vopt_if cdio enabled disabled)
- -Dopenal=$(vopt_if openal enabled disabled)"
+ -Dopenal=$(vopt_if openal enabled disabled) -Dshout=$(vopt_if shoutcast enabled disabled)"
 conf_files="/etc/mpd.conf"
 hostmakedepends="pkg-config"
 makedepends="avahi-glib-libs-devel boost-devel faad2-devel ffmpeg-devel
@@ -22,7 +22,7 @@ makedepends="avahi-glib-libs-devel boost-devel faad2-devel ffmpeg-devel
  libmodplug-devel libmpdclient-devel libnfs-devel libsamplerate-devel
  libsoup-devel libupnp1.8-devel mpg123-devel opus-devel yajl-devel
  zziplib-devel libsoxr-devel audiofile-devel twolame-devel
- $(vopt_if cdio 'libcdio-paranoia-devel')
+ $(vopt_if cdio 'libcdio-paranoia-devel') $(vopt_if shoutcast 'libshout-devel')
  $(vopt_if jack 'jack-devel') $(vopt_if lame 'lame-devel')
  $(vopt_if libao 'libao-devel') $(vopt_if mpcdec 'libmpcdec-devel')
  $(vopt_if pulseaudio 'pulseaudio-devel') $(vopt_if sndio 'sndio-devel')
@@ -35,7 +35,7 @@ license="GPL-2.0-or-later"
 homepage="https://www.musicpd.org/"
 changelog="https://raw.githubusercontent.com/MusicPlayerDaemon/MPD/v${version}/NEWS"
 distfiles="https://www.musicpd.org/download/mpd/${version%.*}/mpd-${version}.tar.xz"
-checksum=84632a7e82e672b3a6d71651a75d05fb7acd62645c33e3f3af5a1067cfa64cd6
+checksum=20a0ad01bf327b2dbeb6ae8e1af952cb0de83d2d63fab0fa4b7183a74765c201
 LDFLAGS+=" -Wl,-z,stack-size=1048576"
 
 system_accounts="mpd"
@@ -47,10 +47,10 @@ make_dirs="
  /var/lib/mpd/playlists 0755 mpd mpd"
 
 # Package build options
-build_options="jack lame mpcdec pulseaudio libao wavpack sndio cdio openal"
+build_options="jack lame mpcdec pulseaudio libao wavpack sndio cdio openal shoutcast"
 desc_option_cdio="Enable libcdio_paranoia input plugin"
 desc_option_openal="Enable OpenAL output plugin"
-build_options_default="jack pulseaudio libao sndio cdio"
+build_options_default="jack pulseaudio libao sndio cdio shoutcast"
 
 if [ "$XBPS_CHECK_PKGS" ]; then
 	configure_args+=" -Dtest=true"

Re: mpd: add shoutcast support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/23292#issuecomment-665102159

Comment:
I'll finish this up and merge once it passes CI.

Re: [PR PATCH] [Closed]: mpd: add shoutcast support

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

There's a closed pull request on the void-packages repository

mpd: add shoutcast support
https://github.com/void-linux/void-packages/pull/23292

Description:
Enables libshout support in mpd by default