[PR PATCH] akonadi5: enable tests.

[PR PATCH] akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages akonadi
https://github.com/void-linux/void-packages/pull/23741

akonadi5: enable tests.
Tests require D-Bus, so it's necessary to run them with dbus-run-session.

@Chocimier it's failing all sqlite tests and 

```
5 - akonadixml-xmldocumenttest (Failed)
42 - mimetypecheckertest (Failed)
95 - AkonadiControl-agenttypetest (Failed)
```

A patch file from https://github.com/void-linux/void-packages/pull/23741.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-akonadi-23741.patch --]
[-- Type: text/x-diff, Size: 1152 bytes --]

From f0ac3e86c857a414dade4b2d40222d0ccef0fc61 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 22 Jul 2020 14:54:22 -0300
Subject: [PATCH] akonadi5: enable tests.

Tests require D-Bus, so it's necessary to run them with dbus-run-session.
---
 srcpkgs/akonadi5/template | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/akonadi5/template b/srcpkgs/akonadi5/template
index 587c3757958..c1fdbf7c57f 100644
--- a/srcpkgs/akonadi5/template
+++ b/srcpkgs/akonadi5/template
@@ -11,6 +11,7 @@ makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
  kdbusaddons-devel kiconthemes-devel kitemmodels-devel kio-devel sqlite-devel
  kaccounts-integration-devel libaccounts-qt5-devel qt5-tools-devel"
 depends="shared-mime-info"
+checkdepends="dbus ${depends}"
 short_desc="PIM layer providing an asynchronous API to access PIM data"
 maintainer="John <me@johnnynator.dev>"
 license="LGPL-2.1-or-later"
@@ -44,7 +45,8 @@ pre_build() {
 }
 
 do_check() {
-	: # require dbus
+	cd build
+	QT_QPA_PLATFORM=offscreen dbus-run-session make test
 }
 
 akonadi5-devel_package() {

Re: [PR REVIEW] akonadi5: enable tests.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#discussion_r458988698

Comment:
```suggestion
	QT_QPA_PLATFORM=offscreen dbus-run-session CTEST_OUTPUT_ON_FAILURE=TRUE ctest -E "(akonadixml-xmldocument|mimetypechecker|AkonadiControl-agenttype)test"
```
This should disable the failing tests.

Re: [PR REVIEW] akonadi5: enable tests.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#discussion_r458989042

Comment:
Also needs the sqlite ones to be added.

Re: akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#issuecomment-662612965

Comment:
Failing tests

```
 5/62 Test  #5: akonadixml-xmldocumenttest ..................***Failed    0.02 sec
QT_HASH_SEED: forced seed value is not 0, cannot guarantee that the hashing functions will produce a stable value.QStandardPaths: wrong permissions on runtime directory /tmp/runtime, 7755 instead of 7700
********* Start testing of XmlDocumentTest *********
Config: Using QtTest library 5.15.0, Qt 5.15.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.3.0)
PASS   : XmlDocumentTest::initTestCase()
I/O warning : failed to load external entity ""
FAIL!  : XmlDocumentTest::testDocumentLoad() 'doc.isValid()' returned FALSE. ()
   Loc: [../../../../src/xml/autotests/xmldocumenttest.cpp(35)]
PASS   : XmlDocumentTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of XmlDocumentTest *********
```

```
42/62 Test #42: mimetypecheckertest .........................***Failed    0.02 sec
QT_HASH_SEED: forced seed value is not 0, cannot guarantee that the hashing functions will produce a stable value.QStandardPaths: wrong permissions on runtime directory /tmp/runtime, 7755 instead of 7700
********* Start testing of MimeTypeCheckerTest *********
Config: Using QtTest library 5.15.0, Qt 5.15.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.3.0)
FAIL!  : MimeTypeCheckerTest::initTestCase() 'QMimeDatabase().mimeTypeForName(QLatin1String("application/x-vnd.akonadi.calendar.event")).isValid()' returned FALSE. ()
   Loc: [../../../autotests/libs/mimetypecheckertest.cpp(46)]
PASS   : MimeTypeCheckerTest::cleanupTestCase()
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted, 1ms
********* Finished testing of MimeTypeCheckerTest *********
```

```
60/62 Test #60: AkonadiControl-agenttypetest ................***Failed    0.01 sec
QStandardPaths: wrong permissions on runtime directory /tmp/runtime, 7755 instead of 7700
********* Start testing of AgentTypeTest *********
Config: Using QtTest library 5.15.0, Qt 5.15.0 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.3.0)
PASS   : AgentTypeTest::initTestCase()
WARNING: AgentTypeTest::testLoad() testdata data/akonaditestresource.desktop could not be located!
   Loc: [../../../autotests/akonadicontrol/agenttypetest.cpp(60)]
FAIL!  : AgentTypeTest::testLoad(google contacts resource) 'agentType.load(fileName, nullptr)' returned FALSE. ()
   Loc: [../../../autotests/akonadicontrol/agenttypetest.cpp(70)]
PASS   : AgentTypeTest::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 0ms
********* Finished testing of AgentTypeTest *********
```

Re: [PR PATCH] [Updated] akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages akonadi
https://github.com/void-linux/void-packages/pull/23741

akonadi5: enable tests.
Tests require D-Bus, so it's necessary to run them with dbus-run-session.

@Chocimier it's hanging on all sqlite tests and failing the ones below: 

```
5 - akonadixml-xmldocumenttest (Failed)
42 - mimetypecheckertest (Failed)
95 - AkonadiControl-agenttypetest (Failed)
```

Perhaps @Johnnynator has some suggestion for it?

A patch file from https://github.com/void-linux/void-packages/pull/23741.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-akonadi-23741.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From 35d43c4d0677bfe79a7224943e7c1380acefb4c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 22 Jul 2020 14:54:22 -0300
Subject: [PATCH] akonadi5: enable tests.

Tests require D-Bus, so it's necessary to run them with
dbus-run-session. Specific failing tests are disabled.
---
 srcpkgs/akonadi5/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/akonadi5/template b/srcpkgs/akonadi5/template
index 587c3757958..6543ca37c14 100644
--- a/srcpkgs/akonadi5/template
+++ b/srcpkgs/akonadi5/template
@@ -11,6 +11,7 @@ makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
  kdbusaddons-devel kiconthemes-devel kitemmodels-devel kio-devel sqlite-devel
  kaccounts-integration-devel libaccounts-qt5-devel qt5-tools-devel"
 depends="shared-mime-info"
+checkdepends="dbus ${depends}"
 short_desc="PIM layer providing an asynchronous API to access PIM data"
 maintainer="John <me@johnnynator.dev>"
 license="LGPL-2.1-or-later"
@@ -44,7 +45,11 @@ pre_build() {
 }
 
 do_check() {
-	: # require dbus
+	# failing tests are disabled - sqlite tests hang on futex
+	cd build
+	QT_QPA_PLATFORM=offscreen CTEST_OUTPUT_ON_FAILURE=TRUE \
+		dbus-run-session ctest -E \
+		"(akonadixml-xmldocument|mimetypechecker|AkonadiControl-agenttype|.*sqlite.*)test"
 }
 
 akonadi5-devel_package() {

Re: [PR REVIEW] akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#discussion_r459000656

Comment:
Added all, thanks.

Re: akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#issuecomment-662618996

Comment:
I tried setting `QT_HASH_SEED=0` in the environment to no effect.

Perhaps the `mimechecker` error could be solved with some locale mess?

Re: [PR PATCH] [Updated] akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages akonadi
https://github.com/void-linux/void-packages/pull/23741

akonadi5: enable tests.
Tests require D-Bus, so it's necessary to run them with dbus-run-session.

@Chocimier it's hanging on all sqlite tests and failing the ones below: 

```
5 - akonadixml-xmldocumenttest (Failed)
42 - mimetypecheckertest (Failed)
95 - AkonadiControl-agenttypetest (Failed)
```

Perhaps @Johnnynator has some suggestion for it?

A patch file from https://github.com/void-linux/void-packages/pull/23741.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-akonadi-23741.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From c6d44db47762b6b70cf9c932918fe4a9aa952451 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Wed, 22 Jul 2020 14:54:22 -0300
Subject: [PATCH] akonadi5: enable tests.

Tests require D-Bus, so it's necessary to run them with
dbus-run-session. Specific failing tests are disabled.
---
 srcpkgs/akonadi5/template | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/akonadi5/template b/srcpkgs/akonadi5/template
index 587c3757958..6543ca37c14 100644
--- a/srcpkgs/akonadi5/template
+++ b/srcpkgs/akonadi5/template
@@ -11,6 +11,7 @@ makedepends="qt5-devel qt5-plugin-mysql qt5-plugin-odbc qt5-plugin-pgsql
  kdbusaddons-devel kiconthemes-devel kitemmodels-devel kio-devel sqlite-devel
  kaccounts-integration-devel libaccounts-qt5-devel qt5-tools-devel"
 depends="shared-mime-info"
+checkdepends="dbus ${depends}"
 short_desc="PIM layer providing an asynchronous API to access PIM data"
 maintainer="John <me@johnnynator.dev>"
 license="LGPL-2.1-or-later"
@@ -44,7 +45,11 @@ pre_build() {
 }
 
 do_check() {
-	: # require dbus
+	# failing tests are disabled - sqlite tests hang on futex
+	cd build
+	QT_QPA_PLATFORM=offscreen CTEST_OUTPUT_ON_FAILURE=TRUE \
+		dbus-run-session ctest -E \
+		"(akonadixml-xmldocument|mimetypechecker|AkonadiControl-agenttype|.*sqlite.*)test"
 }
 
 akonadi5-devel_package() {

Re: akonadi5: enable tests.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23741#issuecomment-663264859

Comment:
It's failing `armv*` because of the log size. Lots of warnings. Built locally for `armv7l-musl`.

Re: [PR PATCH] [Merged]: akonadi5: enable tests.

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 490 bytes --]

There's a merged pull request on the void-packages repository

akonadi5: enable tests.
https://github.com/void-linux/void-packages/pull/23741

Description:
Tests require D-Bus, so it's necessary to run them with dbus-run-session.

@Chocimier it's hanging on all sqlite tests and failing the ones below: 

```
5 - akonadixml-xmldocumenttest (Failed)
42 - mimetypecheckertest (Failed)
95 - AkonadiControl-agenttypetest (Failed)
```

Perhaps @Johnnynator has some suggestion for it?