[PR PATCH] openvpn: rebuild against mbedtls-2.16.7

[PR PATCH] openvpn: rebuild against mbedtls-2.16.7

[jkoderu-git]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

There is a new pull request by jkoderu-git against master on the void-packages repository

https://github.com/jkoderu-git/void-packages patch-3
https://github.com/void-linux/void-packages/pull/24199

openvpn: rebuild against mbedtls-2.16.7


A patch file from https://github.com/void-linux/void-packages/pull/24199.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-3-24199.patch --]
[-- Type: text/x-diff, Size: 735 bytes --]

From da1cac86d0feaae0f161843b81aa4dd9e53fece2 Mon Sep 17 00:00:00 2001
From: jkoderu-git <64820459+jkoderu-git@users.noreply.github.com>
Date: Mon, 10 Aug 2020 14:48:19 +0000
Subject: [PATCH] openvpn: rebuild against mbedtls-2.16.7

---
 srcpkgs/openvpn/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/openvpn/template b/srcpkgs/openvpn/template
index ea91ee802de..95f9efa232b 100644
--- a/srcpkgs/openvpn/template
+++ b/srcpkgs/openvpn/template
@@ -1,7 +1,7 @@
 # Template file for 'openvpn'
 pkgname=openvpn
 version=2.4.9
-revision=3
+revision=5
 build_style=gnu-configure
 configure_args="$(vopt_enable pkcs11) --enable-iproute2 --disable-systemd
  $(vopt_with mbedtls crypto-library=mbedtls)"

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467970411

Comment:
4, not 5

That said, why is this required? DId `mbedtls` break ABI? This might require a warning on its template to warn about cases like this.

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[jkoderu-git]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New review comment by jkoderu-git on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467978355

Comment:
Revision number is my mistake.

It is required because I see packages rebuild on new version of ssl libraries and mbedtls was updated recently. I am new to void development, I do not know of ABI.

Re: [PR PATCH] [Updated] openvpn: rebuild against mbedtls-2.16.7

[jkoderu-git]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

There is an updated pull request by jkoderu-git against master on the void-packages repository

https://github.com/jkoderu-git/void-packages patch-3
https://github.com/void-linux/void-packages/pull/24199

openvpn: rebuild against mbedtls-2.16.7


A patch file from https://github.com/void-linux/void-packages/pull/24199.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-3-24199.patch --]
[-- Type: text/x-diff, Size: 1452 bytes --]

From da1cac86d0feaae0f161843b81aa4dd9e53fece2 Mon Sep 17 00:00:00 2001
From: jkoderu-git <64820459+jkoderu-git@users.noreply.github.com>
Date: Mon, 10 Aug 2020 14:48:19 +0000
Subject: [PATCH 1/2] openvpn: rebuild against mbedtls-2.16.7

---
 srcpkgs/openvpn/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/openvpn/template b/srcpkgs/openvpn/template
index ea91ee802de..95f9efa232b 100644
--- a/srcpkgs/openvpn/template
+++ b/srcpkgs/openvpn/template
@@ -1,7 +1,7 @@
 # Template file for 'openvpn'
 pkgname=openvpn
 version=2.4.9
-revision=3
+revision=5
 build_style=gnu-configure
 configure_args="$(vopt_enable pkcs11) --enable-iproute2 --disable-systemd
  $(vopt_with mbedtls crypto-library=mbedtls)"

From dd720a6704bc5365c54c325cd53885b8abac0dab Mon Sep 17 00:00:00 2001
From: jkoderu-git <64820459+jkoderu-git@users.noreply.github.com>
Date: Mon, 10 Aug 2020 15:19:13 +0000
Subject: [PATCH 2/2] Fix revision

---
 srcpkgs/openvpn/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/openvpn/template b/srcpkgs/openvpn/template
index 95f9efa232b..ef898a5def8 100644
--- a/srcpkgs/openvpn/template
+++ b/srcpkgs/openvpn/template
@@ -1,7 +1,7 @@
 # Template file for 'openvpn'
 pkgname=openvpn
 version=2.4.9
-revision=5
+revision=4
 build_style=gnu-configure
 configure_args="$(vopt_enable pkcs11) --enable-iproute2 --disable-systemd
  $(vopt_with mbedtls crypto-library=mbedtls)"

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467981514

Comment:
We rebuild packages on LibreSSL updates when they break binary compatibility (ABI = application binary interface), which means that trying to load the dynamic library simply doesn't work (or worse, has subtle errors). mbedtls, on the other hand, didn't have such a breakage on this last update., so rebuilding openvpn because of it shouldn't be necessary.

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[jkoderu-git]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by jkoderu-git on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467984966

Comment:
Thank you for explaining.

So security or bugfix release are ignored when rebuilding?

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467989807

Comment:
Usually yes.

Re: [PR PATCH] [Closed]: openvpn: rebuild against mbedtls-2.16.7

[jkoderu-git]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

There's a closed pull request on the void-packages repository

openvpn: rebuild against mbedtls-2.16.7
https://github.com/void-linux/void-packages/pull/24199

Description:

Re: [PR REVIEW] openvpn: rebuild against mbedtls-2.16.7

[mobinmob]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

New review comment by mobinmob on void-packages repository

https://github.com/void-linux/void-packages/pull/24199#discussion_r467999122

Comment:
AFAICT mbedTLS does not break ABI in the LTS branch: https://tls.mbed.org/tech-updates/blog/announcing-lts-branch-mbedtls-2.16
That is why I reverted the template to this branch: https://github.com/void-linux/void-packages/pull/20695