From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: lxd: update to 4.4.
Date: Mon, 10 Aug 2020 18:02:07 +0200 [thread overview]
Message-ID: <20200810160207.fR5ySDtnHdUAh7aWeZNyMxaQ8a5R1Aa4FTDpNCmLX8k@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24185@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/24185#issuecomment-671442976
Comment:
Per [my comment](https://github.com/void-linux/void-docs/pull/151#issuecomment-671138650) in #151 and the reply from @flexibeast, I'm inquiring here about dropping the `systemd` cgroup mount logic in the runit service.
1. Is there a compelling reason the mount responsibility should not be moved to a user's `/etc/fstab` or `/etc/rc.local`, wiht the service failing (either explicity in the `run` script or by letting `lxd` itself fail) if the `systemd` cgroup fs has not been mounted?
2. If the previous answer is "yes", is there a compelling reason to move the `systemd` mount to `/etc/runit/core-services/00-pseudofs.sh` for a global solution?
If there is a good reason to leave the mount in the runit service, I think there ought to be a `finish` script to unmount the `systemd` cgroup fs since the service takes resposibility for maintaining it.
next prev parent reply other threads:[~2020-08-10 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 1:24 [PR PATCH] " CameronNemo
2020-08-10 16:02 ` ahesford [this message]
2020-08-16 14:10 ` flexibeast
2020-09-03 4:45 ` CameronNemo
2020-09-03 5:01 ` flexibeast
2020-10-14 15:58 ` [PR PATCH] [Closed]: " CameronNemo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810160207.fR5ySDtnHdUAh7aWeZNyMxaQ8a5R1Aa4FTDpNCmLX8k@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).