Re: urlwatch: update to 2.21

Re: urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-671093491

Comment:
Bumped to 2.21
I dropped editorconfig-core-py and python3-jsbeautifier because 1) I don't use that feature so it would be guaranteed to break without me noticing 2) the docs list the [optional dependencies](https://urlwatch.readthedocs.io/en/latest/dependencies.html#optional-packages) 3) It's probably easier to install it via pip

Re: urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-671093817

Comment:
Also do_check() is broken because tox can't find the setup.cfg in $PWD.

Re: urlwatch: update to 2.21

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-671095044

Comment:
> Also do_check() is broken because tox can't find the setup.cfg in $PWD.

Could it be copied or passed as a command line parameter?

Re: [PR PATCH] [Updated] urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages update_urlwatch
https://github.com/void-linux/void-packages/pull/23087

urlwatch: update to 2.21
It works fine as-is, but at least one feature is broken because it tries to import a python module that isn't packaged. I don't use that feature (beautify) but I'll look into packaging the missing modules.

A patch file from https://github.com/void-linux/void-packages/pull/23087.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_urlwatch-23087.patch --]
[-- Type: text/x-diff, Size: 1532 bytes --]

From 28079a5ebfb50af5f7f368dfcb70ecc19ece9108 Mon Sep 17 00:00:00 2001
From: Seth <runningdroid@zoho.com>
Date: Fri, 19 Jun 2020 22:18:44 -0400
Subject: [PATCH] urlwatch: update to 2.21

---
 srcpkgs/urlwatch/template | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/urlwatch/template b/srcpkgs/urlwatch/template
index ee56c05689f..acbed601c9d 100644
--- a/srcpkgs/urlwatch/template
+++ b/srcpkgs/urlwatch/template
@@ -1,23 +1,25 @@
 # Template file for 'urlwatch'
 pkgname=urlwatch
-version=2.17
-revision=2
+version=2.21
+revision=1
 archs=noarch
 build_style=python3-module
-pycompile_module="urlwatch"
 hostmakedepends="python3-setuptools"
 depends="python3-appdirs python3-keyring python3-minidb python3-requests
  python3-yaml python3-lxml python3-cssselect"
-checkdepends="python3-nose ${depends} python3-pycodestyle"
+# Check the Docs for optional packages:
+# https://urlwatch.readthedocs.io/en/latest/dependencies.html#optional-packages
+checkdepends="python3-pytest python3-pycodestyle python3-docutils
+ python3-Pygments ${depends}"
 short_desc="Tool for monitoring webpages for updates"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://thp.io/2008/urlwatch/"
 distfiles="${PYPI_SITE}/u/urlwatch/urlwatch-${version}.tar.gz"
-checksum=08f51c7ffe7489c0be7a6c54855e074da65131714e4b6c622e4cfb107ef7ea78
+checksum=c259e0169cc99114b54470d08a8312473159dfdbed1d712d1a222fd8a9d7291a
 
 do_check() {
-	nosetests3
+	pytest -v
 }
 
 post_install() {

Re: urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 790 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-672622993

Comment:
> Could it be copied or passed as a command line parameter?

I looked closer at it and found that tox complains about not being able to find setup.cfg because setup.cfg doesn't have the lines it's looking for (it would need a [tox] section.)
After looking through the urlwatch repo I found they run pytest on [Travis CI](https://travis-ci.org/github/thp/urlwatch/jobs/717142689), so I changed the template to use pytest. There are [some tests that fail](https://gist.github.com/RunningDroid/8eb97e9c58fbf2f949d4029d47b0fdcd) but they're tests for features that are dependent on software that we don't have packaged (pdftotext & pytesseract.)

Re: urlwatch: update to 2.21

[sgn]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-672832807

Comment:
On 2020-08-11 22:58:17-0700, RunningDroid <notifications@github.com> wrote:
> There are [some tests that
> fail](https://gist.github.com/RunningDroid/8eb97e9c58fbf2f949d4029d47b0fdcd)
> but they're tests for features that are dependent on software that
> we don't have packaged (pdftotext & pytesseract.)

Then run test selectively with "pytest -k <expression>"

Re: [PR PATCH] [Updated] urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

There is an updated pull request by RunningDroid against master on the void-packages repository

https://github.com/RunningDroid/void-packages update_urlwatch
https://github.com/void-linux/void-packages/pull/23087

urlwatch: update to 2.21
It works fine as-is, but at least one feature is broken because it tries to import a python module that isn't packaged. I don't use that feature (beautify) but I'll look into packaging the missing modules.

A patch file from https://github.com/void-linux/void-packages/pull/23087.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update_urlwatch-23087.patch --]
[-- Type: text/x-diff, Size: 1655 bytes --]

From e463d75d9ac2749ae56cb5bc232efd86dfb3a3aa Mon Sep 17 00:00:00 2001
From: Seth <runningdroid@zoho.com>
Date: Fri, 19 Jun 2020 22:18:44 -0400
Subject: [PATCH] urlwatch: update to 2.21

---
 srcpkgs/urlwatch/template | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/urlwatch/template b/srcpkgs/urlwatch/template
index ee56c05689f..6a315992919 100644
--- a/srcpkgs/urlwatch/template
+++ b/srcpkgs/urlwatch/template
@@ -1,23 +1,27 @@
 # Template file for 'urlwatch'
 pkgname=urlwatch
-version=2.17
-revision=2
+version=2.21
+revision=1
 archs=noarch
 build_style=python3-module
-pycompile_module="urlwatch"
 hostmakedepends="python3-setuptools"
 depends="python3-appdirs python3-keyring python3-minidb python3-requests
  python3-yaml python3-lxml python3-cssselect"
-checkdepends="python3-nose ${depends} python3-pycodestyle"
+# Check the Docs for optional packages:
+# https://urlwatch.readthedocs.io/en/latest/dependencies.html#optional-packages
+checkdepends="python3-pytest python3-pycodestyle python3-docutils
+ python3-Pygments ${depends}"
 short_desc="Tool for monitoring webpages for updates"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="BSD-3-Clause"
 homepage="https://thp.io/2008/urlwatch/"
 distfiles="${PYPI_SITE}/u/urlwatch/urlwatch-${version}.tar.gz"
-checksum=08f51c7ffe7489c0be7a6c54855e074da65131714e4b6c622e4cfb107ef7ea78
+checksum=c259e0169cc99114b54470d08a8312473159dfdbed1d712d1a222fd8a9d7291a
 
 do_check() {
-	nosetests3
+	# skip the tests that require python modules that aren't packaged
+	# (pdftotext & pytesseract)
+	pytest -k "not (pdf or ocr)" -v
 }
 
 post_install() {

Re: urlwatch: update to 2.21

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

New comment by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/pull/23087#issuecomment-674465273

Comment:
> Then run test selectively with "pytest -k \<expression>"

Fixed, should I remove the verbose flag?

Re: [PR PATCH] [Merged]: urlwatch: update to 2.21

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

There's a merged pull request on the void-packages repository

urlwatch: update to 2.21
https://github.com/void-linux/void-packages/pull/23087

Description:
It works fine as-is, but at least one feature is broken because it tries to import a python module that isn't packaged. I don't use that feature (beautify) but I'll look into packaging the missing modules.