From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] Add _FORTIFY_SOURCE impl for musl.
Date: Thu, 13 Aug 2020 07:52:22 +0200 [thread overview]
Message-ID: <20200813055222.6HXGijY7ApqomhW28FaHQbYbWX5Aqn1KuM50nhfBrz8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24254@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 607 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24254#issuecomment-673276440
Comment:
> with -isystem rather than -I
So like I just changed it?
---
I considered making this PR mostly because dalias said he agrees with the design, so I didn't expect any huge issues with the impl. Might not be the most optimal, though.
Are your issues more with the idea of having `_FORTIFY_SOURCE` functional on musl, but requiring more bounds checks and binary size than it used to, or with the fact that this lib isn't as well implemented as it could be?
next prev parent reply other threads:[~2020-08-13 5:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 2:01 [PR PATCH] " ericonr
2020-08-13 2:03 ` [PR PATCH] [Updated] " ericonr
2020-08-13 4:29 ` q66
2020-08-13 4:43 ` q66
2020-08-13 4:52 ` q66
2020-08-13 4:55 ` q66
2020-08-13 5:46 ` [PR PATCH] [Updated] " ericonr
2020-08-13 5:51 ` ericonr
2020-08-13 5:52 ` ericonr
2020-08-13 5:52 ` ericonr [this message]
2020-08-13 14:21 ` q66
2020-08-13 14:24 ` sgn
2020-08-13 14:34 ` ericonr
2020-08-13 14:45 ` q66
2020-08-13 14:45 ` [PR PATCH] [Closed]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813055222.6HXGijY7ApqomhW28FaHQbYbWX5Aqn1KuM50nhfBrz8@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).