From: q66 <q66@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] Add _FORTIFY_SOURCE impl for musl.
Date: Thu, 13 Aug 2020 16:21:44 +0200 [thread overview]
Message-ID: <20200813142144.HaLLfKectdFXWUjlUM9cn0P-vwRNf1JSCd1Rt_pkceM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-24254@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 541 bytes --]
New comment by q66 on void-packages repository
https://github.com/void-linux/void-packages/pull/24254#issuecomment-673508244
Comment:
`XBPS_CROSS_BASE` will not work since the libc is not installed for crossbuilds (it's shipped by crosstoolchains)
I'm not fundamentally opposed to using fortify, the library could use cleaning up (it'd simplify it too, e.g. use `__builtin___memcpy_chk` and so on) and the way you implemented it in the PR is questionable
if we're to add this, the best opportunity is when doing the gcc10 transition
next prev parent reply other threads:[~2020-08-13 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 2:01 [PR PATCH] " ericonr
2020-08-13 2:03 ` [PR PATCH] [Updated] " ericonr
2020-08-13 4:29 ` q66
2020-08-13 4:43 ` q66
2020-08-13 4:52 ` q66
2020-08-13 4:55 ` q66
2020-08-13 5:46 ` [PR PATCH] [Updated] " ericonr
2020-08-13 5:51 ` ericonr
2020-08-13 5:52 ` ericonr
2020-08-13 5:52 ` ericonr
2020-08-13 14:21 ` q66 [this message]
2020-08-13 14:24 ` sgn
2020-08-13 14:34 ` ericonr
2020-08-13 14:45 ` q66
2020-08-13 14:45 ` [PR PATCH] [Closed]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813142144.HaLLfKectdFXWUjlUM9cn0P-vwRNf1JSCd1Rt_pkceM@z \
--to=q66@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).