[PR PATCH] qemu: Add `qemuconf` to depends.

[PR PATCH] qemu: Add `qemuconf` to depends.

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

There is a new pull request by flexibeast against master on the void-packages repository

https://github.com/flexibeast/void-packages modify-qemu
https://github.com/void-linux/void-packages/pull/24267

qemu: Add `qemuconf` to depends.
The `qemu-generic` service provided by this package uses `qemuconf`, but the latter currently isn't listed in "depends".

A patch file from https://github.com/void-linux/void-packages/pull/24267.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-modify-qemu-24267.patch --]
[-- Type: text/x-diff, Size: 1093 bytes --]

From 0cfb7bcd299be68d733a3ad9fb24102e9dc7ead0 Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Fri, 14 Aug 2020 12:17:26 +1000
Subject: [PATCH] qemu: Add `qemuconf` to depends.

---
 srcpkgs/qemu/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/qemu/template b/srcpkgs/qemu/template
index d1c70497473..a2456275b59 100644
--- a/srcpkgs/qemu/template
+++ b/srcpkgs/qemu/template
@@ -1,7 +1,7 @@
 # Template file for 'qemu'
 pkgname=qemu
 version=5.1.0
-revision=1
+revision=2
 short_desc="Open Source Processor Emulator"
 maintainer="Helmut Pozimski <helmut@pozimski.eu>"
 license="GPL-2.0-or-later, LGPL-2.1-or-later"
@@ -22,6 +22,7 @@ makedepends="libpng-devel libjpeg-turbo-devel pixman-devel snappy-devel
  $(vopt_if opengl 'libepoxy-devel libdrm-devel MesaLib-devel')
  $(vopt_if iscsi 'libiscsi-devel')
  $(vopt_if smartcard libcacard-devel) $(vopt_if numa 'libnuma-devel')"
+depends="qemuconf"
 
 build_options="gtk3 opengl sdl2 spice virgl smartcard numa iscsi"
 build_options_default="opengl gtk3 virgl smartcard sdl2 numa iscsi"

Re: qemu: Add `qemuconf` to depends.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674034667

Comment:
`qemuconf` can't depend on `qemu`, then, otherwise we'll get a cyclic dep.

Re: qemu: Add `qemuconf` to depends.

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674086750

Comment:
Oh, indeed. Would it be a bad idea to move the service into a separate package then? Installing a service without the program it needs to function seems, well, Less Than Optimal. :-)

Re: qemu: Add `qemuconf` to depends.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674090487

Comment:
I think you could just remove `qemu` as a dependency for `qemuconf`. If you install `qemuconf` through `qemu`, it will be available in the system c:

That said, I don't know if we want to keep things minimal. If so, perhaps move the service into the `qemuconf` package instead?

Re: qemu: Add `qemuconf` to depends.

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674091880

Comment:
Either makes sense to me, so i'll do whatever others decide is best. :-)

Re: qemu: Add `qemuconf` to depends.

[pullmoll]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674101673

Comment:
Since qemu works w/o qemuconf but qemuconf requires qemu, I'd vote for moving the service to qemuconf.

Re: qemu: Add `qemuconf` to depends.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674110326

Comment:
Isn't the qemu-generic service already in qemuconf?

Re: qemu: Add `qemuconf` to depends.

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/24267#issuecomment-674113790

Comment:
@ericonr: You're right. i thought i'd seen that it was provided by `qemu`, but no. :-/ Sorry for the noise everyone, closing. 

Re: [PR PATCH] [Closed]: qemu: Add `qemuconf` to depends.

[flexibeast]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

There's a closed pull request on the void-packages repository

qemu: Add `qemuconf` to depends.
https://github.com/void-linux/void-packages/pull/24267

Description:
The `qemu-generic` service provided by this package uses `qemuconf`, but the latter currently isn't listed in "depends".