Re: [WIP] [Help needed] rhythmbox: optionalise brasero

Re: [WIP] [Help needed] rhythmbox: optionalise brasero

[mnabid]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

New comment by mnabid on void-packages repository

https://github.com/void-linux/void-packages/pull/22700#issuecomment-654109441

Comment:
> But without `build_option_brasero`, still no luck in cross build.
> From the recent [Travis log](https://travis-ci.org/github/void-linux/void-packages/jobs/697983810) :
> 
> ```
> make[2]: Entering directory '/builddir/rhythmbox-3.4.4/bindings'
> Making all in gi
> make[3]: Entering directory '/builddir/rhythmbox-3.4.4/bindings/gi'
> make[3]: *** No rule to make target 'MPID-3.0.typelib', needed by 'all-am'.  Stop.
> ```

This issue should be solved in 8c7af181. 

Re: [PR REVIEW] rhythmbox: optionalise brasero

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by Piraty on void-packages repository

https://github.com/void-linux/void-packages/pull/22700#discussion_r471042717

Comment:
isn't that autodetected based on `brasero-devel`'s presence?

Re: [PR PATCH] [Updated] rhythmbox: optionalise brasero

[mnabid]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

There is an updated pull request by mnabid against master on the void-packages repository

https://github.com/mnabid/void-packages rhythmbox
https://github.com/void-linux/void-packages/pull/22700

rhythmbox: optionalise brasero
This PR adds a `build_option` for brasero and disables it by default. 

Note, `rhythmbox` from both [**Ubuntu**](https://packages.ubuntu.com/groovy/rhythmbox) and [**Debian**](https://packages.debian.org/sid/rhythmbox) repos doesn't have `brasero` as dependency. [**Arch Linux**](https://www.archlinux.org/packages/extra/x86_64/rhythmbox/) lists `brasero` as an optional dependency. But the one from Void repo pulls down `brasero` as hard dependency, which shouldn't be the case. 

A patch file from https://github.com/void-linux/void-packages/pull/22700.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rhythmbox-22700.patch --]
[-- Type: text/x-diff, Size: 1594 bytes --]

From 7d865c0fc3da723404761518603ec597927e9cb5 Mon Sep 17 00:00:00 2001
From: Nafis <mnabid.25@outlook.com>
Date: Mon, 6 Jul 2020 14:58:45 +0600
Subject: [PATCH] rhythmbox: optionalise brasero

---
 srcpkgs/rhythmbox/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/rhythmbox/template b/srcpkgs/rhythmbox/template
index bd3a56f6359..27c9a4f645a 100644
--- a/srcpkgs/rhythmbox/template
+++ b/srcpkgs/rhythmbox/template
@@ -1,7 +1,7 @@
 # Template file for 'rhythmbox'
 pkgname=rhythmbox
 version=3.4.4
-revision=2
+revision=3
 build_style=gnu-configure
 build_helper=gir
 configure_args="--disable-static --with-gudev --without-hal
@@ -11,7 +11,7 @@ hostmakedepends="pkg-config intltool gnome-doc-utils itstool glib-devel
  $(vopt_if gir 'gobject-introspection vala')"
 makedepends="gtk+3-devel libsoup-gnome-devel totem-pl-parser-devel
  json-glib-devel libgudev-devel libdiscid-devel vala-devel
- libmtp-devel avahi-glib-libs-devel libpeas-devel brasero-devel
+ libmtp-devel avahi-glib-libs-devel libpeas-devel $(vopt_if brasero brasero-devel)
  libnotify-devel tdb-devel libsecret-devel libSM-devel grilo-devel
  gst-plugins-base1-devel clutter-gtk-devel python3-devel python-gobject-devel
  libdmapsharing-devel"
@@ -26,7 +26,8 @@ checksum=ee0eb0d7d7bdf696ac9471b19ff3bea3240d63b6cb8a134bf632054af8665d90
 python_version=3
 pycompile_dirs="/usr/lib/rhythmbox/plugins /usr/lib/rhythmbox/sample-plugins"
 
-build_options="gir"
+build_options="gir brasero"
+desc_option_brasero="Enable CD burning support"
 build_options_default="gir"
 
 pre_build() {

Re: [PR REVIEW] rhythmbox: optionalise brasero

[mnabid]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by mnabid on void-packages repository

https://github.com/void-linux/void-packages/pull/22700#discussion_r471097838

Comment:
Yeah, `vopt_with` isn't needed, removed it.

Re: [PR REVIEW] rhythmbox: optionalise brasero

[mnabid]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by mnabid on void-packages repository

https://github.com/void-linux/void-packages/pull/22700#discussion_r471097838

Comment:
Yeah, `vopt_with` wasn't needed, removed it.

Re: [PR PATCH] [Merged]: rhythmbox: optionalise brasero

[Piraty]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

There's a merged pull request on the void-packages repository

rhythmbox: optionalise brasero
https://github.com/void-linux/void-packages/pull/22700

Description:
This PR adds a `build_option` for brasero and disables it by default. 

Note, `rhythmbox` from both [**Ubuntu**](https://packages.ubuntu.com/groovy/rhythmbox) and [**Debian**](https://packages.debian.org/sid/rhythmbox) repos doesn't have `brasero` as dependency. [**Arch Linux**](https://www.archlinux.org/packages/extra/x86_64/rhythmbox/) lists `brasero` as an optional dependency. But the one from Void repo pulls down `brasero` as hard dependency, which shouldn't be the case.