* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
@ 2020-08-16 13:05 ` Piraty
2020-08-17 18:50 ` mvf
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: Piraty @ 2020-08-16 13:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New review comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r471110830
Comment:
since you run autoeconf anyway, patch it in?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
` (4 preceding siblings ...)
2021-07-26 7:07 ` mvf
@ 2021-07-26 7:08 ` mvf
5 siblings, 0 replies; 6+ messages in thread
From: mvf @ 2021-07-26 7:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
New review comment by mvf on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r676343746
Comment:
This removes a cross-unaware file existence check that breaks the build:
```
checking for /usr/include/qt5/QtWidgets/QWidget... configure: error: cannot check for file existence when cross compiling
=> ERROR: qmidiarp-0.6.5_1: do_configure: '${configure_script} ${configure_args}' exited with 1
=> ERROR: in do_configure() at common/build-style/gnu-configure.sh:8
```
It's unnecessary too, because the `pkg-config` based check succeeds and returns the same include paths:
```
checking for Qt5Core Qt5Gui Qt5Widgets >= 5.0... yes
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
` (3 preceding siblings ...)
2021-07-20 19:57 ` ericonr
@ 2021-07-26 7:07 ` mvf
2021-07-26 7:08 ` mvf
5 siblings, 0 replies; 6+ messages in thread
From: mvf @ 2021-07-26 7:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New review comment by mvf on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r676343100
Comment:
Hm, IME it's not worse than with other libs. Of course, there will likely have to be a patch for Qt6 at some point.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
` (2 preceding siblings ...)
2021-07-20 19:57 ` ericonr
@ 2021-07-20 19:57 ` ericonr
2021-07-26 7:07 ` mvf
2021-07-26 7:08 ` mvf
5 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-20 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r673439386
Comment:
Is the removal because of the `-I$EXTRA_QT_INCLUDE_DIR` inclusion?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
2020-08-16 13:05 ` [PR REVIEW] New package: qmidiarp-0.6.5 Piraty
2020-08-17 18:50 ` mvf
@ 2021-07-20 19:57 ` ericonr
2021-07-20 19:57 ` ericonr
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-07-20 19:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r673438419
Comment:
This release is from 2017... Things using Qt sometimes start accumulating more and more patches :/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] New package: qmidiarp-0.6.5
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
2020-08-16 13:05 ` [PR REVIEW] New package: qmidiarp-0.6.5 Piraty
@ 2020-08-17 18:50 ` mvf
2021-07-20 19:57 ` ericonr
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: mvf @ 2020-08-17 18:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
New review comment by mvf on void-packages repository
https://github.com/void-linux/void-packages/pull/23072#discussion_r471708906
Comment:
Hm, what would be the benefit? A patch would be more verbose and messier to maintain. The envvar is straightforward and build system agnostic...
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-26 7:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23072@inbox.vuxu.org>
2020-08-16 13:05 ` [PR REVIEW] New package: qmidiarp-0.6.5 Piraty
2020-08-17 18:50 ` mvf
2021-07-20 19:57 ` ericonr
2021-07-20 19:57 ` ericonr
2021-07-26 7:07 ` mvf
2021-07-26 7:08 ` mvf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).