Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Manual.md: Note when `archs` should be used.
@ 2020-08-16  0:30 flexibeast
  2020-08-16 23:34 ` [PR REVIEW] " ahesford
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: flexibeast @ 2020-08-16  0:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

There is a new pull request by flexibeast against master on the void-packages repository

https://github.com/flexibeast/void-packages archs
https://github.com/void-linux/void-packages/pull/24302

Manual.md: Note when `archs` should be used.


A patch file from https://github.com/void-linux/void-packages/pull/24302.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-archs-24302.patch --]
[-- Type: text/x-diff, Size: 767 bytes --]

From 8b6b3bade08e7f49b219ac0bf57a81bbfa1b3635 Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Sun, 16 Aug 2020 10:29:19 +1000
Subject: [PATCH] Manual.md: Note when `archs` should be used.

---
 Manual.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Manual.md b/Manual.md
index ab13b1c38e9..e6d44a2352a 100644
--- a/Manual.md
+++ b/Manual.md
@@ -704,6 +704,8 @@ used.
 - `archs` Whitespace separated list of architectures that a package can be
 built for, available architectures can be found under `common/cross-profiles`
 alongside the `noarch` value for packages that do not contain any machine code.
+This should only be used when upstream explicitly states that their software only works
+on specific architectures.
 Examples:
 
 	```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] Manual.md: Note when `archs` should be used.
  2020-08-16  0:30 [PR PATCH] Manual.md: Note when `archs` should be used flexibeast
@ 2020-08-16 23:34 ` ahesford
  2020-08-16 23:55 ` [PR PATCH] [Updated] " flexibeast
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-08-16 23:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/24302#discussion_r471173362

Comment:
In general, `archs` should only be set if the upstream software explicitly targets certain architectures or there is a compelling reason why the software should not be available on some supported architectures.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] Manual.md: Note when `archs` should be used.
  2020-08-16  0:30 [PR PATCH] Manual.md: Note when `archs` should be used flexibeast
  2020-08-16 23:34 ` [PR REVIEW] " ahesford
@ 2020-08-16 23:55 ` flexibeast
  2020-08-16 23:57 ` [PR REVIEW] " flexibeast
  2020-08-17  0:02 ` [PR PATCH] [Merged]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: flexibeast @ 2020-08-16 23:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

There is an updated pull request by flexibeast against master on the void-packages repository

https://github.com/flexibeast/void-packages archs
https://github.com/void-linux/void-packages/pull/24302

Manual.md: Note when `archs` should be used.


A patch file from https://github.com/void-linux/void-packages/pull/24302.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-archs-24302.patch --]
[-- Type: text/x-diff, Size: 865 bytes --]

From 231a1f84a014aea7ed53f073aab0efc8d7ce66cb Mon Sep 17 00:00:00 2001
From: Alexis <flexibeast@gmail.com>
Date: Sun, 16 Aug 2020 10:29:19 +1000
Subject: [PATCH] Manual.md: Note when `archs` should be used.

---
 Manual.md | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Manual.md b/Manual.md
index ab13b1c38e9..8a8954e88d7 100644
--- a/Manual.md
+++ b/Manual.md
@@ -704,6 +704,9 @@ used.
 - `archs` Whitespace separated list of architectures that a package can be
 built for, available architectures can be found under `common/cross-profiles`
 alongside the `noarch` value for packages that do not contain any machine code.
+In general, `archs` should only be set if the upstream software explicitly targets
+certain architectures or there is a compelling reason why the software should not be
+available on some supported architectures.
 Examples:
 
 	```

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] Manual.md: Note when `archs` should be used.
  2020-08-16  0:30 [PR PATCH] Manual.md: Note when `archs` should be used flexibeast
  2020-08-16 23:34 ` [PR REVIEW] " ahesford
  2020-08-16 23:55 ` [PR PATCH] [Updated] " flexibeast
@ 2020-08-16 23:57 ` flexibeast
  2020-08-17  0:02 ` [PR PATCH] [Merged]: " ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: flexibeast @ 2020-08-16 23:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by flexibeast on void-packages repository

https://github.com/void-linux/void-packages/pull/24302#discussion_r471176141

Comment:
Thanks, PR updated.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: Manual.md: Note when `archs` should be used.
  2020-08-16  0:30 [PR PATCH] Manual.md: Note when `archs` should be used flexibeast
                   ` (2 preceding siblings ...)
  2020-08-16 23:57 ` [PR REVIEW] " flexibeast
@ 2020-08-17  0:02 ` ahesford
  3 siblings, 0 replies; 5+ messages in thread
From: ahesford @ 2020-08-17  0:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

There's a merged pull request on the void-packages repository

Manual.md: Note when `archs` should be used.
https://github.com/void-linux/void-packages/pull/24302

Description:


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-08-17  0:02 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16  0:30 [PR PATCH] Manual.md: Note when `archs` should be used flexibeast
2020-08-16 23:34 ` [PR REVIEW] " ahesford
2020-08-16 23:55 ` [PR PATCH] [Updated] " flexibeast
2020-08-16 23:57 ` [PR REVIEW] " flexibeast
2020-08-17  0:02 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).