[PR PATCH] xbps-src: expand note about -t flag.

[PR PATCH] xbps-src: expand note about -t flag.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

There is a new pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages chr
https://github.com/void-linux/void-packages/pull/24643

xbps-src: expand note about -t flag.
Related to #24314 

A patch file from https://github.com/void-linux/void-packages/pull/24643.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chr-24643.patch --]
[-- Type: text/x-diff, Size: 874 bytes --]

From 8a0bd4860bf2462cfae5cc2a4c827b792c2ad175 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Thu, 3 Sep 2020 13:59:38 -0300
Subject: [PATCH] xbps-src: expand note about -t flag.

---
 xbps-src | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xbps-src b/xbps-src
index 1c83708c8da..3d1f5f5ab39 100755
--- a/xbps-src
+++ b/xbps-src
@@ -217,7 +217,8 @@ $(print_cross_targets)
 -t  Create a temporary masterdir to not pollute the current one. Note that
     the existing masterdir must be fully populated with binary-bootstrap first.
     Once the target has finished, this temporary masterdir will be removed.
-    This flag requires xbps-uchroot(1).
+    This flag requires xbps-uchroot(1), and won't work on filesystems that don't
+    support overlayfs, such as ZFS.
 
 -V  Print version of xbps, then exit.
 

Re: xbps-src: expand note about -t flag.

[q66]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686631556

Comment:
afaik there is work in progress to support `renameat2` in zfs, so this might not be true after a while

Re: xbps-src: expand note about -t flag.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686632702

Comment:
Made it more generic, then.

Re: [PR PATCH] [Updated] xbps-src: expand note about -t flag.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

There is an updated pull request by ericonr against master on the void-packages repository

https://github.com/ericonr/void-packages chr
https://github.com/void-linux/void-packages/pull/24643

xbps-src: expand note about -t flag.
Related to #24314 

A patch file from https://github.com/void-linux/void-packages/pull/24643.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-chr-24643.patch --]
[-- Type: text/x-diff, Size: 861 bytes --]

From fa4cfafad541ae689429612a35aaa842fda8c3d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Rolim?= <erico.erc@gmail.com>
Date: Thu, 3 Sep 2020 13:59:38 -0300
Subject: [PATCH] xbps-src: expand note about -t flag.

---
 xbps-src | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xbps-src b/xbps-src
index 1c83708c8da..819aa106e9e 100755
--- a/xbps-src
+++ b/xbps-src
@@ -217,7 +217,8 @@ $(print_cross_targets)
 -t  Create a temporary masterdir to not pollute the current one. Note that
     the existing masterdir must be fully populated with binary-bootstrap first.
     Once the target has finished, this temporary masterdir will be removed.
-    This flag requires xbps-uchroot(1).
+    This flag requires xbps-uchroot(1), and won't work on filesystems that don't
+    support overlayfs.
 
 -V  Print version of xbps, then exit.
 

Re: xbps-src: expand note about -t flag.

[q66]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686634701

Comment:
the wording makes it sound like they are two separate things, i'd reword it it a bit, something like "This flag requires xbps-uchroot(1), so it won't work..."

Re: xbps-src: expand note about -t flag.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686636092

Comment:
I'm not sure it's fully related... If you set `XBPS_CHROOT_CMD=uchroot` in `etc/conf`, things still work just fine, unless you also add `-t` to the `xbps-src` command line.

Re: xbps-src: expand note about -t flag.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686636092

Comment:
I'm not sure it's fully related... If you set `XBPS_CHROOT_CMD=uchroot` in `etc/conf`, things still work just fine, unless you also add `-t` to the `xbps-src` command line. So it's not because you're using `xbps-uchroot`, it's because you're using overlayfs.

Re: xbps-src: expand note about -t flag.

[q66]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/24643#issuecomment-686639228

Comment:
hm, you're right i guess...

Re: [PR PATCH] [Merged]: xbps-src: expand note about -t flag.

[q66]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: expand note about -t flag.
https://github.com/void-linux/void-packages/pull/24643

Description:
Related to #24314