* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
@ 2020-08-21 12:02 ` sgn
2020-08-21 12:11 ` motorto
` (16 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: sgn @ 2020-08-21 12:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474653355
Comment:
```
makedepends="libebur128-devel ffmpeg-devel taglib-devel"
```
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
2020-08-21 12:02 ` [PR REVIEW] " sgn
@ 2020-08-21 12:11 ` motorto
2020-08-21 12:13 ` ericonr
` (15 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-21 12:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New review comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474657367
Comment:
Simply replacing hostmakedepends into makedepends does the trick . Or what you are saying is that that's the only packages needed and the rest is redundant
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
2020-08-21 12:02 ` [PR REVIEW] " sgn
2020-08-21 12:11 ` motorto
@ 2020-08-21 12:13 ` ericonr
2020-08-21 12:30 ` motorto
` (14 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: ericonr @ 2020-08-21 12:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474658344
Comment:
Yes, the rest is redundant. For example, `libavcodec` is a dependency of `ffmpeg-devel`.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (2 preceding siblings ...)
2020-08-21 12:13 ` ericonr
@ 2020-08-21 12:30 ` motorto
2020-08-21 12:32 ` motorto
` (13 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-21 12:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
New review comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474666420
Comment:
You sure ? Adding this:
```suggestion
makedepends="libebur128-devel ffmpeg-devel taglib-devel"
```
And then xbps-src package:
> => loudgain-0.6.8_1: running do_configure ...
-- Checking for module 'libavcodec'
--
CMake Error at /usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:497 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:681 (_pkg_check_modules_internal)
CMakeLists.txt:27 (PKG_CHECK_MODULES)
-- Configuring incomplete, errors occurred!
See also "/builddir/loudgain-0.6.8/build/CMakeFiles/CMakeOutput.log".
=> ERROR: loudgain-0.6.8_1: do_configure: 'CFLAGS="${CFLAGS/ -pipe / }" CXXFLAGS="${CXXFLAGS/ -p's|[^/]*||g' -e 's|/|../|g')' exited with 1
=> ERROR: in do_configure() at `common/build-style/cmake.sh:62
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (3 preceding siblings ...)
2020-08-21 12:30 ` motorto
@ 2020-08-21 12:32 ` motorto
2020-08-21 12:37 ` [PR PATCH] [Updated] " motorto
` (12 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-21 12:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]
New review comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474666420
Comment:
You sure ? Adding this:
```suggestion
makedepends="libebur128-devel ffmpeg-devel taglib-devel"
```
And then xbps-src package:
> => loudgain-0.6.8_1: running do_configure ...
-- Checking for module 'libavcodec'
--
CMake Error at /usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:497 (message):
A required package was not found
Call Stack (most recent call first):
/usr/share/cmake-3.17/Modules/FindPkgConfig.cmake:681 (_pkg_check_modules_internal)
CMakeLists.txt:27 (PKG_CHECK_MODULES)
-- Configuring incomplete, errors occurred!
See also "/builddir/loudgain-0.6.8/build/CMakeFiles/CMakeOutput.log".
=> ERROR: loudgain-0.6.8_1: do_configure: 'CFLAGS="${CFLAGS/ -pipe / }" CXXFLAGS="${CXXFLAGS/ -p's|[^/]*||g' -e 's|/|../|g')' exited with 1
=> ERROR: in do_configure() at `common/build-style/cmake.sh:62
EDIT:
```suggestion
makedepends="libebur128-devel ffmpeg-devel taglib-devel libavcodec pkg-config"
```
This makes it work
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (4 preceding siblings ...)
2020-08-21 12:32 ` motorto
@ 2020-08-21 12:37 ` motorto
2020-08-21 15:32 ` [PR REVIEW] " sgn
` (11 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-21 12:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
There is an updated pull request by motorto against master on the void-packages repository
https://github.com/motorto/void-packages loudagaing
https://github.com/void-linux/void-packages/pull/24400
New package: loudgain-0.6.8
Asked on #23054
A patch file from https://github.com/void-linux/void-packages/pull/24400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-loudagaing-24400.patch --]
[-- Type: text/x-diff, Size: 1194 bytes --]
From aee29eaaff2cf5724a230858a437b7909e2d44ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Wed, 5 Aug 2020 20:23:52 +0100
Subject: [PATCH] New package: loudgain-0.6.8
---
srcpkgs/loudgain/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/loudgain/template
diff --git a/srcpkgs/loudgain/template b/srcpkgs/loudgain/template
new file mode 100644
index 00000000000..67b4792c7b1
--- /dev/null
+++ b/srcpkgs/loudgain/template
@@ -0,0 +1,21 @@
+# Template file for 'loudgain'
+pkgname=loudgain
+version=0.6.8
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="libebur128-devel ffmpeg-devel taglib-devel pkg-config"
+short_desc="Versatile ReplayGain 2.0 loudness normalizer,EBU R128/ITU BS.1770"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/Moonbase59/loudgain"
+distfiles="https://github.com/Moonbase59/loudgain/archive/v${version}.tar.gz"
+checksum=1137c193ad941b366e87c5d84ccc95a7aa8571affc060db0bd1cf72c489aeaee
+
+pre_build() {
+ mkdir -p build && cd build
+}
+
+post_install() {
+ vlicense COPYING
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (5 preceding siblings ...)
2020-08-21 12:37 ` [PR PATCH] [Updated] " motorto
@ 2020-08-21 15:32 ` sgn
2020-08-21 15:42 ` motorto
` (10 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: sgn @ 2020-08-21 15:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474772809
Comment:
`pkg-config` should be in `hostmakedepends`. Please go back read Manual
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (6 preceding siblings ...)
2020-08-21 15:32 ` [PR REVIEW] " sgn
@ 2020-08-21 15:42 ` motorto
2020-08-31 14:52 ` Duncaen
` (9 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-21 15:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
New review comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r474778736
Comment:
I had read the manual , but I will definitely read this time with more attention.Really appreciate your help !
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (7 preceding siblings ...)
2020-08-21 15:42 ` motorto
@ 2020-08-31 14:52 ` Duncaen
2020-08-31 16:03 ` [PR PATCH] [Updated] " motorto
` (8 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Duncaen @ 2020-08-31 14:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r480183903
Comment:
`pkg-config` should only be in `hostmakedepends`
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (8 preceding siblings ...)
2020-08-31 14:52 ` Duncaen
@ 2020-08-31 16:03 ` motorto
2020-08-31 16:03 ` [PR REVIEW] " motorto
` (7 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-31 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
There is an updated pull request by motorto against master on the void-packages repository
https://github.com/motorto/void-packages loudagaing
https://github.com/void-linux/void-packages/pull/24400
New package: loudgain-0.6.8
Asked on #23054
A patch file from https://github.com/void-linux/void-packages/pull/24400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-loudagaing-24400.patch --]
[-- Type: text/x-diff, Size: 1183 bytes --]
From c14be1d00efa7675e345f853908be764d3d761fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Wed, 5 Aug 2020 20:23:52 +0100
Subject: [PATCH] New package: loudgain-0.6.8
---
srcpkgs/loudgain/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/loudgain/template
diff --git a/srcpkgs/loudgain/template b/srcpkgs/loudgain/template
new file mode 100644
index 00000000000..842d1cff2fc
--- /dev/null
+++ b/srcpkgs/loudgain/template
@@ -0,0 +1,21 @@
+# Template file for 'loudgain'
+pkgname=loudgain
+version=0.6.8
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="libebur128-devel ffmpeg-devel taglib-devel"
+short_desc="Versatile ReplayGain 2.0 loudness normalizer,EBU R128/ITU BS.1770"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/Moonbase59/loudgain"
+distfiles="https://github.com/Moonbase59/loudgain/archive/v${version}.tar.gz"
+checksum=1137c193ad941b366e87c5d84ccc95a7aa8571affc060db0bd1cf72c489aeaee
+
+pre_build() {
+ mkdir -p build && cd build
+}
+
+post_install() {
+ vlicense COPYING
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (9 preceding siblings ...)
2020-08-31 16:03 ` [PR PATCH] [Updated] " motorto
@ 2020-08-31 16:03 ` motorto
2020-09-04 20:10 ` motorto
` (6 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-08-31 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New review comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r480230801
Comment:
Thanks , don't know how I missed that , just fixed it !
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (10 preceding siblings ...)
2020-08-31 16:03 ` [PR REVIEW] " motorto
@ 2020-09-04 20:10 ` motorto
2020-09-04 20:11 ` motorto
` (5 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-09-04 20:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 208 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#issuecomment-687357811
Comment:
Hey @duncaen could you re review it again and if it ready push it ?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (11 preceding siblings ...)
2020-09-04 20:10 ` motorto
@ 2020-09-04 20:11 ` motorto
2020-09-04 20:21 ` [PR REVIEW] " Duncaen
` (4 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-09-04 20:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#issuecomment-687357811
Comment:
Hey @duncaen could you re review it again and if it ready ~push~ accept it ?
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR REVIEW] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (12 preceding siblings ...)
2020-09-04 20:11 ` motorto
@ 2020-09-04 20:21 ` Duncaen
2020-09-04 22:29 ` [PR PATCH] [Updated] " motorto
` (3 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: Duncaen @ 2020-09-04 20:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
New review comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#discussion_r483828804
Comment:
This shouldn't be necessary, the cmake build_style already sets up the build directory at configure time before pre_build.
https://github.com/void-linux/void-packages/blob/master/common/build-style/cmake.sh#L6
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Updated] New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (13 preceding siblings ...)
2020-09-04 20:21 ` [PR REVIEW] " Duncaen
@ 2020-09-04 22:29 ` motorto
2020-09-04 22:31 ` motorto
` (2 subsequent siblings)
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-09-04 22:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
There is an updated pull request by motorto against master on the void-packages repository
https://github.com/motorto/void-packages loudagaing
https://github.com/void-linux/void-packages/pull/24400
New package: loudgain-0.6.8
Asked on #23054
A patch file from https://github.com/void-linux/void-packages/pull/24400.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-loudagaing-24400.patch --]
[-- Type: text/x-diff, Size: 1130 bytes --]
From 6bb9ae9bc2e30cdc6263028dc129d648a5a27d3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Wed, 5 Aug 2020 20:23:52 +0100
Subject: [PATCH] New package: loudgain-0.6.8
---
srcpkgs/loudgain/template | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
create mode 100644 srcpkgs/loudgain/template
diff --git a/srcpkgs/loudgain/template b/srcpkgs/loudgain/template
new file mode 100644
index 00000000000..49afa564e99
--- /dev/null
+++ b/srcpkgs/loudgain/template
@@ -0,0 +1,17 @@
+# Template file for 'loudgain'
+pkgname=loudgain
+version=0.6.8
+revision=1
+build_style=cmake
+hostmakedepends="pkg-config"
+makedepends="libebur128-devel ffmpeg-devel taglib-devel"
+short_desc="Versatile ReplayGain 2.0 loudness normalizer,EBU R128/ITU BS.1770"
+maintainer="André Cerqueira <acerqueira021@gmail.com>"
+license="BSD-2-Clause"
+homepage="https://github.com/Moonbase59/loudgain"
+distfiles="https://github.com/Moonbase59/loudgain/archive/v${version}.tar.gz"
+checksum=1137c193ad941b366e87c5d84ccc95a7aa8571affc060db0bd1cf72c489aeaee
+
+post_install() {
+ vlicense COPYING
+}
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (14 preceding siblings ...)
2020-09-04 22:29 ` [PR PATCH] [Updated] " motorto
@ 2020-09-04 22:31 ` motorto
2020-11-22 5:06 ` the-maldridge
2020-11-22 5:06 ` [PR PATCH] [Closed]: " the-maldridge
17 siblings, 0 replies; 20+ messages in thread
From: motorto @ 2020-09-04 22:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#issuecomment-687435003
Comment:
Thanks for the insight wasn't aware of that. @Duncaen
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (15 preceding siblings ...)
2020-09-04 22:31 ` motorto
@ 2020-11-22 5:06 ` the-maldridge
2020-11-22 5:06 ` [PR PATCH] [Closed]: " the-maldridge
17 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2020-11-22 5:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/24400#issuecomment-731699121
Comment:
Closed by b766fcd215
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PR PATCH] [Closed]: New package: loudgain-0.6.8
2020-08-21 10:04 [PR PATCH] New package: loudgain-0.6.8 motorto
` (16 preceding siblings ...)
2020-11-22 5:06 ` the-maldridge
@ 2020-11-22 5:06 ` the-maldridge
17 siblings, 0 replies; 20+ messages in thread
From: the-maldridge @ 2020-11-22 5:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
There's a closed pull request on the void-packages repository
New package: loudgain-0.6.8
https://github.com/void-linux/void-packages/pull/24400
Description:
Asked on #23054
^ permalink raw reply [flat|nested] 20+ messages in thread