* [PR PATCH] wtplan: fix cross, enable pie
@ 2020-09-09 1:10 sgn
2020-09-09 1:55 ` [PR REVIEW] " ericonr
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: sgn @ 2020-09-09 1:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
There is a new pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages fix-cross-wtplan
https://github.com/void-linux/void-packages/pull/24772
wtplan: fix cross, enable pie
Tested with x86_64-musl and aarch64-musl.
@Vaelatern
A patch file from https://github.com/void-linux/void-packages/pull/24772.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-cross-wtplan-24772.patch --]
[-- Type: text/x-diff, Size: 1517 bytes --]
From 7cd8e1ccd9e2a58ca978539ab68d8f2ad3dff7ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Wed, 9 Sep 2020 08:00:02 +0700
Subject: [PATCH] wtplan: fix cross, enable pie
---
srcpkgs/wtplan/template | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/wtplan/template b/srcpkgs/wtplan/template
index 904ab772db7..9bf0b38b4f2 100644
--- a/srcpkgs/wtplan/template
+++ b/srcpkgs/wtplan/template
@@ -1,12 +1,9 @@
# Template file for 'wtplan'
pkgname=wtplan
version=0.1
-revision=1
-nocross="runtime/cgo: armv7l-linux-musleabihf-gcc: error: unrecognized command line option '-m64"
+revision=2
build_style=gnu-makefile
hostmakedepends="go"
-nopie="golang"
-nostrip="golang"
short_desc="Calendar program with terminal and web interfaces and git integration"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="MIT"
@@ -14,6 +11,18 @@ homepage="https://github.com/kjellwinblad/wtplan/"
distfiles="https://github.com/kjellwinblad/wtplan/archive/${version}.tar.gz"
checksum=31c66181f815889828eb2bd3739d6b23582ec75a5a8d6c6bf76c2a6679112bb4
+do_build() {
+ export GOPATH=$(pwd)
+ export VERSIONSTR=$version
+ go generate wtplan
+ go generate wtplan-web
+ . $XBPS_COMMONDIR/environment/build-style/go.sh
+ GOPATH=$(pwd)
+ # Without -buildmode=pie, build failure on armv6hf-musl
+ go build -buildmode=pie wtplan
+ go build -buildmode=pie wtplan-web
+}
+
post_install() {
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] wtplan: fix cross, enable pie
2020-09-09 1:10 [PR PATCH] wtplan: fix cross, enable pie sgn
@ 2020-09-09 1:55 ` ericonr
2020-09-09 11:46 ` sgn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2020-09-09 1:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/24772#discussion_r485291437
Comment:
Could we consider adding these flags to the go build style?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR REVIEW] wtplan: fix cross, enable pie
2020-09-09 1:10 [PR PATCH] wtplan: fix cross, enable pie sgn
2020-09-09 1:55 ` [PR REVIEW] " ericonr
@ 2020-09-09 11:46 ` sgn
2020-09-09 11:47 ` [PR PATCH] [Updated] " sgn
2020-09-11 12:29 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-09-09 11:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/24772#discussion_r485547127
Comment:
Looks like a yes, all architecture that our go supports also has `-buildmode=pie` on.
I'll look into drafting a change.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] wtplan: fix cross, enable pie
2020-09-09 1:10 [PR PATCH] wtplan: fix cross, enable pie sgn
2020-09-09 1:55 ` [PR REVIEW] " ericonr
2020-09-09 11:46 ` sgn
@ 2020-09-09 11:47 ` sgn
2020-09-11 12:29 ` [PR PATCH] [Merged]: " sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-09-09 11:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/sgn/void-packages fix-cross-wtplan
https://github.com/void-linux/void-packages/pull/24772
wtplan: fix cross, enable pie
Tested with x86_64-musl and aarch64-musl.
@Vaelatern
A patch file from https://github.com/void-linux/void-packages/pull/24772.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-cross-wtplan-24772.patch --]
[-- Type: text/x-diff, Size: 1571 bytes --]
From 588293b125089855eb11eb10b0e3b7dc4fdb8c60 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<congdanhqx@gmail.com>
Date: Wed, 9 Sep 2020 08:00:02 +0700
Subject: [PATCH] wtplan: fix cross, enable pie
---
srcpkgs/wtplan/template | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/wtplan/template b/srcpkgs/wtplan/template
index 904ab772db7..5a5b3a54740 100644
--- a/srcpkgs/wtplan/template
+++ b/srcpkgs/wtplan/template
@@ -1,12 +1,10 @@
# Template file for 'wtplan'
pkgname=wtplan
version=0.1
-revision=1
-nocross="runtime/cgo: armv7l-linux-musleabihf-gcc: error: unrecognized command line option '-m64"
+revision=2
+archs="aarch64* armv[567]* i686* x86_64* ppc64le*"
build_style=gnu-makefile
hostmakedepends="go"
-nopie="golang"
-nostrip="golang"
short_desc="Calendar program with terminal and web interfaces and git integration"
maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
license="MIT"
@@ -14,6 +12,18 @@ homepage="https://github.com/kjellwinblad/wtplan/"
distfiles="https://github.com/kjellwinblad/wtplan/archive/${version}.tar.gz"
checksum=31c66181f815889828eb2bd3739d6b23582ec75a5a8d6c6bf76c2a6679112bb4
+do_build() {
+ export GOPATH=$(pwd)
+ export VERSIONSTR=$version
+ go generate wtplan
+ go generate wtplan-web
+ . $XBPS_COMMONDIR/environment/build-style/go.sh
+ GOPATH=$(pwd)
+ # Without -buildmode=pie, build failure on armv6hf-musl
+ go build -buildmode=pie wtplan
+ go build -buildmode=pie wtplan-web
+}
+
post_install() {
vlicense LICENSE
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: wtplan: fix cross, enable pie
2020-09-09 1:10 [PR PATCH] wtplan: fix cross, enable pie sgn
` (2 preceding siblings ...)
2020-09-09 11:47 ` [PR PATCH] [Updated] " sgn
@ 2020-09-11 12:29 ` sgn
3 siblings, 0 replies; 5+ messages in thread
From: sgn @ 2020-09-11 12:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
There's a merged pull request on the void-packages repository
wtplan: fix cross, enable pie
https://github.com/void-linux/void-packages/pull/24772
Description:
Tested with x86_64-musl and aarch64-musl.
@Vaelatern
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-11 12:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 1:10 [PR PATCH] wtplan: fix cross, enable pie sgn
2020-09-09 1:55 ` [PR REVIEW] " ericonr
2020-09-09 11:46 ` sgn
2020-09-09 11:47 ` [PR PATCH] [Updated] " sgn
2020-09-11 12:29 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).