[PR PATCH] vopt_bool: use option as default property

[PR PATCH] vopt_bool: use option as default property

[sgn]

[-- Attachment #1: Type: text/plain, Size: 384 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages vopt-bool-default-property
https://github.com/void-linux/void-packages/pull/24967

vopt_bool: use option as default property
Keep it in-line with vopt_with and vopt_enable.

A patch file from https://github.com/void-linux/void-packages/pull/24967.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vopt-bool-default-property-24967.patch --]
[-- Type: text/x-diff, Size: 1044 bytes --]

From 9b7485671dcfbecb277b658c874d7c94b2a513b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Fri, 18 Sep 2020 20:00:47 +0700
Subject: [PATCH] vopt_bool: use option as default property

Keep it in-line with vopt_with and vopt_enable.
---
 common/environment/setup/options.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/common/environment/setup/options.sh b/common/environment/setup/options.sh
index 948de79a9e1..83e0f9420f9 100644
--- a/common/environment/setup/options.sh
+++ b/common/environment/setup/options.sh
@@ -30,10 +30,8 @@ vopt_conflict() {
 }
 
 vopt_bool() {
-    local opt="$1" prop="$2"
-    if [ "$#" -lt "2" ]; then
-        msg_error "vopt_bool <build_option> <property>: missing values\n"
-    elif [ "$#" -gt "2" ]; then
+    local opt="$1" prop="${2:-$1}"
+    if [ "$#" -gt "2" ]; then
         msg_error "vopt_bool $opt: $(($# - 2)) excess parameter(s)\n"
     fi
     vopt_if "$1" "-D${prop}=true" "-D${prop}=false"

Re: [PR PATCH] [Merged]: vopt_bool: use option as default property

[q66]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

There's a merged pull request on the void-packages repository

vopt_bool: use option as default property
https://github.com/void-linux/void-packages/pull/24967

Description:
Keep it in-line with vopt_with and vopt_enable.