Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: imwheel
@ 2020-09-20  9:54 manfredu
  2020-09-20  9:57 ` [PR REVIEW] " pullmoll
                   ` (31 more replies)
  0 siblings, 32 replies; 33+ messages in thread
From: manfredu @ 2020-09-20  9:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

There is a new pull request by manfredu against master on the void-packages repository

https://github.com/manfredu/void-packages imwheel
https://github.com/void-linux/void-packages/pull/24991

New package: imwheel


A patch file from https://github.com/void-linux/void-packages/pull/24991.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imwheel-24991.patch --]
[-- Type: text/x-diff, Size: 1137 bytes --]

From 06819b3318eb2b5ebdc21aba54a08f060e9c2221 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 20 Sep 2020 11:36:43 +0200
Subject: [PATCH] New package: imwheel

---
 srcpkgs/imwheel/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/imwheel/template

diff --git a/srcpkgs/imwheel/template b/srcpkgs/imwheel/template
new file mode 100644
index 00000000000..d77c32201a1
--- /dev/null
+++ b/srcpkgs/imwheel/template
@@ -0,0 +1,13 @@
+# Template file for 'imwheel'
+pkgname=imwheel
+version=1.0.0pre12
+revision=1
+build_style=gnu-configure
+hostmakedepends="pkg-config libXmu libXext libXtst"
+makedepends="libX11-devel libXtst-devel libXmu-devel"
+short_desc="A universal mouse wheel and mouse stick translator for the X Windows System."
+maintainer="ManfredU <mu@usselmann.it>"
+homepage="http://imwheel.sourceforge.net/"
+license="GPL-2.0-only"
+distfiles="https://sourceforge.net/projects/${pkgname}/files/${pkgname}-source/${version}/${pkgname}-${version}.tar.gz"
+checksum=2320ed019c95ca4d922968e1e1cbf0c075a914e865e3965d2bd694ca3d57cfe3
\ No newline at end of file

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
@ 2020-09-20  9:57 ` pullmoll
  2020-09-20  9:59 ` pullmoll
                   ` (30 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20  9:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491674930

Comment:
s/A universal/Universal/

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
  2020-09-20  9:57 ` [PR REVIEW] " pullmoll
@ 2020-09-20  9:59 ` pullmoll
  2020-09-20 10:00 ` pullmoll
                   ` (29 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20  9:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491675092

Comment:
Should probably be `1.0.0` and `pre12` appended where necessary, i.e. `wrksrc="${pkgname}-${version}pre12` and `distfiles="…${version}pre12.tar.gz`.
Otherwise the final `1.0.0` will be **smaller than** 1.0.0pre12 version wise and you'd have to add a `reverts=…`.
BTW Is there a reason not to wait for the stable release?


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
  2020-09-20  9:57 ` [PR REVIEW] " pullmoll
  2020-09-20  9:59 ` pullmoll
@ 2020-09-20 10:00 ` pullmoll
  2020-09-20 10:25 ` manfredu
                   ` (28 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 10:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491675092

Comment:
Should probably be `1.0.0` and `pre12` appended where necessary, i.e. `wrksrc="${pkgname}-${version}pre12` and `distfiles="…${version}pre12.tar.gz`.
Otherwise the final `1.0.0` will be **smaller than** `1.0.0pre12` version wise and you'd have to add a `reverts=…`.
BTW Is there a reason not to wait for the stable release?


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (2 preceding siblings ...)
  2020-09-20 10:00 ` pullmoll
@ 2020-09-20 10:25 ` manfredu
  2020-09-20 11:00 ` manfredu
                   ` (27 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 10:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New review comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491677061

Comment:
Thanks for reviewing. 

If I change it like this I get 
=> ERROR: imwheel-1.0.0_1: cannot access wrksrc directory [/builddir/imwheel-1.0.0]
because /builddir/imwheel-1.0.0/imwheel-1.0.0pre12 is created.

This is the latest version available since years and also provided by other distributions. See e.g. https://www.archlinux.org/packages/community/x86_64/imwheel/


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (3 preceding siblings ...)
  2020-09-20 10:25 ` manfredu
@ 2020-09-20 11:00 ` manfredu
  2020-09-20 12:06 ` pullmoll
                   ` (26 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 11:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New review comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491677061

Comment:
Thanks for reviewing. 

If I change it like this I get 
=> ERROR: imwheel-1.0.0_1: cannot access wrksrc directory [/builddir/imwheel-1.0.0]
because /builddir/imwheel-1.0.0pre12 is created.

This is the latest version available since years and also provided by other distributions. See e.g. https://www.archlinux.org/packages/community/x86_64/imwheel/


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (4 preceding siblings ...)
  2020-09-20 11:00 ` manfredu
@ 2020-09-20 12:06 ` pullmoll
  2020-09-20 12:06 ` pullmoll
                   ` (25 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491685066

Comment:
That's why I set to add `wrksrc="${pkgname}-${version}pre12"` after the line `revision=1`.
Ok, so there will probably be no 1.0.0 in the forseeable future. Still, I'd go with the `pre12` separated out.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (5 preceding siblings ...)
  2020-09-20 12:06 ` pullmoll
@ 2020-09-20 12:06 ` pullmoll
  2020-09-20 12:07 ` pullmoll
                   ` (24 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 12:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491685066

Comment:
That's why I suggested to add `wrksrc="${pkgname}-${version}pre12"` after the line `revision=1`.
Ok, so there will probably be no 1.0.0 in the forseeable future. Still, I'd go with the `pre12` separated out.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (6 preceding siblings ...)
  2020-09-20 12:06 ` pullmoll
@ 2020-09-20 12:07 ` pullmoll
  2020-09-20 12:27 ` manfredu
                   ` (23 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 12:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491685148

Comment:
If you install `xtools` you can `xlint srcpkgs/imwheel/template` locally to see what's missing or wrong.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (7 preceding siblings ...)
  2020-09-20 12:07 ` pullmoll
@ 2020-09-20 12:27 ` manfredu
  2020-09-20 12:27 ` manfredu
                   ` (22 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 12:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New review comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491686754

Comment:
> That's why I suggested to add `wrksrc="${pkgname}-${version}pre12"` after the line `revision=1`.
Ah, I missed this one.



^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (8 preceding siblings ...)
  2020-09-20 12:27 ` manfredu
@ 2020-09-20 12:27 ` manfredu
  2020-09-20 12:30 ` [PR PATCH] [Updated] " manfredu
                   ` (21 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 12:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New review comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491686754

Comment:
> That's why I suggested to add `wrksrc="${pkgname}-${version}pre12"` after the line `revision=1`.

Ah, I missed this one.



^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Updated] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (9 preceding siblings ...)
  2020-09-20 12:27 ` manfredu
@ 2020-09-20 12:30 ` manfredu
  2020-09-20 12:32 ` [PR REVIEW] " pullmoll
                   ` (20 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 12:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

There is an updated pull request by manfredu against master on the void-packages repository

https://github.com/manfredu/void-packages imwheel
https://github.com/void-linux/void-packages/pull/24991

New package: imwheel


A patch file from https://github.com/void-linux/void-packages/pull/24991.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imwheel-24991.patch --]
[-- Type: text/x-diff, Size: 1149 bytes --]

From 5ebea13d2ab3711c878496ee3038fd60e382ef3f Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 20 Sep 2020 11:36:43 +0200
Subject: [PATCH] New package: imwheel

---
 srcpkgs/imwheel/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/imwheel/template

diff --git a/srcpkgs/imwheel/template b/srcpkgs/imwheel/template
new file mode 100644
index 00000000000..3a9583751e7
--- /dev/null
+++ b/srcpkgs/imwheel/template
@@ -0,0 +1,14 @@
+# Template file for 'imwheel'
+pkgname=imwheel
+version=1.0.0
+revision=1
+wrksrc="${pkgname}-${version}pre12"
+build_style=gnu-configure
+hostmakedepends="pkg-config libXmu libXext libXtst"
+makedepends="libX11-devel libXtst-devel libXmu-devel"
+short_desc="Universal mouse wheel and mouse stick translator for the X Windows System"
+maintainer="ManfredU <mu@usselmann.it>"
+license="GPL-2.0-only"
+homepage="http://imwheel.sourceforge.net/"
+distfiles="https://sourceforge.net/projects/${pkgname}/files/${pkgname}-source/${version}pre12/${pkgname}-${version}pre12.tar.gz"
+checksum=2320ed019c95ca4d922968e1e1cbf0c075a914e865e3965d2bd694ca3d57cfe3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (10 preceding siblings ...)
  2020-09-20 12:30 ` [PR PATCH] [Updated] " manfredu
@ 2020-09-20 12:32 ` pullmoll
  2020-09-20 13:08 ` [PR PATCH] [Updated] " manfredu
                   ` (19 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 12:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491687232

Comment:
Suggest `short_desc="Universial mouse wheel and stick translator for X11"`. That should be < 76 characters.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Updated] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (11 preceding siblings ...)
  2020-09-20 12:32 ` [PR REVIEW] " pullmoll
@ 2020-09-20 13:08 ` manfredu
  2020-09-20 13:10 ` [PR REVIEW] " manfredu
                   ` (18 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 13:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

There is an updated pull request by manfredu against master on the void-packages repository

https://github.com/manfredu/void-packages imwheel
https://github.com/void-linux/void-packages/pull/24991

New package: imwheel


A patch file from https://github.com/void-linux/void-packages/pull/24991.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imwheel-24991.patch --]
[-- Type: text/x-diff, Size: 1127 bytes --]

From 62827e001c0a4b7a81a1d1d98f37967724ec9d27 Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 20 Sep 2020 11:36:43 +0200
Subject: [PATCH] New package: imwheel

---
 srcpkgs/imwheel/template | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 srcpkgs/imwheel/template

diff --git a/srcpkgs/imwheel/template b/srcpkgs/imwheel/template
new file mode 100644
index 00000000000..562c2246d60
--- /dev/null
+++ b/srcpkgs/imwheel/template
@@ -0,0 +1,14 @@
+# Template file for 'imwheel'
+pkgname=imwheel
+version=1.0.0
+revision=1
+wrksrc="${pkgname}-${version}pre12"
+build_style=gnu-configure
+hostmakedepends="pkg-config libXmu libXext libXtst"
+makedepends="libX11-devel libXtst-devel libXmu-devel"
+short_desc="Universial mouse wheel and stick translator for X11"
+maintainer="ManfredU <mu@usselmann.it>"
+license="GPL-2.0-only"
+homepage="http://imwheel.sourceforge.net/"
+distfiles="https://sourceforge.net/projects/${pkgname}/files/${pkgname}-source/${version}pre12/${pkgname}-${version}pre12.tar.gz"
+checksum=2320ed019c95ca4d922968e1e1cbf0c075a914e865e3965d2bd694ca3d57cfe3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (12 preceding siblings ...)
  2020-09-20 13:08 ` [PR PATCH] [Updated] " manfredu
@ 2020-09-20 13:10 ` manfredu
  2020-09-20 13:52 ` pullmoll
                   ` (17 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 13:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491690262

Comment:
> Suggest `short_desc="Universial mouse wheel and stick translator for X11"`. That should be < 76 characters.

OK, changed

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (13 preceding siblings ...)
  2020-09-20 13:10 ` [PR REVIEW] " manfredu
@ 2020-09-20 13:52 ` pullmoll
  2020-09-20 13:53 ` pullmoll
                   ` (16 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 13:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695789751

Comment:
So cross needs some massaging, see: https://travis-ci.org/github/void-linux/void-packages/jobs/728735611#L643

Either try if rebuilding the configure helps:
Add automake and libtool to hostmakedepends.
Add `pre_configure() { autoreconf -fi }` function (with line breaks :)

Alternatively find out which variable configure expects to be defined to avoid testing for the existence of `gpm.c`. Perhaps there is a `--with-gpm` configure option. Add that variable to `configure_args="…"`.

If you cannot get it working add `nocross="Needs more work"` or similar.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (14 preceding siblings ...)
  2020-09-20 13:52 ` pullmoll
@ 2020-09-20 13:53 ` pullmoll
  2020-09-20 13:55 ` pullmoll
                   ` (15 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 13:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695789751

Comment:
So cross needs some massaging, see: https://travis-ci.org/github/void-linux/void-packages/jobs/728735611#L643

Either try if rebuilding the configure helps:
Add automake and libtool to hostmakedepends.
Add `pre_configure() { autoreconf -fi }` function (with line breaks :)

Alternatively find out which variable configure expects to be defined to avoid testing for the existence of `gpm.c`. Perhaps there is a `--with-gpm` configure option. Add that variable to `configure_args="…"`.

Actually it may be `--disable-gpm` since you do not have `gpm-devel` in `makedepends`.

If you cannot get it working add `nocross="Needs more work"` or similar.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (15 preceding siblings ...)
  2020-09-20 13:53 ` pullmoll
@ 2020-09-20 13:55 ` pullmoll
  2020-09-20 14:11 ` pullmoll
                   ` (14 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 13:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695789751

Comment:
So cross needs some massaging, see: https://travis-ci.org/github/void-linux/void-packages/jobs/728735611#L643

Either try if rebuilding the configure helps:
Add automake and libtool to hostmakedepends.
Add `pre_configure() { autoreconf -fi }` function (with line breaks :)

Alternatively find out which variable configure expects to be defined to avoid testing for the existence of `gpm.c`. Perhaps there is a `--with-gpm` configure option. Add that variable (`ac_cv_something=no`) or option to `configure_args="…"`.

Actually it may be `--disable-gpm` since you do not have `gpm-devel` in `makedepends`.

If you cannot get it working add `nocross="Needs more work"` or similar.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (16 preceding siblings ...)
  2020-09-20 13:55 ` pullmoll
@ 2020-09-20 14:11 ` pullmoll
  2020-09-20 14:23 ` manfredu
                   ` (13 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 14:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695791713

Comment:
Oh and BTW the commit message should read: `New package: imwheel-1.0.0` i.e. include the version for a new package.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (17 preceding siblings ...)
  2020-09-20 14:11 ` pullmoll
@ 2020-09-20 14:23 ` manfredu
  2020-09-20 14:50 ` [PR PATCH] [Updated] " manfredu
                   ` (12 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 14:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695793081

Comment:
Thanks for all your help. I will try to fix the cross compile issue.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Updated] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (18 preceding siblings ...)
  2020-09-20 14:23 ` manfredu
@ 2020-09-20 14:50 ` manfredu
  2020-09-20 14:52 ` manfredu
                   ` (11 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 312 bytes --]

There is an updated pull request by manfredu against master on the void-packages repository

https://github.com/manfredu/void-packages imwheel
https://github.com/void-linux/void-packages/pull/24991

New package: imwheel


A patch file from https://github.com/void-linux/void-packages/pull/24991.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-imwheel-24991.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 0cf03c6a10a2194c3daa5b51524e15923825ffeb Mon Sep 17 00:00:00 2001
From: Manfred Usselmann <mu@usselmann.it>
Date: Sun, 20 Sep 2020 11:36:43 +0200
Subject: [PATCH] New package: imwheel-1.0.0

---
 srcpkgs/imwheel/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/imwheel/template

diff --git a/srcpkgs/imwheel/template b/srcpkgs/imwheel/template
new file mode 100644
index 00000000000..1f9f52c5948
--- /dev/null
+++ b/srcpkgs/imwheel/template
@@ -0,0 +1,17 @@
+# Template file for 'imwheel'
+pkgname=imwheel
+version=1.0.0
+revision=1
+wrksrc="${pkgname}-${version}pre12"
+build_style=gnu-configure
+hostmakedepends="pkg-config libXmu libXext libXtst automake libtool"
+makedepends="libX11-devel libXtst-devel libXmu-devel"
+short_desc="Universial mouse wheel and stick translator for X11"
+pre_configure() {
+	autoreconf -fi
+}
+maintainer="ManfredU <mu@usselmann.it>"
+license="GPL-2.0-only"
+homepage="http://imwheel.sourceforge.net/"
+distfiles="https://sourceforge.net/projects/${pkgname}/files/${pkgname}-source/${version}pre12/${pkgname}-${version}pre12.tar.gz"
+checksum=2320ed019c95ca4d922968e1e1cbf0c075a914e865e3965d2bd694ca3d57cfe3

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (19 preceding siblings ...)
  2020-09-20 14:50 ` [PR PATCH] [Updated] " manfredu
@ 2020-09-20 14:52 ` manfredu
  2020-09-20 15:04 ` [PR REVIEW] " pullmoll
                   ` (10 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 14:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695796117

Comment:
> Oh and BTW the commit message should read: `New package: imwheel-1.0.0` i.e. include the version for a new package.

Changed

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (20 preceding siblings ...)
  2020-09-20 14:52 ` manfredu
@ 2020-09-20 15:04 ` pullmoll
  2020-09-20 15:04 ` pullmoll
                   ` (9 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700029

Comment:
Remove `libXmu`, `libXext` and `libXtst`. They won't be required in the host (hostmakedepends), but the target (makedepends) where they are dependencies of their `*-devel` packages.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (21 preceding siblings ...)
  2020-09-20 15:04 ` [PR REVIEW] " pullmoll
@ 2020-09-20 15:04 ` pullmoll
  2020-09-20 15:05 ` pullmoll
                   ` (8 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700029

Comment:
Remove `libXmu`, `libXext` and `libXtst`. They won't be required in the host (hostmakedepends), but the target (makedepends) where they are already dependencies of their `*-devel` packages.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (22 preceding siblings ...)
  2020-09-20 15:04 ` pullmoll
@ 2020-09-20 15:05 ` pullmoll
  2020-09-20 15:05 ` pullmoll
                   ` (7 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700138

Comment:
This needs to go to the variable assignments, i.e. the lines after `checksum=`.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (23 preceding siblings ...)
  2020-09-20 15:05 ` pullmoll
@ 2020-09-20 15:05 ` pullmoll
  2020-09-20 15:08 ` pullmoll
                   ` (6 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700138

Comment:
This needs to go after the variable assignments, i.e. the lines after `checksum=`.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (24 preceding siblings ...)
  2020-09-20 15:05 ` pullmoll
@ 2020-09-20 15:08 ` pullmoll
  2020-09-20 15:09 ` pullmoll
                   ` (5 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700138

Comment:
This needs to go after the variable assignments, i.e. the lines after `checksum=`.

But it doesn't help anyway. The configure.in (which should be configure.ac) is old and would need a patch.
This is commonly seen with ancient autoconf stuff. So I'd rather look for a `--with-gpm` or `--without-gpm` or similar configure argument.

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR REVIEW] New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (25 preceding siblings ...)
  2020-09-20 15:08 ` pullmoll
@ 2020-09-20 15:09 ` pullmoll
  2020-09-20 15:19 ` pullmoll
                   ` (4 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

New review comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#discussion_r491700138

Comment:
This needs to go after the variable assignments, i.e. the lines after `checksum=`.

But it doesn't help anyway. The configure.in (which should be configure.ac) is old and would need a patch.
This is commonly seen with ancient autoconf stuff. So I'd rather look for a `--with-gpm` or `--without-gpm` or similar configure argument.

I'll take a look in a bit...

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (26 preceding siblings ...)
  2020-09-20 15:09 ` pullmoll
@ 2020-09-20 15:19 ` pullmoll
  2020-09-20 15:29 ` pullmoll
                   ` (3 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695799019

Comment:
So I merged your PR locally and tried `builddir/imwheel-1.0.0pre12/configure --help`
It lists `--enable-gpm` which means that `--disable-gpm` should disable the check also for cross.
However, it does not disable looking for `gpm.c` so I'm going to try to patch `configure.in` and rip out that entire section for `imwheel-gpm`.


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (27 preceding siblings ...)
  2020-09-20 15:19 ` pullmoll
@ 2020-09-20 15:29 ` pullmoll
  2020-09-20 15:30 ` [PR PATCH] [Closed]: " pullmoll
                   ` (2 subsequent siblings)
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695799019

Comment:
So I merged your PR locally and tried `builddir/imwheel-1.0.0pre12/configure --help`
It lists `--enable-gpm` which means that `--disable-gpm` should disable the check also for cross.
However, it does not disable looking for `gpm.c` so I'm going to try to patch `configure.in` and rip out that entire section for `imwheel-gpm`.
Also `jax/jax.c` needs a patch to not use `(int)` to cast a pointer, but `(intptr_t)` which is in `#include <stdint.h>`.

Long story short: I got it cross building now and will push it with the required patches fixes because I think it would take you a long time to figure the details. I hope this doesn't spoil it for you :)

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: [PR PATCH] [Closed]: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (28 preceding siblings ...)
  2020-09-20 15:29 ` pullmoll
@ 2020-09-20 15:30 ` pullmoll
  2020-09-20 15:59 ` pullmoll
  2020-09-20 16:40 ` manfredu
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

There's a closed pull request on the void-packages repository

New package: imwheel
https://github.com/void-linux/void-packages/pull/24991

Description:


^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (29 preceding siblings ...)
  2020-09-20 15:30 ` [PR PATCH] [Closed]: " pullmoll
@ 2020-09-20 15:59 ` pullmoll
  2020-09-20 16:40 ` manfredu
  31 siblings, 0 replies; 33+ messages in thread
From: pullmoll @ 2020-09-20 15:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

New comment by pullmoll on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695799019

Comment:
So I merged your PR locally and tried `builddir/imwheel-1.0.0pre12/configure --help`
It lists `--enable-gpm` which means that `--disable-gpm` should disable the check also for cross.
However, it does not disable looking for `gpm.c` so I'm going to try to patch `configure.in` and rip out that entire section for `gpm-imwheel`.
Also `jax/jax.c` needs a patch to not use `(int)` to cast a pointer, but `(intptr_t)` which is in `#include <stdint.h>`.

Long story short: I got it cross building now and will push it with the required patches fixes because I think it would take you a long time to figure the details. I hope this doesn't spoil it for you :)

^ permalink raw reply	[flat|nested] 33+ messages in thread

* Re: New package: imwheel
  2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
                   ` (30 preceding siblings ...)
  2020-09-20 15:59 ` pullmoll
@ 2020-09-20 16:40 ` manfredu
  31 siblings, 0 replies; 33+ messages in thread
From: manfredu @ 2020-09-20 16:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

New comment by manfredu on void-packages repository

https://github.com/void-linux/void-packages/pull/24991#issuecomment-695807887

Comment:
> So I merged your PR locally and tried `builddir/imwheel-1.0.0pre12/configure --help`
> It lists `--enable-gpm` which means that `--disable-gpm` should disable the check also for cross.
> However, it does not disable looking for `gpm.c` so I'm going to try to patch `configure.in` and rip out that entire section for `gpm-imwheel`.
> Also `jax/jax.c` needs a patch to not use `(int)` to cast a pointer, but `(intptr_t)` which is in `#include <stdint.h>`.
> 
> Long story short: I got it cross building now and will push it with the required patches fixes because I think it would take you a long time to figure the details. I hope this doesn't spoil it for you :)

Thanks a lot for your help! :-)

^ permalink raw reply	[flat|nested] 33+ messages in thread

end of thread, other threads:[~2020-09-20 16:40 UTC | newest]

Thread overview: 33+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20  9:54 [PR PATCH] New package: imwheel manfredu
2020-09-20  9:57 ` [PR REVIEW] " pullmoll
2020-09-20  9:59 ` pullmoll
2020-09-20 10:00 ` pullmoll
2020-09-20 10:25 ` manfredu
2020-09-20 11:00 ` manfredu
2020-09-20 12:06 ` pullmoll
2020-09-20 12:06 ` pullmoll
2020-09-20 12:07 ` pullmoll
2020-09-20 12:27 ` manfredu
2020-09-20 12:27 ` manfredu
2020-09-20 12:30 ` [PR PATCH] [Updated] " manfredu
2020-09-20 12:32 ` [PR REVIEW] " pullmoll
2020-09-20 13:08 ` [PR PATCH] [Updated] " manfredu
2020-09-20 13:10 ` [PR REVIEW] " manfredu
2020-09-20 13:52 ` pullmoll
2020-09-20 13:53 ` pullmoll
2020-09-20 13:55 ` pullmoll
2020-09-20 14:11 ` pullmoll
2020-09-20 14:23 ` manfredu
2020-09-20 14:50 ` [PR PATCH] [Updated] " manfredu
2020-09-20 14:52 ` manfredu
2020-09-20 15:04 ` [PR REVIEW] " pullmoll
2020-09-20 15:04 ` pullmoll
2020-09-20 15:05 ` pullmoll
2020-09-20 15:05 ` pullmoll
2020-09-20 15:08 ` pullmoll
2020-09-20 15:09 ` pullmoll
2020-09-20 15:19 ` pullmoll
2020-09-20 15:29 ` pullmoll
2020-09-20 15:30 ` [PR PATCH] [Closed]: " pullmoll
2020-09-20 15:59 ` pullmoll
2020-09-20 16:40 ` manfredu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).