* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
@ 2020-09-21 18:23 ` gbrlsnchs
2020-09-21 18:34 ` ericonr
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-21 18:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-696288007
Comment:
CI is throwing the error `cannot execute binary file: Exec format error` for ARM architectures. Does this mean this package was silently passing but was compiling a non-functional non-ARM binary?
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
2020-09-21 18:23 ` gbrlsnchs
@ 2020-09-21 18:34 ` ericonr
2020-09-21 18:53 ` [PR PATCH] [Updated] " gbrlsnchs
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-09-21 18:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-696293948
Comment:
No. The ARM binaries are cross compiled, so the host machine _can't_ execute them. To generate completions, use `vtargetrun`, as in the `rustup` template.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
2020-09-21 18:23 ` gbrlsnchs
2020-09-21 18:34 ` ericonr
@ 2020-09-21 18:53 ` gbrlsnchs
2020-09-21 19:15 ` gbrlsnchs
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-21 18:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1172 bytes --]
From 72f5d19428835af1efe5ab63be35443a14235ae0 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..06c23761f05 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,19 @@ pre_build() {
fi
}
+post_build() {
+ gopath=$(go env GOPATH)
+ gh=$(find $gopath/bin -name gh)
+ for shell in bash fish zsh; do
+ vtargetrun $gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ # install shell completions
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (2 preceding siblings ...)
2020-09-21 18:53 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2020-09-21 19:15 ` gbrlsnchs
2020-09-23 17:35 ` gbrlsnchs
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-21 19:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-696316596
Comment:
> No. The ARM binaries are cross compiled, so the host machine can't execute them. To generate completions, use vtargetrun, as in the rustup template.
Duh, my bad. And TIL about `vtargetrun`, thanks!
It now seems to be working but some CI jobs have timed out. :disappointed:
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (3 preceding siblings ...)
2020-09-21 19:15 ` gbrlsnchs
@ 2020-09-23 17:35 ` gbrlsnchs
2020-09-23 18:00 ` ericonr
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 17:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-697759199
Comment:
@ericonr, do you have permission to rerun the CI jobs? I think everything's fine and working, it has just timed out.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (4 preceding siblings ...)
2020-09-23 17:35 ` gbrlsnchs
@ 2020-09-23 18:00 ` ericonr
2020-09-23 18:08 ` [PR PATCH] [Updated] " gbrlsnchs
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-09-23 18:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 221 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-697800282
Comment:
@gbrlsnchs you can rebase your branch and force push it. That should restart CI.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (5 preceding siblings ...)
2020-09-23 18:00 ` ericonr
@ 2020-09-23 18:08 ` gbrlsnchs
2020-09-23 19:24 ` gbrlsnchs
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 18:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1172 bytes --]
From 7dcca85747be46cfb72363ba221fcfb4f29aa976 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..06c23761f05 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,19 @@ pre_build() {
fi
}
+post_build() {
+ gopath=$(go env GOPATH)
+ gh=$(find $gopath/bin -name gh)
+ for shell in bash fish zsh; do
+ vtargetrun $gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ # install shell completions
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (6 preceding siblings ...)
2020-09-23 18:08 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2020-09-23 19:24 ` gbrlsnchs
2020-09-23 19:27 ` [PR REVIEW] " ericonr
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 19:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-697923446
Comment:
All right, @ericonr, all good now, thanks for the tip.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR REVIEW] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (7 preceding siblings ...)
2020-09-23 19:24 ` gbrlsnchs
@ 2020-09-23 19:27 ` ericonr
2020-09-23 20:11 ` [PR PATCH] [Updated] " gbrlsnchs
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-09-23 19:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 232 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#discussion_r493842256
Comment:
We set `GOPATH` for the build, so it should work just as well with `find $GOPATH/bin`
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (8 preceding siblings ...)
2020-09-23 19:27 ` [PR REVIEW] " ericonr
@ 2020-09-23 20:11 ` gbrlsnchs
2020-09-23 20:20 ` gbrlsnchs
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 20:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1121 bytes --]
From caa4c28eb284bb3e1d2c35c119aace5f8be69cc7 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..8f2e120881b 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,17 @@ pre_build() {
fi
}
+post_build() {
+ for shell in bash fish zsh; do
+ vtargetrun $GOPATH/bin/gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ # install shell completions
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (9 preceding siblings ...)
2020-09-23 20:11 ` [PR PATCH] [Updated] " gbrlsnchs
@ 2020-09-23 20:20 ` gbrlsnchs
2020-09-23 20:23 ` gbrlsnchs
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 20:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1123 bytes --]
From d2b3ddafdc63bae9713d262a486488173dd94f1c Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..8a05ab5a628 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,17 @@ pre_build() {
fi
}
+post_build() {
+ for shell in bash fish zsh; do
+ vtargetrun ${GOPATH}/bin/gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ # install shell completions
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (10 preceding siblings ...)
2020-09-23 20:20 ` gbrlsnchs
@ 2020-09-23 20:23 ` gbrlsnchs
2020-09-23 20:26 ` gbrlsnchs
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 20:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1145 bytes --]
From 95ca67bdb1ab35fe6df843d33394ba61a417a9c4 Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..e9fddd72449 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,18 @@ pre_build() {
fi
}
+post_build() {
+ gh=$(find $GOPATH/bin -name gh)
+ for shell in bash fish zsh; do
+ vtargetrun $gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ # install shell completions
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (11 preceding siblings ...)
2020-09-23 20:23 ` gbrlsnchs
@ 2020-09-23 20:26 ` gbrlsnchs
2020-09-23 21:31 ` gbrlsnchs
2020-09-23 22:14 ` [PR PATCH] [Merged]: " ericonr
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 20:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
There is an updated pull request by gbrlsnchs against master on the void-packages repository
https://github.com/gbrlsnchs/void-packages github-cli-completion
https://github.com/void-linux/void-packages/pull/25013
github-cli: install shell completion
A patch file from https://github.com/void-linux/void-packages/pull/25013.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-github-cli-completion-25013.patch --]
[-- Type: text/x-diff, Size: 1114 bytes --]
From 6cc5d277e1f2eb82b729791c9ba7c2d4cb98094f Mon Sep 17 00:00:00 2001
From: Gabriel Sanches <gabriel@gsr.dev>
Date: Mon, 21 Sep 2020 13:28:53 -0300
Subject: [PATCH] github-cli: install shell completion
---
srcpkgs/github-cli/template | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/github-cli/template b/srcpkgs/github-cli/template
index d1446631aeb..4834d3faea3 100644
--- a/srcpkgs/github-cli/template
+++ b/srcpkgs/github-cli/template
@@ -1,9 +1,10 @@
# Template file for 'github-cli'
pkgname=github-cli
version=1.0.0
-revision=1
+revision=2
wrksrc="cli-${version}"
build_style=go
+build_helper=qemu
go_import_path="github.com/cli/cli/cmd/gh"
go_ldflags="-X github.com/cli/cli/command.Version=v${version}"
short_desc="GitHub CLI tool"
@@ -22,6 +23,17 @@ pre_build() {
fi
}
+post_build() {
+ gh=$(find $GOPATH/bin -name gh)
+ for shell in bash fish zsh; do
+ vtargetrun $gh completion -s $shell > github-cli.$shell
+ done
+}
+
post_install() {
vlicense LICENSE
+
+ for shell in bash fish zsh; do
+ vcompletion github-cli.$shell $shell gh
+ done
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (12 preceding siblings ...)
2020-09-23 20:26 ` gbrlsnchs
@ 2020-09-23 21:31 ` gbrlsnchs
2020-09-23 22:14 ` [PR PATCH] [Merged]: " ericonr
14 siblings, 0 replies; 16+ messages in thread
From: gbrlsnchs @ 2020-09-23 21:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
New comment by gbrlsnchs on void-packages repository
https://github.com/void-linux/void-packages/pull/25013#issuecomment-697983689
Comment:
@ericonr All good now.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Merged]: github-cli: install shell completion
2020-09-21 17:37 [PR PATCH] github-cli: install shell completion gbrlsnchs
` (13 preceding siblings ...)
2020-09-23 21:31 ` gbrlsnchs
@ 2020-09-23 22:14 ` ericonr
14 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2020-09-23 22:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
There's a merged pull request on the void-packages repository
github-cli: install shell completion
https://github.com/void-linux/void-packages/pull/25013
Description:
^ permalink raw reply [flat|nested] 16+ messages in thread