Re: [PR PATCH] [Updated] alsa-firmware: remove nocross, add ignore_elf_files

Re: [PR PATCH] [Updated] alsa-firmware: remove nocross, add ignore_elf_files

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages alsa-firmware-nocross
https://github.com/void-linux/void-packages/pull/24632

alsa-firmware: remove nocross, add ignore_elf_files
alsa-firmware's only C files are internal generation utilities;
use the host cc to allow it to be cross.

There is an elf file that is required for one of the pieces of
firmware which needs to be located in /usr/share; add it to
ignore_elf_files.

This PR will be required for the nocross removal.

A patch file from https://github.com/void-linux/void-packages/pull/24632.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-alsa-firmware-nocross-24632.patch --]
[-- Type: text/x-diff, Size: 1545 bytes --]

From 6f29a4f02c1ced6fcb8f5885c40a36decf958482 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 2 Sep 2020 15:47:46 +1000
Subject: [PATCH] alsa-firmware: remove nocross, add ignore_elf_files

alsa-firmware's only C files are internal generation utilities;
use the host cc to allow it to be cross.

There is an elf file that is required for one of the pieces of
firmware which needs to be located in /usr/share; add it to
ignore_elf_files. This will be required for the nocross removal.
---
 srcpkgs/alsa-firmware/template | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/alsa-firmware/template b/srcpkgs/alsa-firmware/template
index 63d37de92b1..064e403e34c 100644
--- a/srcpkgs/alsa-firmware/template
+++ b/srcpkgs/alsa-firmware/template
@@ -1,7 +1,7 @@
 # Template file for 'alsa-firmware'
 pkgname=alsa-firmware
 version=1.2.1
-revision=1
+revision=2
 archs=noarch
 build_style=gnu-configure
 configure_args="--with-hotplug-dir=/usr/lib/firmware"
@@ -11,8 +11,12 @@ license="GPL-2.0-only"
 homepage="http://www.alsa-project.org"
 distfiles="https://www.alsa-project.org/files/pub/firmware/${pkgname}-${version}.tar.bz2"
 checksum=aea27c571dbe02ede298cf9f637d8dfdb758e032e372c8d7e96ccb2b15fa08ab
-nocross=yes
 nostrip=yes
+ignore_elf_files="/usr/share/alsa/firmware/mixartloader/miXart8.elf"
+
+pre_configure() {
+	export CC="${BUILD_CC}" CFLAGS="${BUILD_CFLAGS}" LDFLAGS="${BUILD_LDFLAGS}"
+}
 
 post_install() {
 	# Removed to prevent any conflict with 'linux-firmware' package

Re: [PR REVIEW] alsa-firmware: remove nocross, add ignore_elf_files

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24632#discussion_r483310155

Comment:
Done

Re: [PR PATCH] [Updated] alsa-firmware: remove nocross, add ignore_elf_files

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

There is an updated pull request by fosslinux against master on the void-packages repository

https://github.com/fosslinux/void-packages alsa-firmware-nocross
https://github.com/void-linux/void-packages/pull/24632

alsa-firmware: remove nocross, add ignore_elf_files
alsa-firmware's only C files are internal generation utilities;
use the host cc to allow it to be cross.

There is an elf file that is required for one of the pieces of
firmware which needs to be located in /usr/share; add it to
ignore_elf_files.

This PR will be required for the nocross removal.

A patch file from https://github.com/void-linux/void-packages/pull/24632.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-alsa-firmware-nocross-24632.patch --]
[-- Type: text/x-diff, Size: 1600 bytes --]

From 71f899c48c56339889a0d2e2895393778094f258 Mon Sep 17 00:00:00 2001
From: fosslinux <fosslinux@aussies.space>
Date: Wed, 2 Sep 2020 15:47:46 +1000
Subject: [PATCH] alsa-firmware: remove nocross, noarch, add ignore_elf_files

alsa-firmware's only C files are internal generation utilities;
use the host cc to allow it to be cross.

There is an elf file that is required for one of the pieces of
firmware which needs to be located in /usr/share; add it to
ignore_elf_files.

Part of the noarch removal.
---
 srcpkgs/alsa-firmware/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/alsa-firmware/template b/srcpkgs/alsa-firmware/template
index 63d37de92b1..4168c558c8a 100644
--- a/srcpkgs/alsa-firmware/template
+++ b/srcpkgs/alsa-firmware/template
@@ -1,8 +1,7 @@
 # Template file for 'alsa-firmware'
 pkgname=alsa-firmware
 version=1.2.1
-revision=1
-archs=noarch
+revision=2
 build_style=gnu-configure
 configure_args="--with-hotplug-dir=/usr/lib/firmware"
 short_desc="Advanced Linux Sound Architecture (ALSA) firmware"
@@ -11,8 +10,12 @@ license="GPL-2.0-only"
 homepage="http://www.alsa-project.org"
 distfiles="https://www.alsa-project.org/files/pub/firmware/${pkgname}-${version}.tar.bz2"
 checksum=aea27c571dbe02ede298cf9f637d8dfdb758e032e372c8d7e96ccb2b15fa08ab
-nocross=yes
 nostrip=yes
+ignore_elf_files="/usr/share/alsa/firmware/mixartloader/miXart8.elf"
+
+pre_configure() {
+	export CC="${BUILD_CC}" CFLAGS="${BUILD_CFLAGS}" LDFLAGS="${BUILD_LDFLAGS}"
+}
 
 post_install() {
 	# Removed to prevent any conflict with 'linux-firmware' package

Re: alsa-firmware: remove nocross, add ignore_elf_files

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

New comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24632#issuecomment-696524526

Comment:
Ping

Re: [PR PATCH] [Merged]: alsa-firmware: remove nocross, add ignore_elf_files

[sgn]

[-- Attachment #1: Type: text/plain, Size: 489 bytes --]

There's a merged pull request on the void-packages repository

alsa-firmware: remove nocross, add ignore_elf_files
https://github.com/void-linux/void-packages/pull/24632

Description:
alsa-firmware's only C files are internal generation utilities;
use the host cc to allow it to be cross.

There is an elf file that is required for one of the pieces of
firmware which needs to be located in /usr/share; add it to
ignore_elf_files.

This PR will be required for the nocross removal.