Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] added dependencies for clipmenu
@ 2020-09-22  6:43 dkwo
  2020-09-22  6:49 ` ericonr
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: dkwo @ 2020-09-22  6:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages clipmenu-deps
https://github.com/void-linux/void-packages/pull/25022

added dependencies for clipmenu
I added some dependencies.
For example, without clipnotify I get an error.
These are the same dependencies as Arch Linux.

A patch file from https://github.com/void-linux/void-packages/pull/25022.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clipmenu-deps-25022.patch --]
[-- Type: text/x-diff, Size: 758 bytes --]

From 3c812c1fe337177fe561905e6156f9c2855580ec Mon Sep 17 00:00:00 2001
From: Nicolo <nicolopiazzalunga@gmail.com>
Date: Tue, 22 Sep 2020 08:37:48 +0200
Subject: [PATCH] added dependencies for clipmenu

---
 srcpkgs/clipmenu/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/clipmenu/template b/srcpkgs/clipmenu/template
index 4176172d179..ee09e03827d 100644
--- a/srcpkgs/clipmenu/template
+++ b/srcpkgs/clipmenu/template
@@ -1,9 +1,9 @@
 # Template file for 'clipmenu'
 pkgname=clipmenu
 version=6.1.0
-revision=1
+revision=2
 archs=noarch
-depends="bash dmenu"
+depends="bash dmenu clipnotify xsel"
 short_desc="Clipboard management using dmenu"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Public Domain"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
@ 2020-09-22  6:49 ` ericonr
  2020-09-22  6:51 ` [PR REVIEW] " ericonr
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-22  6:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25022#issuecomment-696540905

Comment:
Please follow commit format: `clipmenu: add runtime dependencies.` or similar.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
  2020-09-22  6:49 ` ericonr
@ 2020-09-22  6:51 ` ericonr
  2020-09-22  7:32 ` [PR PATCH] [Updated] " dkwo
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-22  6:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25022#discussion_r492508099

Comment:
Please remove noarch, as well.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
  2020-09-22  6:49 ` ericonr
  2020-09-22  6:51 ` [PR REVIEW] " ericonr
@ 2020-09-22  7:32 ` dkwo
  2020-09-23 16:16 ` dkwo
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: dkwo @ 2020-09-22  7:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages clipmenu-deps
https://github.com/void-linux/void-packages/pull/25022

added dependencies for clipmenu
I added some dependencies.
For example, without clipnotify I get an error.
These are the same dependencies as Arch Linux.

A patch file from https://github.com/void-linux/void-packages/pull/25022.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-clipmenu-deps-25022.patch --]
[-- Type: text/x-diff, Size: 777 bytes --]

From ea8354c5691f229375193520903663b0fec0e7e8 Mon Sep 17 00:00:00 2001
From: Nicolo <nicolopiazzalunga@gmail.com>
Date: Tue, 22 Sep 2020 09:30:24 +0200
Subject: [PATCH] clipmenu: add runtime dependencies, remove noarch

---
 srcpkgs/clipmenu/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/clipmenu/template b/srcpkgs/clipmenu/template
index 4176172d179..a7302993521 100644
--- a/srcpkgs/clipmenu/template
+++ b/srcpkgs/clipmenu/template
@@ -1,9 +1,8 @@
 # Template file for 'clipmenu'
 pkgname=clipmenu
 version=6.1.0
-revision=1
-archs=noarch
-depends="bash dmenu"
+revision=2
+depends="bash dmenu clipnotify xsel"
 short_desc="Clipboard management using dmenu"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="Public Domain"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
                   ` (2 preceding siblings ...)
  2020-09-22  7:32 ` [PR PATCH] [Updated] " dkwo
@ 2020-09-23 16:16 ` dkwo
  2020-09-23 16:44 ` ericonr
  2020-09-23 16:44 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: dkwo @ 2020-09-23 16:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/25022#issuecomment-697624715

Comment:
@ericonr I did as you suggested.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
                   ` (3 preceding siblings ...)
  2020-09-23 16:16 ` dkwo
@ 2020-09-23 16:44 ` ericonr
  2020-09-23 16:44 ` [PR PATCH] [Merged]: " ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-23 16:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/25022#issuecomment-697672046

Comment:
Thanks!

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: added dependencies for clipmenu
  2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
                   ` (4 preceding siblings ...)
  2020-09-23 16:44 ` ericonr
@ 2020-09-23 16:44 ` ericonr
  5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-23 16:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

There's a merged pull request on the void-packages repository

added dependencies for clipmenu
https://github.com/void-linux/void-packages/pull/25022

Description:
I added some dependencies.
For example, without clipnotify I get an error.
These are the same dependencies as Arch Linux.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-23 16:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22  6:43 [PR PATCH] added dependencies for clipmenu dkwo
2020-09-22  6:49 ` ericonr
2020-09-22  6:51 ` [PR REVIEW] " ericonr
2020-09-22  7:32 ` [PR PATCH] [Updated] " dkwo
2020-09-23 16:16 ` dkwo
2020-09-23 16:44 ` ericonr
2020-09-23 16:44 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).