* Re: [PR REVIEW] slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
@ 2020-09-27 14:34 ` ericonr
2020-09-27 14:43 ` st3r4g
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-09-27 14:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 178 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#discussion_r495579215
Comment:
`# fix plugin loading for musl`
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
2020-09-27 14:34 ` [PR REVIEW] " ericonr
@ 2020-09-27 14:43 ` st3r4g
2020-09-27 14:46 ` [PR PATCH] [Updated] " st3r4g
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: st3r4g @ 2020-09-27 14:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New review comment by st3r4g on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#discussion_r495580058
Comment:
it's not just for musl. I'll add `# fix plugin loading`
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
2020-09-27 14:34 ` [PR REVIEW] " ericonr
2020-09-27 14:43 ` st3r4g
@ 2020-09-27 14:46 ` st3r4g
2020-09-27 16:33 ` ericonr
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: st3r4g @ 2020-09-27 14:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
There is an updated pull request by st3r4g against master on the void-packages repository
https://github.com/st3r4g/void-packages slurm-wlm-fix-lazy
https://github.com/void-linux/void-packages/pull/25130
slurm-wlm: use lazy bind (fix plugin loading)
fixes #25123
ping maintainer @Vaelatern
A patch file from https://github.com/void-linux/void-packages/pull/25130.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-slurm-wlm-fix-lazy-25130.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]
From aacfa7035850ae9d92e310034e882d732fff865e Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Sun, 27 Sep 2020 15:31:23 +0200
Subject: [PATCH] slurm-wlm: use lazy bind (fix plugin loading)
---
srcpkgs/slurm-wlm/template | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/slurm-wlm/template b/srcpkgs/slurm-wlm/template
index 9753cabe79f..cd3349c85f7 100644
--- a/srcpkgs/slurm-wlm/template
+++ b/srcpkgs/slurm-wlm/template
@@ -1,7 +1,7 @@
# Template file for 'slurm-wlm'
pkgname=slurm-wlm
version=19.05.5.1
-revision=2
+revision=3
_distver="${version//./-}"
wrksrc="slurm-slurm-${_distver}"
build_style=gnu-configure
@@ -20,6 +20,9 @@ checksum=e53e67bd0bb4c37a9c481998764a746467a96bc41d6527569080514f36452c07
CFLAGS="-fcommon"
+# fix plugin loading
+LDFLAGS="-Wl,-z,lazy"
+
if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
# configure: error: 32-bit support is deprecated, and not tested
# regularly. Use at your own risk.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (2 preceding siblings ...)
2020-09-27 14:46 ` [PR PATCH] [Updated] " st3r4g
@ 2020-09-27 16:33 ` ericonr
2020-09-27 16:33 ` ericonr
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-09-27 16:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#issuecomment-699657212
Comment:
Do you think our build is overwriting upstream's `LDFLAGS`?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (3 preceding siblings ...)
2020-09-27 16:33 ` ericonr
@ 2020-09-27 16:33 ` ericonr
2020-09-27 16:49 ` Vaelatern
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-09-27 16:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 238 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#issuecomment-699657212
Comment:
Do you think our build is overwriting upstream's `LDFLAGS`? Or are they failing to set that flag?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (4 preceding siblings ...)
2020-09-27 16:33 ` ericonr
@ 2020-09-27 16:49 ` Vaelatern
2020-09-27 19:40 ` [PR PATCH] [Updated] " st3r4g
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Vaelatern @ 2020-09-27 16:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
New comment by Vaelatern on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#issuecomment-699659060
Comment:
An actual user for slurm-wlm!
Please add one comment saying "Yes, this disables hardening, this is on purpose" and link to the open bug? I am willing to merge once this necessary context is added.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (5 preceding siblings ...)
2020-09-27 16:49 ` Vaelatern
@ 2020-09-27 19:40 ` st3r4g
2020-09-27 19:48 ` st3r4g
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: st3r4g @ 2020-09-27 19:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
There is an updated pull request by st3r4g against master on the void-packages repository
https://github.com/st3r4g/void-packages slurm-wlm-fix-lazy
https://github.com/void-linux/void-packages/pull/25130
slurm-wlm: use lazy bind (fix plugin loading)
fixes #25123
ping maintainer @Vaelatern
A patch file from https://github.com/void-linux/void-packages/pull/25130.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-slurm-wlm-fix-lazy-25130.patch --]
[-- Type: text/x-diff, Size: 1093 bytes --]
From 2a5aa19acec9352c905d0cbe62ed47e508243024 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <st3r4g@protonmail.com>
Date: Sun, 27 Sep 2020 15:31:23 +0200
Subject: [PATCH] slurm-wlm: use lazy bind (fix plugin loading)
---
srcpkgs/slurm-wlm/template | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/slurm-wlm/template b/srcpkgs/slurm-wlm/template
index 9753cabe79f..d5b5880370d 100644
--- a/srcpkgs/slurm-wlm/template
+++ b/srcpkgs/slurm-wlm/template
@@ -1,7 +1,7 @@
# Template file for 'slurm-wlm'
pkgname=slurm-wlm
version=19.05.5.1
-revision=2
+revision=3
_distver="${version//./-}"
wrksrc="slurm-slurm-${_distver}"
build_style=gnu-configure
@@ -20,6 +20,10 @@ checksum=e53e67bd0bb4c37a9c481998764a746467a96bc41d6527569080514f36452c07
CFLAGS="-fcommon"
+# Fix plugin loading. Yes, this disables hardening, this is on purpose
+# https://bugs.schedmd.com/show_bug.cgi?id=2443
+LDFLAGS="-Wl,-z,lazy"
+
if [ "$XBPS_TARGET_WORDSIZE" = "32" ]; then
# configure: error: 32-bit support is deprecated, and not tested
# regularly. Use at your own risk.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (6 preceding siblings ...)
2020-09-27 19:40 ` [PR PATCH] [Updated] " st3r4g
@ 2020-09-27 19:48 ` st3r4g
2020-09-27 20:24 ` ericonr
2020-09-29 0:42 ` [PR PATCH] [Merged]: " Vaelatern
9 siblings, 0 replies; 11+ messages in thread
From: st3r4g @ 2020-09-27 19:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
New comment by st3r4g on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#issuecomment-699679928
Comment:
> Do you think our build is overwriting upstream's `LDFLAGS`? Or are they failing to set that flag?
What do you mean? The problem is the `-z,now` default on Void
> An actual user for slurm-wlm!
I don't know how to use it. I just installed it to mess around with it a bit
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (7 preceding siblings ...)
2020-09-27 19:48 ` st3r4g
@ 2020-09-27 20:24 ` ericonr
2020-09-29 0:42 ` [PR PATCH] [Merged]: " Vaelatern
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2020-09-27 20:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25130#issuecomment-699683860
Comment:
> What do you mean? The problem is the -z,now default on Void
I noticed later, sorry.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: slurm-wlm: use lazy bind (fix plugin loading)
2020-09-27 13:34 [PR PATCH] slurm-wlm: use lazy bind (fix plugin loading) st3r4g
` (8 preceding siblings ...)
2020-09-27 20:24 ` ericonr
@ 2020-09-29 0:42 ` Vaelatern
9 siblings, 0 replies; 11+ messages in thread
From: Vaelatern @ 2020-09-29 0:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
There's a merged pull request on the void-packages repository
slurm-wlm: use lazy bind (fix plugin loading)
https://github.com/void-linux/void-packages/pull/25130
Description:
fixes #25123
ping maintainer @Vaelatern
^ permalink raw reply [flat|nested] 11+ messages in thread