* [PR PATCH] New package: crun-0.15
@ 2020-09-28 1:59 ap4y
2020-09-28 2:58 ` [PR PATCH] [Updated] " ap4y
` (19 more replies)
0 siblings, 20 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 1:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
There is a new pull request by ap4y against master on the void-packages repository
https://github.com/ap4y/void-packages crun
https://github.com/void-linux/void-packages/pull/25140
New package: crun-0.15
crun is supported by podman as an alternative for runc.
A patch file from https://github.com/void-linux/void-packages/pull/25140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crun-25140.patch --]
[-- Type: text/x-diff, Size: 2738 bytes --]
From 86dc40bb75c3ca31609aff5535c1856682958836 Mon Sep 17 00:00:00 2001
From: ap4y <mail@ap4y.me>
Date: Mon, 28 Sep 2020 14:46:22 +1300
Subject: [PATCH] New package: crun-0.15
crun is supported by podman as an alternative for runc.
---
common/shlibs | 1 +
srcpkgs/crun/template | 33 +++++++++++++++++++++++++++++++++
srcpkgs/crun/update | 1 +
srcpkgs/libcrun | 1 +
srcpkgs/libcrun-devel | 1 +
5 files changed, 37 insertions(+)
create mode 100644 srcpkgs/crun/template
create mode 100644 srcpkgs/crun/update
create mode 120000 srcpkgs/libcrun
create mode 120000 srcpkgs/libcrun-devel
diff --git a/common/shlibs b/common/shlibs
index aae753c73a1..479c1de0a1f 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3989,3 +3989,4 @@ libneatvnc.so.0 neatvnc-0.2.0_1
libtdjson.so.1.6.0 libtd-1.6.0_1
libJudy.so.1 judy-1.0.5_1
libsignal-protocol-c.so.2 libsignal-protocol-c-2.3.3_2
+libcrun.so.0 libcrun-0.15_1
diff --git a/srcpkgs/crun/template b/srcpkgs/crun/template
new file mode 100644
index 00000000000..f99b045621e
--- /dev/null
+++ b/srcpkgs/crun/template
@@ -0,0 +1,33 @@
+# Template file for 'crun'
+pkgname=crun
+version=0.15
+revision=1
+build_style=gnu-configure
+configure_args="--disable-systemd --enable-shared"
+hostmakedepends="pkg-config python3"
+makedepends="libcap-devel libseccomp-devel yajl-devel go-md2man"
+short_desc="Fast and lightweight fully featured OCI runtime"
+maintainer="Arthur Evstifeev <mail@ap4y.me>"
+license="GPL-2.0-or-later, LGPL-2.1-or-later"
+homepage="https://github.com/containers/crun"
+distfiles="https://github.com/containers/crun/releases/download/${version}/crun-${version}.tar.xz"
+checksum=e635b953327b1ae0155db63ef75be56755c0c3ce91ebbe4b4093774fdbd56df1
+
+case $XBPS_TARGET_MACHINE in
+ *-musl) makedepends+=" argp-standalone"
+esac
+
+libcrun-devel_package() {
+ depends="libcrun-${version}_${revision}"
+ short_desc+=" - C library for running containers - development files"
+ pkg_install() {
+ vmove "usr/lib/libcrun*.a"
+ }
+}
+
+libcrun_package() {
+ short_desc+=" - C library for running containers"
+ pkg_install() {
+ vmove "usr/lib/libcrun.so*"
+ }
+}
diff --git a/srcpkgs/crun/update b/srcpkgs/crun/update
new file mode 100644
index 00000000000..cdcf3fc57dc
--- /dev/null
+++ b/srcpkgs/crun/update
@@ -0,0 +1 @@
+site=https://github.com/containers/crun/releases
diff --git a/srcpkgs/libcrun b/srcpkgs/libcrun
new file mode 120000
index 00000000000..d132684fcdb
--- /dev/null
+++ b/srcpkgs/libcrun
@@ -0,0 +1 @@
+crun
\ No newline at end of file
diff --git a/srcpkgs/libcrun-devel b/srcpkgs/libcrun-devel
new file mode 120000
index 00000000000..d132684fcdb
--- /dev/null
+++ b/srcpkgs/libcrun-devel
@@ -0,0 +1 @@
+crun
\ No newline at end of file
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Updated] New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
@ 2020-09-28 2:58 ` ap4y
2020-09-28 3:00 ` ap4y
` (18 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 2:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
There is an updated pull request by ap4y against master on the void-packages repository
https://github.com/ap4y/void-packages crun
https://github.com/void-linux/void-packages/pull/25140
New package: crun-0.15
crun is supported by podman as an alternative for runc.
A patch file from https://github.com/void-linux/void-packages/pull/25140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crun-25140.patch --]
[-- Type: text/x-diff, Size: 4047 bytes --]
From 318ca9cb7bf5c75839aeaafd48b0654ba71d2938 Mon Sep 17 00:00:00 2001
From: ap4y <mail@ap4y.me>
Date: Mon, 28 Sep 2020 14:46:22 +1300
Subject: [PATCH] New package: crun-0.15
crun is supported by podman as an alternative for runc, new virtual
package was added to handle this.
---
common/shlibs | 1 +
etc/defaults.virtual | 1 +
srcpkgs/crun/template | 34 ++++++++++++++++++++++++++++++++++
srcpkgs/libcrun | 1 +
srcpkgs/libcrun-devel | 1 +
srcpkgs/podman/template | 2 +-
srcpkgs/runc/template | 1 +
7 files changed, 40 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/crun/template
create mode 120000 srcpkgs/libcrun
create mode 120000 srcpkgs/libcrun-devel
diff --git a/common/shlibs b/common/shlibs
index aae753c73a1..479c1de0a1f 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3989,3 +3989,4 @@ libneatvnc.so.0 neatvnc-0.2.0_1
libtdjson.so.1.6.0 libtd-1.6.0_1
libJudy.so.1 judy-1.0.5_1
libsignal-protocol-c.so.2 libsignal-protocol-c-2.3.3_2
+libcrun.so.0 libcrun-0.15_1
diff --git a/etc/defaults.virtual b/etc/defaults.virtual
index 083ab6349ea..34c314f8e81 100644
--- a/etc/defaults.virtual
+++ b/etc/defaults.virtual
@@ -36,3 +36,4 @@ xserver-abi-video xorg-server
libGL libglvnd
libEGL libglvnd
libGLES libglvnd
+oci-runtime runc
diff --git a/srcpkgs/crun/template b/srcpkgs/crun/template
new file mode 100644
index 00000000000..7c7a0ccc25e
--- /dev/null
+++ b/srcpkgs/crun/template
@@ -0,0 +1,34 @@
+# Template file for 'crun'
+pkgname=crun
+version=0.15
+revision=1
+build_style=gnu-configure
+configure_args="--disable-systemd --enable-shared"
+hostmakedepends="pkg-config python3"
+makedepends="libcap-devel libseccomp-devel yajl-devel go-md2man"
+short_desc="Fast and lightweight fully featured OCI runtime"
+maintainer="Arthur Evstifeev <mail@ap4y.me>"
+license="GPL-2.0-or-later, LGPL-2.1-or-later"
+homepage="https://github.com/containers/crun"
+distfiles="https://github.com/containers/crun/releases/download/${version}/crun-${version}.tar.xz"
+checksum=e635b953327b1ae0155db63ef75be56755c0c3ce91ebbe4b4093774fdbd56df1
+provides="oci-runtime-0_1"
+
+case $XBPS_TARGET_MACHINE in
+ *-musl) makedepends+=" argp-standalone"
+esac
+
+libcrun-devel_package() {
+ depends="libcrun-${version}_${revision}"
+ short_desc+=" - C library for running containers - development files"
+ pkg_install() {
+ vmove "usr/lib/libcrun*.a"
+ }
+}
+
+libcrun_package() {
+ short_desc+=" - C library for running containers"
+ pkg_install() {
+ vmove "usr/lib/libcrun.so*"
+ }
+}
diff --git a/srcpkgs/libcrun b/srcpkgs/libcrun
new file mode 120000
index 00000000000..d132684fcdb
--- /dev/null
+++ b/srcpkgs/libcrun
@@ -0,0 +1 @@
+crun
\ No newline at end of file
diff --git a/srcpkgs/libcrun-devel b/srcpkgs/libcrun-devel
new file mode 120000
index 00000000000..d132684fcdb
--- /dev/null
+++ b/srcpkgs/libcrun-devel
@@ -0,0 +1 @@
+crun
\ No newline at end of file
diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index 46703514fdd..87644c5731a 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -9,7 +9,7 @@ go_build_tags="seccomp apparmor containers_image_ostree_stub
btrfs_noversion exclude_graphdriver_btrfs"
hostmakedepends="pkg-config go-md2man"
makedepends="gpgme-devel libseccomp-devel device-mapper-devel"
-depends="runc conmon cni-plugins slirp4netns containers.image"
+depends="virtual?oci-runtime conmon cni-plugins slirp4netns containers.image"
short_desc="Simple management tool for containers and images"
maintainer="Cameron Nemo <cnemo@tutanota.com>"
license="Apache-2.0"
diff --git a/srcpkgs/runc/template b/srcpkgs/runc/template
index b2709fa2440..22add76beac 100644
--- a/srcpkgs/runc/template
+++ b/srcpkgs/runc/template
@@ -16,6 +16,7 @@ license="Apache-2.0"
homepage="https://github.com/opencontainers/runc"
distfiles="https://github.com/opencontainers/runc/releases/download/v${_ver}/runc.tar.xz"
checksum=2f76b623b550588db98e2be72e74aae426f5d4cf736bd92afb91dd5586816daf
+provides="oci-runtime-0_1"
post_build() {
make man
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
2020-09-28 2:58 ` [PR PATCH] [Updated] " ap4y
@ 2020-09-28 3:00 ` ap4y
2020-09-28 3:00 ` ericonr
` (17 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 3:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699742519
Comment:
@CameronNemo I'm curious if you are interested in maintaining `crun` since you are already maintaining `runc` and `podman`. If not I can do that myself. Thanks!
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
2020-09-28 2:58 ` [PR PATCH] [Updated] " ap4y
2020-09-28 3:00 ` ap4y
@ 2020-09-28 3:00 ` ericonr
2020-09-28 3:17 ` ap4y
` (16 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ericonr @ 2020-09-28 3:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 214 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699742728
Comment:
Is using this with `podman` plug and play? What advantages does it bring?
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (2 preceding siblings ...)
2020-09-28 3:00 ` ericonr
@ 2020-09-28 3:17 ` ap4y
2020-09-28 3:20 ` ap4y
` (15 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 3:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699746541
Comment:
@ericonr Yes it should be plug and play and `crun` is pulled by default in the recent versions of fedora: https://src.fedoraproject.org/rpms/podman/blob/master/f/podman.spec#_96. There are 2 main benefits `crun` provides right now: it's [faster](https://github.com/containers/crun#performance) than `runc` and I believe `cgroupv2` changes land in `crun` a bit faster. The bigger benefit imo is that `crun` is maintained by the `podman` developers.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (3 preceding siblings ...)
2020-09-28 3:17 ` ap4y
@ 2020-09-28 3:20 ` ap4y
2020-09-28 3:48 ` [PR PATCH] [Updated] " ap4y
` (14 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 3:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699746541
Comment:
@ericonr Yes it should be plug and play and `crun` is pulled by default in the recent versions of fedora: https://src.fedoraproject.org/rpms/podman/blob/master/f/podman.spec#_96. There are 2 main benefits `crun` provides right now: it's [faster](https://github.com/containers/crun#performance) than `runc` and I believe [cgroupv2](https://github.com/containers/podman/blob/master/docs/tutorials/rootless_tutorial.md#cgroup-v2-support) changes land in `crun` a bit faster. The bigger benefit imo is that `crun` is maintained by the `podman` developers.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Updated] New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (4 preceding siblings ...)
2020-09-28 3:20 ` ap4y
@ 2020-09-28 3:48 ` ap4y
2020-09-28 4:36 ` CameronNemo
` (13 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 3:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
There is an updated pull request by ap4y against master on the void-packages repository
https://github.com/ap4y/void-packages crun
https://github.com/void-linux/void-packages/pull/25140
New package: crun-0.15
crun is supported by podman as an alternative for runc.
A patch file from https://github.com/void-linux/void-packages/pull/25140.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-crun-25140.patch --]
[-- Type: text/x-diff, Size: 2807 bytes --]
From c7c1f5a16ec1d1c0595292b82ea6484e75c562a4 Mon Sep 17 00:00:00 2001
From: ap4y <mail@ap4y.me>
Date: Mon, 28 Sep 2020 14:46:22 +1300
Subject: [PATCH] New package: crun-0.15
crun is supported by podman as an alternative for runc, new virtual
package was added to handle this.
---
etc/defaults.virtual | 1 +
srcpkgs/crun/template | 19 +++++++++++++++++++
srcpkgs/podman/template | 2 +-
srcpkgs/runc/template | 1 +
4 files changed, 22 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/crun/template
diff --git a/etc/defaults.virtual b/etc/defaults.virtual
index 083ab6349ea..34c314f8e81 100644
--- a/etc/defaults.virtual
+++ b/etc/defaults.virtual
@@ -36,3 +36,4 @@ xserver-abi-video xorg-server
libGL libglvnd
libEGL libglvnd
libGLES libglvnd
+oci-runtime runc
diff --git a/srcpkgs/crun/template b/srcpkgs/crun/template
new file mode 100644
index 00000000000..4aae6bb4877
--- /dev/null
+++ b/srcpkgs/crun/template
@@ -0,0 +1,19 @@
+# Template file for 'crun'
+pkgname=crun
+version=0.15
+revision=1
+build_style=gnu-configure
+configure_args="--disable-systemd"
+hostmakedepends="pkg-config python3"
+makedepends="libcap-devel libseccomp-devel yajl-devel go-md2man"
+short_desc="Fast and lightweight fully featured OCI runtime"
+maintainer="Arthur Evstifeev <mail@ap4y.me>"
+license="GPL-2.0-or-later, LGPL-2.1-or-later"
+homepage="https://github.com/containers/crun"
+distfiles="https://github.com/containers/crun/releases/download/${version}/crun-${version}.tar.xz"
+checksum=e635b953327b1ae0155db63ef75be56755c0c3ce91ebbe4b4093774fdbd56df1
+provides="oci-runtime-0_1"
+
+case $XBPS_TARGET_MACHINE in
+ *-musl) makedepends+=" argp-standalone"
+esac
diff --git a/srcpkgs/podman/template b/srcpkgs/podman/template
index 46703514fdd..87644c5731a 100644
--- a/srcpkgs/podman/template
+++ b/srcpkgs/podman/template
@@ -9,7 +9,7 @@ go_build_tags="seccomp apparmor containers_image_ostree_stub
btrfs_noversion exclude_graphdriver_btrfs"
hostmakedepends="pkg-config go-md2man"
makedepends="gpgme-devel libseccomp-devel device-mapper-devel"
-depends="runc conmon cni-plugins slirp4netns containers.image"
+depends="virtual?oci-runtime conmon cni-plugins slirp4netns containers.image"
short_desc="Simple management tool for containers and images"
maintainer="Cameron Nemo <cnemo@tutanota.com>"
license="Apache-2.0"
diff --git a/srcpkgs/runc/template b/srcpkgs/runc/template
index b2709fa2440..22add76beac 100644
--- a/srcpkgs/runc/template
+++ b/srcpkgs/runc/template
@@ -16,6 +16,7 @@ license="Apache-2.0"
homepage="https://github.com/opencontainers/runc"
distfiles="https://github.com/opencontainers/runc/releases/download/v${_ver}/runc.tar.xz"
checksum=2f76b623b550588db98e2be72e74aae426f5d4cf736bd92afb91dd5586816daf
+provides="oci-runtime-0_1"
post_build() {
make man
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (5 preceding siblings ...)
2020-09-28 3:48 ` [PR PATCH] [Updated] " ap4y
@ 2020-09-28 4:36 ` CameronNemo
2020-09-28 4:42 ` CameronNemo
` (12 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-28 4:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699764528
Comment:
I have never much liked the crun project. The performance/resource gains seem quite niche. Not applicable to my workloads. I would rather not maintain or use crun.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (6 preceding siblings ...)
2020-09-28 4:36 ` CameronNemo
@ 2020-09-28 4:42 ` CameronNemo
2020-09-28 4:43 ` CameronNemo
` (11 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-28 4:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699764528
Comment:
I have never much liked the crun project. The performance/resource gains seem quite niche. Not applicable to my workloads. I would rather not maintain or use crun.
Also are you using cgroup2? cgroup2 only or the hybrid setup? runc claims to support cgroup2.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (7 preceding siblings ...)
2020-09-28 4:42 ` CameronNemo
@ 2020-09-28 4:43 ` CameronNemo
2020-09-28 8:00 ` ap4y
` (10 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-28 4:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699764528
Comment:
The performance/resource gains seem quite niche. Not applicable to my workloads. I would rather not maintain or use crun.
Also are you using cgroup2? cgroup2 only or the hybrid setup? runc claims to support cgroup2.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (8 preceding siblings ...)
2020-09-28 4:43 ` CameronNemo
@ 2020-09-28 8:00 ` ap4y
2020-09-29 20:30 ` [PR REVIEW] " CameronNemo
` (9 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-28 8:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-699847443
Comment:
@CameronNemo that's ok, I have been using crun for a while on my gentoo machine so happy to maintain it.
I'm evaluating cgroup2 (non-root) for my severs and noticed that v2 support in runc is not production ready yet: https://github.com/opencontainers/runc#releases. Looks like crun is the way to go for now.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR REVIEW] New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (9 preceding siblings ...)
2020-09-28 8:00 ` ap4y
@ 2020-09-29 20:30 ` CameronNemo
2020-09-29 20:32 ` CameronNemo
` (8 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-29 20:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#discussion_r497025354
Comment:
Virtual packages are sort of seriously broken. If they can be avoided, that would be preferable.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR REVIEW] New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (10 preceding siblings ...)
2020-09-29 20:30 ` [PR REVIEW] " CameronNemo
@ 2020-09-29 20:32 ` CameronNemo
2020-09-29 20:32 ` CameronNemo
` (7 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-29 20:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#discussion_r497026241
Comment:
You need to bump revision when changing metadata like dependencies, provides, etc. Otherwise the binary package will not be rebuilt.
Also you may be able to get around this virtual dependency by leaving it as is then using `ignorepkg=runc` in an xbps config file.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR REVIEW] New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (11 preceding siblings ...)
2020-09-29 20:32 ` CameronNemo
@ 2020-09-29 20:32 ` CameronNemo
2020-09-30 4:36 ` ap4y
` (6 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-29 20:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New review comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#discussion_r497026370
Comment:
need to bump revision, as above
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (12 preceding siblings ...)
2020-09-29 20:32 ` CameronNemo
@ 2020-09-30 4:36 ` ap4y
2020-09-30 5:16 ` CameronNemo
` (5 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-30 4:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701151296
Comment:
Thanks a lot for the review @CameronNemo, really appreciate it. I wasn't aware of the issues with virtual packages and couldn't find related information in the manual or issues. I'm curious where a can read more about those before going with my original idea and rev bumping `podman` and `runc`.
I also had a chance to test a pure cgroupv2 mode (i.e. unified) and had some issues with rootless mode in `runc`, `crun` runs seems to be getting the same error but it's ignored. Haven't fully investigated this one.
```
ap4y » podman --runtime runc run --rm -ti alpine sh
Error: container_linux.go:370: starting container process caused: process_linux.go:326: applying cgroup configuration for process caused: mkdir /sys/fs/cgroup/libpod_parent: permission denied: OCI runtime permission denied error
ap4y » podman --runtime crun --log-level info run --rm -ti alpine sh
INFO[0000] podman filtering at log level info
WARN[0000] Error initializing configured OCI runtime kata: no valid executable found for OCI runtime kata: invalid argument
INFO[0000] Setting parallel job count to 37
WARN[0000] Failed to add conmon to cgroupfs sandbox cgroup: error creating cgroup path /libpod_parent/conmon: write /sys/fs/cgroup/cgroup.subtree_control: open /sys/fs/cgroup/cgroup.subtree_control: permission denied
INFO[0000] Got Conmon PID as 6067
/ #
ap4y » podman info
host:
arch: amd64
buildahVersion: 1.16.1
cgroupVersion: v2
```
Since `crun` looks like a bit more stable option for cgroupv2 I think using `ignorepkg` might be a bit clunky solution.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (13 preceding siblings ...)
2020-09-30 4:36 ` ap4y
@ 2020-09-30 5:16 ` CameronNemo
2020-09-30 7:31 ` ap4y
` (4 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-30 5:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701161009
Comment:
Are you running as root? Because from what I can tell you are at the top level of the cgroup tree -- that will not work unless you have root permissions. If you are already in a delegated cgroup for your user, the permissions errors will clear up.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (14 preceding siblings ...)
2020-09-30 5:16 ` CameronNemo
@ 2020-09-30 7:31 ` ap4y
2020-09-30 7:31 ` [PR PATCH] [Closed]: " ap4y
` (3 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-30 7:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701215367
Comment:
Thanks @CameronNemo, setting up delegated cgroup worked, it took some time to figure out how to do this :) It seems both `crun` and `runc` work with `cgroups2`. I'm going to close this PR, if there will be further demand we can re-open it.
I'm still a bit curious about weirdness of the virtual packages, is there any way to read more about it?
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PR PATCH] [Closed]: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (15 preceding siblings ...)
2020-09-30 7:31 ` ap4y
@ 2020-09-30 7:31 ` ap4y
2020-09-30 16:22 ` CameronNemo
` (2 subsequent siblings)
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-30 7:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
There's a closed pull request on the void-packages repository
New package: crun-0.15
https://github.com/void-linux/void-packages/pull/25140
Description:
crun is supported by podman as an alternative for runc.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (16 preceding siblings ...)
2020-09-30 7:31 ` [PR PATCH] [Closed]: " ap4y
@ 2020-09-30 16:22 ` CameronNemo
2020-09-30 16:24 ` CameronNemo
2020-09-30 21:49 ` ap4y
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-30 16:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701498018
Comment:
https://github.com/void-linux/xbps/issues/318 . you can also ping duncaen in the #xbps freenode channel if you want some more background.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (17 preceding siblings ...)
2020-09-30 16:22 ` CameronNemo
@ 2020-09-30 16:24 ` CameronNemo
2020-09-30 21:49 ` ap4y
19 siblings, 0 replies; 21+ messages in thread
From: CameronNemo @ 2020-09-30 16:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 504 bytes --]
New comment by CameronNemo on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701498018
Comment:
https://github.com/void-linux/xbps/issues/318 is the best thread for documentation of issues that I can find, although it is less relevant to this example. you can ping duncaen in the #xbps freenode channel if you want some more info. Sorry I do not have a better answer, just that virtual packages were sort of hacked together and break a lot of assumptions.
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: New package: crun-0.15
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
` (18 preceding siblings ...)
2020-09-30 16:24 ` CameronNemo
@ 2020-09-30 21:49 ` ap4y
19 siblings, 0 replies; 21+ messages in thread
From: ap4y @ 2020-09-30 21:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
New comment by ap4y on void-packages repository
https://github.com/void-linux/void-packages/pull/25140#issuecomment-701665356
Comment:
Thanks!
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2020-09-30 21:49 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-28 1:59 [PR PATCH] New package: crun-0.15 ap4y
2020-09-28 2:58 ` [PR PATCH] [Updated] " ap4y
2020-09-28 3:00 ` ap4y
2020-09-28 3:00 ` ericonr
2020-09-28 3:17 ` ap4y
2020-09-28 3:20 ` ap4y
2020-09-28 3:48 ` [PR PATCH] [Updated] " ap4y
2020-09-28 4:36 ` CameronNemo
2020-09-28 4:42 ` CameronNemo
2020-09-28 4:43 ` CameronNemo
2020-09-28 8:00 ` ap4y
2020-09-29 20:30 ` [PR REVIEW] " CameronNemo
2020-09-29 20:32 ` CameronNemo
2020-09-29 20:32 ` CameronNemo
2020-09-30 4:36 ` ap4y
2020-09-30 5:16 ` CameronNemo
2020-09-30 7:31 ` ap4y
2020-09-30 7:31 ` [PR PATCH] [Closed]: " ap4y
2020-09-30 16:22 ` CameronNemo
2020-09-30 16:24 ` CameronNemo
2020-09-30 21:49 ` ap4y
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).