* Re: Install the included bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
@ 2020-04-20 12:54 ` sgn
2020-04-21 2:31 ` [PR PATCH] [Updated] " keshto
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: sgn @ 2020-04-20 12:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/21168#issuecomment-616533805
Comment:
Please bump `revision` and reword the commit msg.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Updated] Install the included bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
2020-04-20 12:54 ` sgn
@ 2020-04-21 2:31 ` keshto
2020-05-01 17:38 ` Copy over the included vpm " Chocimier
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: keshto @ 2020-04-21 2:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
There is an updated pull request by keshto against master on the void-packages repository
https://github.com/keshto/void-packages patch-1
https://github.com/void-linux/void-packages/pull/21168
Install the included bash completions
A patch file from https://github.com/void-linux/void-packages/pull/21168.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-21168.patch --]
[-- Type: text/x-diff, Size: 1295 bytes --]
From 9d0c57367ef90bb33086aaf71fb8bf01a0c0dedd Mon Sep 17 00:00:00 2001
From: Krsna Mahapatra <keshto@users.noreply.github.com>
Date: Sun, 19 Apr 2020 20:39:23 -1000
Subject: [PATCH 1/2] Install the included bash completions
---
srcpkgs/vpm/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/vpm/template b/srcpkgs/vpm/template
index a1b826c402f..8ad766d86e8 100644
--- a/srcpkgs/vpm/template
+++ b/srcpkgs/vpm/template
@@ -12,4 +12,5 @@ checksum=56994ba90aaf9055d0c20a7fbbce7faf6b6d245fba551a427312114f7cb78ae4
do_install() {
vbin vpm
+ vinstall bash-completion/completions/vpm 644 usr/share/bash-completion/completions vpm
}
From e75a052afc8d25a09f0de1b2c145cb22935183c1 Mon Sep 17 00:00:00 2001
From: Krsna Mahapatra <keshto@users.noreply.github.com>
Date: Mon, 20 Apr 2020 16:31:50 -1000
Subject: [PATCH 2/2] bump revision
---
srcpkgs/vpm/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/vpm/template b/srcpkgs/vpm/template
index 8ad766d86e8..be3ba90a5ac 100644
--- a/srcpkgs/vpm/template
+++ b/srcpkgs/vpm/template
@@ -1,7 +1,7 @@
# Template file for 'vpm'
pkgname=vpm
version=1.3
-revision=1
+revision=2
archs=noarch
short_desc="XBPS package management helper for VoidLinux"
maintainer="Armin Jenewein <github@m2m.pm>"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Copy over the included vpm bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
2020-04-20 12:54 ` sgn
2020-04-21 2:31 ` [PR PATCH] [Updated] " keshto
@ 2020-05-01 17:38 ` Chocimier
2020-09-29 2:00 ` [PR REVIEW] " ericonr
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Chocimier @ 2020-05-01 17:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 273 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/21168#issuecomment-622486237
Comment:
It's about commit title in git rather than github PR title. Also single commit, please. You may find squash and force push useful.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR REVIEW] Copy over the included vpm bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
` (2 preceding siblings ...)
2020-05-01 17:38 ` Copy over the included vpm " Chocimier
@ 2020-09-29 2:00 ` ericonr
2020-09-29 2:36 ` keshto
2020-09-29 2:53 ` [PR PATCH] [Closed]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-29 2:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/21168#discussion_r496334744
Comment:
Please use the `vcompletion` helper for this.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Copy over the included vpm bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
` (3 preceding siblings ...)
2020-09-29 2:00 ` [PR REVIEW] " ericonr
@ 2020-09-29 2:36 ` keshto
2020-09-29 2:53 ` [PR PATCH] [Closed]: " ericonr
5 siblings, 0 replies; 7+ messages in thread
From: keshto @ 2020-09-29 2:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
New comment by keshto on void-packages repository
https://github.com/void-linux/void-packages/pull/21168#issuecomment-700390402
Comment:
This PR can be treated as abandoned and thus closed.
On September 29, 2020 2:00:56 AM UTC, "Érico Nogueira Rolim" <notifications@github.com> wrote:
>@ericonr commented on this pull request.
>
>
>
>> @@ -12,4 +12,5 @@ checksum=56994ba90aaf9055d0c20a7fbbce7faf6b6d245fba551a427312114f7cb78ae4
>
> do_install() {
> vbin vpm
>+ vinstall bash-completion/completions/vpm 644 usr/share/bash-completion/completions vpm
>
>Please use the `vcompletion` helper for this.
>
>--
>You are receiving this because you authored the thread.
>Reply to this email directly or view it on GitHub:
>https://github.com/void-linux/void-packages/pull/21168#pullrequestreview-498013179
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PR PATCH] [Closed]: Copy over the included vpm bash completions
2020-04-20 6:40 [PR PATCH] Install the included bash completions keshto
` (4 preceding siblings ...)
2020-09-29 2:36 ` keshto
@ 2020-09-29 2:53 ` ericonr
5 siblings, 0 replies; 7+ messages in thread
From: ericonr @ 2020-09-29 2:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
There's a closed pull request on the void-packages repository
Copy over the included vpm bash completions
https://github.com/void-linux/void-packages/pull/21168
Description:
^ permalink raw reply [flat|nested] 7+ messages in thread