* Re: [PR PATCH] [Updated] Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
@ 2020-10-01 5:41 ` mustaqimM
2020-10-01 5:46 ` mustaqimM
` (7 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mustaqimM @ 2020-10-01 5:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
There is an updated pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages remove_imlib2_webp
https://github.com/void-linux/void-packages/pull/23225
Remove package: imlib2-webp-1.0
No longer required as it is included since `imlib2-1.6.0` in the November update.
A patch file from https://github.com/void-linux/void-packages/pull/23225.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove_imlib2_webp-23225.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]
From 97576cc09fc00592453faef5acab6516a1b4af6b Mon Sep 17 00:00:00 2001
From: mustaqim <mustaqim@pm.me>
Date: Thu, 25 Jun 2020 08:37:04 +0200
Subject: [PATCH] Remove package: imlib2-webp-1.0
---
srcpkgs/imlib2-webp/template | 17 -----------------
1 file changed, 17 deletions(-)
delete mode 100644 srcpkgs/imlib2-webp/template
diff --git a/srcpkgs/imlib2-webp/template b/srcpkgs/imlib2-webp/template
deleted file mode 100644
index 82be878061d..00000000000
--- a/srcpkgs/imlib2-webp/template
+++ /dev/null
@@ -1,17 +0,0 @@
-# Template file for 'imlib2-webp'
-pkgname=imlib2-webp
-version=1.0
-revision=1
-build_style=gnu-makefile
-hostmakedepends="pkg-config"
-makedepends="imlib2-devel libwebp-devel"
-short_desc="WebP loader for Imlib2"
-maintainer="mustaqim <mustaqim@pm.me>"
-license="custom:The Regents of the University of California, BSD-4-Clause-UC"
-homepage="https://www.hauweele.net/~gawen/imlib2-webp.html"
-distfiles="https://github.com/gawen947/imlib2-webp/archive/v${version}.tar.gz"
-checksum=252328cc4e7d232bc2fbbf1c38b963a1847e22f7ee21dd7362b7c0583dca4334
-
-post_install() {
- vlicense COPYING
-}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
2020-10-01 5:41 ` [PR PATCH] [Updated] Remove package: imlib2-webp-1.0 mustaqimM
@ 2020-10-01 5:46 ` mustaqimM
2020-10-01 5:54 ` mustaqimM
` (6 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mustaqimM @ 2020-10-01 5:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
There is an updated pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages remove_imlib2_webp
https://github.com/void-linux/void-packages/pull/23225
Remove package: imlib2-webp-1.0
No longer required as it is included since `imlib2-1.6.0` in the November update.
A patch file from https://github.com/void-linux/void-packages/pull/23225.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove_imlib2_webp-23225.patch --]
[-- Type: text/x-diff, Size: 1119 bytes --]
From 97576cc09fc00592453faef5acab6516a1b4af6b Mon Sep 17 00:00:00 2001
From: mustaqim <mustaqim@pm.me>
Date: Thu, 25 Jun 2020 08:37:04 +0200
Subject: [PATCH] Remove package: imlib2-webp-1.0
---
srcpkgs/imlib2-webp/template | 17 -----------------
1 file changed, 17 deletions(-)
delete mode 100644 srcpkgs/imlib2-webp/template
diff --git a/srcpkgs/imlib2-webp/template b/srcpkgs/imlib2-webp/template
deleted file mode 100644
index 82be878061d..00000000000
--- a/srcpkgs/imlib2-webp/template
+++ /dev/null
@@ -1,17 +0,0 @@
-# Template file for 'imlib2-webp'
-pkgname=imlib2-webp
-version=1.0
-revision=1
-build_style=gnu-makefile
-hostmakedepends="pkg-config"
-makedepends="imlib2-devel libwebp-devel"
-short_desc="WebP loader for Imlib2"
-maintainer="mustaqim <mustaqim@pm.me>"
-license="custom:The Regents of the University of California, BSD-4-Clause-UC"
-homepage="https://www.hauweele.net/~gawen/imlib2-webp.html"
-distfiles="https://github.com/gawen947/imlib2-webp/archive/v${version}.tar.gz"
-checksum=252328cc4e7d232bc2fbbf1c38b963a1847e22f7ee21dd7362b7c0583dca4334
-
-post_install() {
- vlicense COPYING
-}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
2020-10-01 5:41 ` [PR PATCH] [Updated] Remove package: imlib2-webp-1.0 mustaqimM
2020-10-01 5:46 ` mustaqimM
@ 2020-10-01 5:54 ` mustaqimM
2020-10-01 6:06 ` mustaqimM
` (5 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mustaqimM @ 2020-10-01 5:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
There is an updated pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages remove_imlib2_webp
https://github.com/void-linux/void-packages/pull/23225
Remove package: imlib2-webp-1.0
No longer required as it is included since `imlib2-1.6.0` in the November update.
A patch file from https://github.com/void-linux/void-packages/pull/23225.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove_imlib2_webp-23225.patch --]
[-- Type: text/x-diff, Size: 2254 bytes --]
From 97576cc09fc00592453faef5acab6516a1b4af6b Mon Sep 17 00:00:00 2001
From: mustaqim <mustaqim@pm.me>
Date: Thu, 25 Jun 2020 08:37:04 +0200
Subject: [PATCH 1/2] Remove package: imlib2-webp-1.0
---
srcpkgs/imlib2-webp/template | 17 -----------------
1 file changed, 17 deletions(-)
delete mode 100644 srcpkgs/imlib2-webp/template
diff --git a/srcpkgs/imlib2-webp/template b/srcpkgs/imlib2-webp/template
deleted file mode 100644
index 82be878061d..00000000000
--- a/srcpkgs/imlib2-webp/template
+++ /dev/null
@@ -1,17 +0,0 @@
-# Template file for 'imlib2-webp'
-pkgname=imlib2-webp
-version=1.0
-revision=1
-build_style=gnu-makefile
-hostmakedepends="pkg-config"
-makedepends="imlib2-devel libwebp-devel"
-short_desc="WebP loader for Imlib2"
-maintainer="mustaqim <mustaqim@pm.me>"
-license="custom:The Regents of the University of California, BSD-4-Clause-UC"
-homepage="https://www.hauweele.net/~gawen/imlib2-webp.html"
-distfiles="https://github.com/gawen947/imlib2-webp/archive/v${version}.tar.gz"
-checksum=252328cc4e7d232bc2fbbf1c38b963a1847e22f7ee21dd7362b7c0583dca4334
-
-post_install() {
- vlicense COPYING
-}
From 77b1663e678239767c4e4855f6daba326a529f96 Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Thu, 1 Oct 2020 07:52:32 +0200
Subject: [PATCH 2/2] Remove package: imlib2-webp-1.0
---
srcpkgs/imlib2-webp | 1 +
srcpkgs/imlib2/template | 6 +++++-
2 files changed, 6 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/imlib2-webp
diff --git a/srcpkgs/imlib2-webp b/srcpkgs/imlib2-webp
new file mode 120000
index 00000000000..1c681089c93
--- /dev/null
+++ b/srcpkgs/imlib2-webp
@@ -0,0 +1 @@
+imlib2
\ No newline at end of file
diff --git a/srcpkgs/imlib2/template b/srcpkgs/imlib2/template
index 46e77f7c021..0ace131fee1 100644
--- a/srcpkgs/imlib2/template
+++ b/srcpkgs/imlib2/template
@@ -1,7 +1,7 @@
# Template file for 'imlib2'
pkgname=imlib2
version=1.7.0
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --sysconfdir=/etc/imlib2 --enable-visibility-hiding"
hostmakedepends="pkg-config"
@@ -36,3 +36,7 @@ imlib2-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+imlib2-webp_package() {
+ short_desc="WebP loader for Imlib2 (transitional dummy package)"
+}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (2 preceding siblings ...)
2020-10-01 5:54 ` mustaqimM
@ 2020-10-01 6:06 ` mustaqimM
2020-10-01 6:17 ` Chocimier
` (4 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mustaqimM @ 2020-10-01 6:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 335 bytes --]
New comment by mustaqimM on void-packages repository
https://github.com/void-linux/void-packages/pull/23225#issuecomment-701908726
Comment:
I had to rebase the latest changes, now how do I remove the first commit so I can squash the rebase with my actual commit, I'm a little lost here
Is the transitional package correctly done?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (3 preceding siblings ...)
2020-10-01 6:06 ` mustaqimM
@ 2020-10-01 6:17 ` Chocimier
2020-10-04 4:15 ` [PR PATCH] [Updated] " mustaqimM
` (3 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-10-01 6:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23225#issuecomment-701912797
Comment:
> how do I remove the first commit
Use [git rebase -i](https://git-scm.com/docs/git-rebase#_interactive_mode), squash last commit into earlier one.
> Is the transitional package correctly done?
It won't build now because is empty, build_style=meta need to be added. And we want it to be transitional, this means depends on imlib2.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Updated] Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (4 preceding siblings ...)
2020-10-01 6:17 ` Chocimier
@ 2020-10-04 4:15 ` mustaqimM
2020-10-14 15:36 ` Piraty
` (2 subsequent siblings)
8 siblings, 0 replies; 9+ messages in thread
From: mustaqimM @ 2020-10-04 4:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
There is an updated pull request by mustaqimM against master on the void-packages repository
https://github.com/mustaqimM/void-packages remove_imlib2_webp
https://github.com/void-linux/void-packages/pull/23225
Remove package: imlib2-webp-1.0
No longer required as it is included since `imlib2-1.6.0` in the November update.
A patch file from https://github.com/void-linux/void-packages/pull/23225.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-remove_imlib2_webp-23225.patch --]
[-- Type: text/x-diff, Size: 2100 bytes --]
From 50f941bbe36ef493283a4d989f782e0306a47c1a Mon Sep 17 00:00:00 2001
From: mustaqim <git@mustaqim.ml>
Date: Sun, 4 Oct 2020 06:14:49 +0200
Subject: [PATCH] Remove package: imlib2-webp-1.0
---
srcpkgs/imlib2-webp | 1 +
srcpkgs/imlib2-webp/template | 17 -----------------
srcpkgs/imlib2/template | 8 +++++++-
3 files changed, 8 insertions(+), 18 deletions(-)
create mode 120000 srcpkgs/imlib2-webp
delete mode 100644 srcpkgs/imlib2-webp/template
diff --git a/srcpkgs/imlib2-webp b/srcpkgs/imlib2-webp
new file mode 120000
index 00000000000..1c681089c93
--- /dev/null
+++ b/srcpkgs/imlib2-webp
@@ -0,0 +1 @@
+imlib2
\ No newline at end of file
diff --git a/srcpkgs/imlib2-webp/template b/srcpkgs/imlib2-webp/template
deleted file mode 100644
index 82be878061d..00000000000
--- a/srcpkgs/imlib2-webp/template
+++ /dev/null
@@ -1,17 +0,0 @@
-# Template file for 'imlib2-webp'
-pkgname=imlib2-webp
-version=1.0
-revision=1
-build_style=gnu-makefile
-hostmakedepends="pkg-config"
-makedepends="imlib2-devel libwebp-devel"
-short_desc="WebP loader for Imlib2"
-maintainer="mustaqim <mustaqim@pm.me>"
-license="custom:The Regents of the University of California, BSD-4-Clause-UC"
-homepage="https://www.hauweele.net/~gawen/imlib2-webp.html"
-distfiles="https://github.com/gawen947/imlib2-webp/archive/v${version}.tar.gz"
-checksum=252328cc4e7d232bc2fbbf1c38b963a1847e22f7ee21dd7362b7c0583dca4334
-
-post_install() {
- vlicense COPYING
-}
diff --git a/srcpkgs/imlib2/template b/srcpkgs/imlib2/template
index 46e77f7c021..3a152b61706 100644
--- a/srcpkgs/imlib2/template
+++ b/srcpkgs/imlib2/template
@@ -1,7 +1,7 @@
# Template file for 'imlib2'
pkgname=imlib2
version=1.7.0
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--disable-static --sysconfdir=/etc/imlib2 --enable-visibility-hiding"
hostmakedepends="pkg-config"
@@ -36,3 +36,9 @@ imlib2-devel_package() {
vmove "usr/lib/*.so"
}
}
+
+imlib2-webp_package() {
+ build_style=meta
+ depends="${sourcepkg}>=${version}_${revision}"
+ short_desc="WebP loader for Imlib2 (transitional dummy package)"
+}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (5 preceding siblings ...)
2020-10-04 4:15 ` [PR PATCH] [Updated] " mustaqimM
@ 2020-10-14 15:36 ` Piraty
2020-10-14 18:14 ` [PR PATCH] [Merged]: " Chocimier
2020-10-14 18:19 ` Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: Piraty @ 2020-10-14 15:36 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/23225#issuecomment-708484312
Comment:
fine to merge @Chocimier ?
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PR PATCH] [Merged]: Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (6 preceding siblings ...)
2020-10-14 15:36 ` Piraty
@ 2020-10-14 18:14 ` Chocimier
2020-10-14 18:19 ` Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-10-14 18:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
There's a merged pull request on the void-packages repository
Remove package: imlib2-webp-1.0
https://github.com/void-linux/void-packages/pull/23225
Description:
No longer required as it is included since `imlib2-1.6.0` in the November update.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Remove package: imlib2-webp-1.0
[not found] <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-23225@inbox.vuxu.org>
` (7 preceding siblings ...)
2020-10-14 18:14 ` [PR PATCH] [Merged]: " Chocimier
@ 2020-10-14 18:19 ` Chocimier
8 siblings, 0 replies; 9+ messages in thread
From: Chocimier @ 2020-10-14 18:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 279 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/23225#issuecomment-708577078
Comment:
Fine. Thanks @mustaqimM.
Btw, once done with changes, add a comment. Otherwise we don't know about changes, what delays review a lot.
^ permalink raw reply [flat|nested] 9+ messages in thread