Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Add libQtWebkit.so.4 to common/shlibs
@ 2020-10-07 12:57 shahab-vahedi
  2020-10-07 13:00 ` q66
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: shahab-vahedi @ 2020-10-07 12:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

There is a new pull request by shahab-vahedi against master on the void-packages repository

https://github.com/shahab-vahedi/void-packages libqtwebkit4
https://github.com/void-linux/void-packages/pull/25411

Add libQtWebkit.so.4 to common/shlibs
The commit message follows in the end. One remark that I have to make is that I am not 100% sure the line that I chose to add the entry is the best one.
```
When building a modified version of "goldendict" [1], I ended up
with this error:

  SONAME: libQtWebKit.so.4 <-> UNKNOWN PKG PLEASE FIX!

Here's the package added.

[1] modified "template" of "goldendict"
Because Qt5 webkit does not render right-to-left texts nicely, I
build my "goldendict" against Qt4; i.e. replace "qt5-webkit-devel"
with "qt-webkit-devel".
```

A patch file from https://github.com/void-linux/void-packages/pull/25411.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libqtwebkit4-25411.patch --]
[-- Type: text/x-diff, Size: 1070 bytes --]

From 4e53f774071fce711801c2ddc7d8a919fa8694c2 Mon Sep 17 00:00:00 2001
From: Shahab Vahedi <shahab.vahedi@gmail.com>
Date: Wed, 7 Oct 2020 14:53:17 +0200
Subject: [PATCH] Add libQtWebkit.so.4 to common/shlibs

When building a modified version of "goldendict" [1], I ended up
with this error:

  SONAME: libQtWebKit.so.4 <-> UNKNOWN PKG PLEASE FIX!

Here's the package added.

[1] modified "template" of "goldendict"
Because Qt5 webkit does not render right-to-left texts nicely, I
build my "goldendict" against Qt4; i.e. replace "qt5-webkit-devel"
with "qt-webkit-devel".
---
 common/shlibs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/shlibs b/common/shlibs
index 7dad8c2117d..54eb5ddc78b 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -456,6 +456,7 @@ libQtSql.so.4 qt-4.5.3_1
 libQtDeclarative.so.4 qt-4.5.3_1
 libQtDesignerComponents.so.4 qt-designer-libs-4.7.8_13
 libQtDesigner.so.4 qt-designer-libs-4.7.8_13
+libQtWebKit.so.4 qt-webkit-2.3.4_7
 libsysfs.so.2 libsysfs-2.1.0_1
 libsensors.so.5 libsensors-3.5.0_1
 libcap-ng.so.0 libcap-ng-0.6.2_1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Add libQtWebkit.so.4 to common/shlibs
  2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
@ 2020-10-07 13:00 ` q66
  2020-10-07 13:01 ` q66
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2020-10-07 13:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25411#issuecomment-704918636

Comment:
considering qt4 (and therefore qt4 webkit) is due for removal at one point, i'd say let's not

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Add libQtWebkit.so.4 to common/shlibs
  2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
  2020-10-07 13:00 ` q66
@ 2020-10-07 13:01 ` q66
  2020-10-07 13:01 ` [PR PATCH] [Closed]: " q66
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2020-10-07 13:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25411#issuecomment-704919359

Comment:
ah, it's already gone, nevermind

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: Add libQtWebkit.so.4 to common/shlibs
  2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
  2020-10-07 13:00 ` q66
  2020-10-07 13:01 ` q66
@ 2020-10-07 13:01 ` q66
  2020-10-07 13:02 ` q66
  2020-10-07 13:06 ` shahab-vahedi
  4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2020-10-07 13:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

There's a closed pull request on the void-packages repository

Add libQtWebkit.so.4 to common/shlibs
https://github.com/void-linux/void-packages/pull/25411

Description:
The commit message follows in the end. One remark that I have to make is that I am not 100% sure the line that I chose to add the entry is the best one.
```
When building a modified version of "goldendict" [1], I ended up
with this error:

  SONAME: libQtWebKit.so.4 <-> UNKNOWN PKG PLEASE FIX!

Here's the package added.

[1] modified "template" of "goldendict"
Because Qt5 webkit does not render right-to-left texts nicely, I
build my "goldendict" against Qt4; i.e. replace "qt5-webkit-devel"
with "qt-webkit-devel".
```

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Add libQtWebkit.so.4 to common/shlibs
  2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
                   ` (2 preceding siblings ...)
  2020-10-07 13:01 ` [PR PATCH] [Closed]: " q66
@ 2020-10-07 13:02 ` q66
  2020-10-07 13:06 ` shahab-vahedi
  4 siblings, 0 replies; 6+ messages in thread
From: q66 @ 2020-10-07 13:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/25411#issuecomment-704919359

Comment:
ah, it's already gone, nevermind (removed by commit 5ed19a7c3cb5da1a82c226ce276a7e932f7141ab)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Add libQtWebkit.so.4 to common/shlibs
  2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
                   ` (3 preceding siblings ...)
  2020-10-07 13:02 ` q66
@ 2020-10-07 13:06 ` shahab-vahedi
  4 siblings, 0 replies; 6+ messages in thread
From: shahab-vahedi @ 2020-10-07 13:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by shahab-vahedi on void-packages repository

https://github.com/void-linux/void-packages/pull/25411#issuecomment-704922757

Comment:
It is very unfortunate that `qt4` will be removed. `Qt5Webkit` is buggy and they haven't responded to my [bug report](https://github.com/qtwebkit/qtwebkit/issues/893) for years.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-10-07 13:06 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-07 12:57 [PR PATCH] Add libQtWebkit.so.4 to common/shlibs shahab-vahedi
2020-10-07 13:00 ` q66
2020-10-07 13:01 ` q66
2020-10-07 13:01 ` [PR PATCH] [Closed]: " q66
2020-10-07 13:02 ` q66
2020-10-07 13:06 ` shahab-vahedi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).