[PR PATCH] scons: update to 4.0.1

[PR PATCH] scons: update to 4.0.1

[kkga]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

There is a new pull request by kkga against master on the void-packages repository

https://github.com/kkga/void-packages update-scons
https://github.com/void-linux/void-packages/pull/25736

scons: update to 4.0.1


A patch file from https://github.com/void-linux/void-packages/pull/25736.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-scons-25736.patch --]
[-- Type: text/x-diff, Size: 1261 bytes --]

From 1d9ebf2437c615d217476cdb2b31a59919ef2972 Mon Sep 17 00:00:00 2001
From: Gadzhi Kharkharov <me@kkga.me>
Date: Mon, 19 Oct 2020 14:31:50 +0300
Subject: [PATCH] scons: update to 4.0.1

---
 srcpkgs/scons/template | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/scons/template b/srcpkgs/scons/template
index 52c8013f7d6..a527bc6b69e 100644
--- a/srcpkgs/scons/template
+++ b/srcpkgs/scons/template
@@ -1,19 +1,19 @@
 # Template file for 'scons'
 pkgname=scons
-version=3.1.2
-revision=3
-build_style=python2-module
-make_install_args="--standard-lib --install-data=/usr/share"
-hostmakedepends="python python-setuptools"
-depends="python"
+version=4.0.1
+revision=1
+wrksrc="SCons-${version}"
+build_style=python3-module
+hostmakedepends="python3 python3-setuptools"
+depends="python3"
 short_desc="Software construction tool"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="MIT"
 homepage="https://www.scons.org/"
 distfiles="${SOURCEFORGE_SITE}/${pkgname}/${pkgname}-${version}.tar.gz"
-checksum="7801f3f62f654528e272df780be10c0e9337e897650b62ddcee9f39fde13f8fb"
+checksum=722ed104b5c624ecdc89bd4e02b094d2b14d99d47b5d0501961e47f579a2007c
 
 
 post_install() {
-	vlicense LICENSE.txt
+	vlicense LICENSE
 }

Re: [PR PATCH] [Closed]: scons: update to 4.0.1

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 156 bytes --]

There's a closed pull request on the void-packages repository

scons: update to 4.0.1
https://github.com/void-linux/void-packages/pull/25736

Description:

Re: scons: update to 4.0.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25736#issuecomment-712226856

Comment:
https://github.com/void-linux/void-packages/pull/24448

Re: scons: update to 4.0.1

[kkga]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by kkga on void-packages repository

https://github.com/void-linux/void-packages/pull/25736#issuecomment-712269791

Comment:
@Duncaen hope I didn't mess something up 😬
FWIW I did test the updated package on compiling Godot successfully.

Re: scons: update to 4.0.1

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/25736#issuecomment-712274231

Comment:
It was [reverted](https://github.com/void-linux/void-packages/commit/a2bc9acbea4e92c70093dc0f2e400630a97af089) which results in a useless update from revision 3 to 4, but that happens.

Usually good to check open PRs or Issues if you want to update something.

Re: scons: update to 4.0.1

[sgn]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/25789#issuecomment-714589609

Comment:
@CameronNemo @kkga @ev-ermakov  please take a look on what you care.

Re: scons: update to 4.0.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-712221189

Comment:
I put my integration branch here https://github.com/sgn/void-packages/tree/scons-python-3

Re: scons: update to 4.0.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-688548072

Comment:
I think we're better:
- ship 2 packages: `scons2` and `scons`
- and either drop scons build-style or set `make_cmd=scons2` for those stubborn packages, some 20 packages isn't much anyway.
- See if any-upstream is inactive and drop their software.

Re: scons: update to 4.0.1.

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-688511270

Comment:
Relevant sections of release notes with my annotations:

> NOTE: The 4.0.0 Release of SCons dropped Python 2.7 Support

This is what we want largely. Need to test build of packages using scons because the build scripts are literally python files.

> - Allow user specified location for vswhere.exe specified by VSWHERE.
> NOTE: This must be set at the time the 'msvc' 'msvs' and/or 'mslink' tool(s) are initialized to have any effect.

Does not apply to us.

> - Resolve Issue #3248 - Removing '-Wl,-Bsymbolic' from SHLIBVERSIONFLAGS
> NOTE: If your build depends on the above you must now add to your SHLIBVERSIONFLAGS

Might apply to us? We will see during rebuild I guess.

> - Fixed Github Issue 3628 - Hardcoding pickle protocol to 4 (supports python 3.4+)
> and skipping Python 3.8's new pickle protocol 5 whose main advantage is for out-of-band data buffers.
> NOTE: If you used Python 3.8 with SCons 3.0.0 or above, you may get a a pickle protocol error. Remove your
> .sconsign.dblite. You will end up with a full rebuild.

Does not apply to us (only ever used python2).

Re: scons: update to 4.0.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-679073466

Comment:
- `pingus` is python 2 only for the current release, upstream switch to cmake in development tree, Debian patched it
- `xboxdrv`, `fceux` I was wrong, their master use cmake, their released version use Python 2 scons
- `double-conversion` supports cmake, too. But, it seems like they prefer scons.

Re: scons: update to 4.0.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-679073466

Comment:
- `pingus` is python 2 only for the current release, upstream switch to cmake in development tree, Debian patched it
- `xboxdrv` switched to CMake as official build system, I'll take care
    - `fceux` I was wrong, their master use cmake, their released version use Python 2 scons
- `double-conversion` supports cmake, too. But, it seems like they prefer scons.

Re: scons: update to 4.0.1.

[sgn]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/24448#issuecomment-679073466

Comment:
- `pingus` is python 2 only for the current release, upstream switch to cmake in development tree, Debian patched it
- `fceux`, `xboxdrv` switched to CMake as official build system, I'll take care
- `double-conversion` supports cmake, too. But, it seems like they prefer scons.