* [PR PATCH] common/shlibs: add shlibs for simavr
@ 2020-10-19 15:25 Logarithmus
2020-10-19 15:39 ` sgn
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Logarithmus @ 2020-10-19 15:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 380 bytes --]
There is a new pull request by Logarithmus against master on the void-packages repository
https://github.com/Logarithmus/void-packages common-shlibs-simavr
https://github.com/void-linux/void-packages/pull/25741
common/shlibs: add shlibs for simavr
Add missing shlib entries for `simavr`
A patch file from https://github.com/void-linux/void-packages/pull/25741.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-common-shlibs-simavr-25741.patch --]
[-- Type: text/x-diff, Size: 627 bytes --]
From a7a0180aeffcdeb9853f85b28fb0434774fc7316 Mon Sep 17 00:00:00 2001
From: Artur Sinila <opensource@logarithmus.dev>
Date: Mon, 19 Oct 2020 18:10:14 +0300
Subject: [PATCH] common/shlibs: add shlibs for simavr
---
common/shlibs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/shlibs b/common/shlibs
index 35f08f5f099..2a8981219d2 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -3991,3 +3991,5 @@ libneatvnc.so.0 neatvnc-0.2.0_1
libtdjson.so.1.6.0 libtd-1.6.0_1
libJudy.so.1 judy-1.0.5_1
libsignal-protocol-c.so.2 libsignal-protocol-c-2.3.3_2
+libsimavr.so.1 simavr-1.6_2
+libsimavrparts.so.1 simavr-1.6_2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: common/shlibs: add shlibs for simavr
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
@ 2020-10-19 15:39 ` sgn
2020-10-19 15:55 ` Duncaen
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sgn @ 2020-10-19 15:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 434 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/25741#issuecomment-712252686
Comment:
Can you explain why we need this shlibs entry?
> Can someone explain why do we need to add shlibs manually?
We only add shlibs entry for those required by other packages.
And we don't change it automatically to ask packager to also rebuild other relevant packages when `SONAME` was changed.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: common/shlibs: add shlibs for simavr
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
2020-10-19 15:39 ` sgn
@ 2020-10-19 15:55 ` Duncaen
2020-10-19 15:57 ` Duncaen
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2020-10-19 15:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/25741#issuecomment-712263185
Comment:
> Can someone explain why do we need to add shlibs manually?
> How hard is to automate this process?
It records the first version a shared library was introduced to create dependencies like `librarypkg>=firstversion`.
Automating it by using repository metadata would introduce state that depends on the build history so its not reproducible anymore and depending on the history xbps-src would generate different dependencies.
Automatically changing tracked files when running xbps-src is also not that nice and would probably lead to more issues than changing the file manually if required.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: common/shlibs: add shlibs for simavr
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
2020-10-19 15:39 ` sgn
2020-10-19 15:55 ` Duncaen
@ 2020-10-19 15:57 ` Duncaen
2020-10-20 0:32 ` ahesford
2020-10-20 0:32 ` [PR PATCH] [Closed]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2020-10-19 15:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/25741#issuecomment-712263185
Comment:
> Can someone explain why do we need to add shlibs manually?
> How hard is to automate this process?
It records the first version a shared library was introduced to create dependencies like `librarypkg>=firstversion`.
Automating it by using repository metadata would introduce state that depends on the build history so its not reproducible anymore and depending on the history or your local xbps repository the dependencies would differ from the build servers history.
Automatically changing tracked files when running xbps-src is also not that nice and would probably lead to more issues than changing the file manually if required.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: common/shlibs: add shlibs for simavr
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
` (2 preceding siblings ...)
2020-10-19 15:57 ` Duncaen
@ 2020-10-20 0:32 ` ahesford
2020-10-20 0:32 ` [PR PATCH] [Closed]: " ahesford
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-10-20 0:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/25741#issuecomment-712515859
Comment:
Superseded by #25742
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PR PATCH] [Closed]: common/shlibs: add shlibs for simavr
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
` (3 preceding siblings ...)
2020-10-20 0:32 ` ahesford
@ 2020-10-20 0:32 ` ahesford
4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2020-10-20 0:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
There's a closed pull request on the void-packages repository
common/shlibs: add shlibs for simavr
https://github.com/void-linux/void-packages/pull/25741
Description:
Add missing shlib entries for `simavr`
Can someone explain why do we need to add shlibs manually?
How hard is to automate this process?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-20 0:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 15:25 [PR PATCH] common/shlibs: add shlibs for simavr Logarithmus
2020-10-19 15:39 ` sgn
2020-10-19 15:55 ` Duncaen
2020-10-19 15:57 ` Duncaen
2020-10-20 0:32 ` ahesford
2020-10-20 0:32 ` [PR PATCH] [Closed]: " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).