[PR PATCH] gitui: update to 0.10.0.

[PR PATCH] gitui: update to 0.10.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitui-0.10.0_1
https://github.com/void-linux/void-packages/pull/24547

gitui: update to 0.10.0.
None

A patch file from https://github.com/void-linux/void-packages/pull/24547.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitui-0.10.0_1-24547.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

From 0bfb76a4923e9c3afa9d2c8233e038c3ef0949a1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 30 Aug 2020 14:23:43 +0200
Subject: [PATCH] gitui: update to 0.10.0.

---
 srcpkgs/gitui/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitui/template b/srcpkgs/gitui/template
index 5494f0bf922..92dc36eb927 100644
--- a/srcpkgs/gitui/template
+++ b/srcpkgs/gitui/template
@@ -1,6 +1,6 @@
 # Template file for 'gitui'
 pkgname=gitui
-version=0.9.1
+version=0.10.0
 revision=1
 build_style=cargo
 short_desc="Blazing fast terminal-ui for git"
@@ -8,7 +8,7 @@ maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/extrawurst/gitui"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=2112575a5ec65f744572d38df9f4f79e7547fc2139093a6c9cf2e9ad85bdf547
+checksum=79cb81dbe3c3293825e9f2be13e3455dd2e6d6289fd11b0a039f206acf6bf25c
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR PATCH] [Updated] gitui: update to 0.10.0.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitui-0.10.0_1
https://github.com/void-linux/void-packages/pull/24547

gitui: update to 0.10.0.
None

A patch file from https://github.com/void-linux/void-packages/pull/24547.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitui-0.10.0_1-24547.patch --]
[-- Type: text/x-diff, Size: 1051 bytes --]

From 1f78fd5c7c521770b5e3a1f7bdc07338719e640c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 30 Aug 2020 14:23:43 +0200
Subject: [PATCH] gitui: update to 0.10.1.

---
 srcpkgs/gitui/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitui/template b/srcpkgs/gitui/template
index 5494f0bf922..78ce0b0ca60 100644
--- a/srcpkgs/gitui/template
+++ b/srcpkgs/gitui/template
@@ -1,14 +1,15 @@
 # Template file for 'gitui'
 pkgname=gitui
-version=0.9.1
+version=0.10.1
 revision=1
 build_style=cargo
+hostmakedepends="python3"
 short_desc="Blazing fast terminal-ui for git"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/extrawurst/gitui"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=2112575a5ec65f744572d38df9f4f79e7547fc2139093a6c9cf2e9ad85bdf547
+checksum=2d6fa87d88002716cf0fedef9d4332b7212ee05fbfa4b8c536ae4270bef99bce
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR REVIEW] gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#discussion_r482924577

Comment:
A new dependency of gitui requires `python3` for building, which is what caused the previous CI failure.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686445966

Comment:
Now it fails because it needs a newer rust version.

Re: gitui: update to 0.10.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686448585

Comment:
Please try to test building locally. You should have tested the resulting package in runtime as well.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686541413

Comment:
Isn't that what the CI is for?

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686541413

Comment:
> Please try to test building locally.

Isn't that what the CI is for?

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686541413

Comment:
> Please try to test building locally.

Isn't that what the CI is for?

For new packages, I always build them locally and test them in runtime, but compiling them for each version bump is a bit much with these rust packages as rust has quite long compilation times. If xbps-src had support for (global) compilation caches in rust builds, using sccache or something like that, it'd be okay, but like this it just eats up too much time.

Re: gitui: update to 0.10.1.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686547785

Comment:
> Isn't that what the CI is for?

CI is limited and it blocks other PRs.

Re: gitui: update to 0.10.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686551759

Comment:
> Isn't that what the CI is for?

CI doesn't run package checks, so it's possible that one of the many moving pieces involved broke a new release. And even if it did run, checks can't cover all runtime related stuff. At least launching it quickly and being sure that basic functionality is still there is very important.

This isn't a critical package, so breakages are a smaller issue, but it isn't nice anyway.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686556041

Comment:
> CI doesn't run package checks, so it's possible that one of the many moving pieces involved broke a new release. And even if it did run, checks can't cover all runtime related stuff. At least launching it quickly and being sure that basic functionality is still there is very important.

Luckily that's quite rare with rust (which is the reason I didn't do that stuff for version bumps so far, because I thought the risk was low enough), but I agree. Will compile locally and launch it at least once.

> This isn't a critical package, so breakages are a smaller issue, but it isn't nice anyway.

Of course, breakage is never nice.

> CI is limited and it blocks other PRs.

Well, so is my time and resources. waiting a bit until CI has run through doesn't block the workflow usually, building the packages locally is more overhead IMO.

Would integrating sccache into rust packages in xbps-src be accepted upstream? That would make it easier for me to test the packages locally. Would be optional of course, behind an env var or something like that.

Re: gitui: update to 0.10.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686558827

Comment:
> Would integrating sccache into rust packages in xbps-src be accepted upstream? That would make it easier for me to test the packages locally. Would be optional of course, behind an env var or something like that.

I believe it would be very appreciated, but AFAIK it currently isn't possible, since they require a server setup and some other stuff.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686556041

Comment:
> CI doesn't run package checks, so it's possible that one of the many moving pieces involved broke a new release. And even if it did run, checks can't cover all runtime related stuff. At least launching it quickly and being sure that basic functionality is still there is very important.

Luckily that's quite rare with rust (which is the reason I didn't do that stuff for version bumps so far, because I thought the risk was low enough), but I agree. Will compile locally and launch it at least once.

> This isn't a critical package, so breakages are a smaller issue, but it isn't nice anyway.

Of course, breakage is never nice.

> CI is limited and it blocks other PRs.

Well, so is my time and resources (for reference: a lot of these PRs are coming from a Pinebook Pro, clean builds of these packages take quite a while and drain the battery considerably). waiting a bit until CI has run through doesn't block the workflow usually, building the packages locally is more overhead IMO.

Would integrating sccache into rust packages in xbps-src be accepted upstream? That would make it easier for me to test the packages locally. Would be optional of course, behind an env var or something like that.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686560104

Comment:
> I believe it would be very appreciated, but AFAIK it currently isn't possible, since they require a server setup and some other stuff.

sccache can either use object storage server stuff, or a local directory. Putting a directory in the masterdir should work afaik.

Re: gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]

New comment by jcgruenhage on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686556041

Comment:
> CI doesn't run package checks, so it's possible that one of the many moving pieces involved broke a new release. And even if it did run, checks can't cover all runtime related stuff. At least launching it quickly and being sure that basic functionality is still there is very important.

Luckily that's quite rare with rust (which is the reason I didn't do that stuff for version bumps so far, because I thought the risk was low enough), but I agree. Will compile locally and launch it at least once.

> This isn't a critical package, so breakages are a smaller issue, but it isn't nice anyway.

Of course, breakage is never nice.

> CI is limited and it blocks other PRs.

Well, so is my time and resources (for reference: a lot of these PRs are coming from a Pinebook Pro, clean builds of these packages take quite a while and drain the battery considerably, half an hour and 10% battery for topgrade for example). waiting a bit until CI has run through doesn't block the workflow usually, building the packages locally is more overhead IMO.

Would integrating sccache into rust packages in xbps-src be accepted upstream? That would make it easier for me to test the packages locally. Would be optional of course, behind an env var or something like that.

Re: gitui: update to 0.10.1.

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/24547#issuecomment-686646391

Comment:
You can also enable travis on your fork (for free) and run CI on branches you push to your fork before opening PRs, this wouldn't block the CI for void-linux/void-packages.

Re: [PR PATCH] [Updated] gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitui-0.10.0_1
https://github.com/void-linux/void-packages/pull/24547

gitui: update to 0.10.1.
None

A patch file from https://github.com/void-linux/void-packages/pull/24547.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitui-0.10.0_1-24547.patch --]
[-- Type: text/x-diff, Size: 1036 bytes --]

From 0fa354bf67959b2579436d829971a775371359c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 30 Aug 2020 14:23:43 +0200
Subject: [PATCH] gitui: update to 0.10.0.

---
 srcpkgs/gitui/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitui/template b/srcpkgs/gitui/template
index 5494f0bf922..92dc36eb927 100644
--- a/srcpkgs/gitui/template
+++ b/srcpkgs/gitui/template
@@ -1,6 +1,6 @@
 # Template file for 'gitui'
 pkgname=gitui
-version=0.9.1
+version=0.10.0
 revision=1
 build_style=cargo
 short_desc="Blazing fast terminal-ui for git"
@@ -8,7 +8,7 @@ maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/extrawurst/gitui"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=2112575a5ec65f744572d38df9f4f79e7547fc2139093a6c9cf2e9ad85bdf547
+checksum=79cb81dbe3c3293825e9f2be13e3455dd2e6d6289fd11b0a039f206acf6bf25c
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR PATCH] [Updated] gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitui-0.10.0_1
https://github.com/void-linux/void-packages/pull/24547

gitui: update to 0.10.1.
None

A patch file from https://github.com/void-linux/void-packages/pull/24547.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitui-0.10.0_1-24547.patch --]
[-- Type: text/x-diff, Size: 1051 bytes --]

From a8efad698da8057ded8d35e7bd793604c00a3978 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 30 Aug 2020 14:23:43 +0200
Subject: [PATCH] gitui: update to 0.10.1.

---
 srcpkgs/gitui/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitui/template b/srcpkgs/gitui/template
index 5494f0bf922..78ce0b0ca60 100644
--- a/srcpkgs/gitui/template
+++ b/srcpkgs/gitui/template
@@ -1,14 +1,15 @@
 # Template file for 'gitui'
 pkgname=gitui
-version=0.9.1
+version=0.10.1
 revision=1
 build_style=cargo
+hostmakedepends="python3"
 short_desc="Blazing fast terminal-ui for git"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/extrawurst/gitui"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=2112575a5ec65f744572d38df9f4f79e7547fc2139093a6c9cf2e9ad85bdf547
+checksum=2d6fa87d88002716cf0fedef9d4332b7212ee05fbfa4b8c536ae4270bef99bce
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR PATCH] [Updated] gitui: update to 0.10.1.

[jcgruenhage]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitui-0.10.0_1
https://github.com/void-linux/void-packages/pull/24547

gitui: update to 0.10.1.
None

A patch file from https://github.com/void-linux/void-packages/pull/24547.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitui-0.10.0_1-24547.patch --]
[-- Type: text/x-diff, Size: 1094 bytes --]

From 39b0c184b18709d747c6c7eb801acfa2082a4b67 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 30 Aug 2020 14:23:43 +0200
Subject: [PATCH] gitui: update to 0.10.1.

---
 srcpkgs/gitui/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitui/template b/srcpkgs/gitui/template
index 5494f0bf922..fff85c43aa8 100644
--- a/srcpkgs/gitui/template
+++ b/srcpkgs/gitui/template
@@ -1,14 +1,16 @@
 # Template file for 'gitui'
 pkgname=gitui
-version=0.9.1
+version=0.10.1
 revision=1
 build_style=cargo
+hostmakedepends="python3"
+makedepends="libxcb-devel libgit2-devel"
 short_desc="Blazing fast terminal-ui for git"
 maintainer="Jan Christian Grünhage <jan.christian@gruenhage.xyz>"
 license="MIT"
 homepage="https://github.com/extrawurst/gitui"
 distfiles="${homepage}/archive/v${version}.tar.gz"
-checksum=2112575a5ec65f744572d38df9f4f79e7547fc2139093a6c9cf2e9ad85bdf547
+checksum=2d6fa87d88002716cf0fedef9d4332b7212ee05fbfa4b8c536ae4270bef99bce
 
 post_install() {
 	vlicense LICENSE.md

Re: [PR PATCH] [Merged]: gitui: update to 0.10.1.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

There's a merged pull request on the void-packages repository

gitui: update to 0.10.1.
https://github.com/void-linux/void-packages/pull/24547

Description:
None